mirror of
https://github.com/coder/coder.git
synced 2026-10-31 11:02:50 +08:00
## Problem When a key returned 401 or 403, the pool marked it permanently unavailable for the lifetime of that in-memory pool. This is bad UX: a transient auth failure or a briefly-misconfigured key could take a key out of rotation until the operator either restarted Coder or reconfigured the key (even re-saving the same working value). ## Changes - **403 removed from key failover**: it's a per-request authorization failure, not a key-level problem, so it's surfaced to the caller as-is without marking the key or failing over. - **401 now applies a temporary cooldown** (like 429) so the key recovers on its own instead of staying blocked. - When every key is in an auth-failure cooldown, the pool reports a `502` with no `Retry-After`, but the keys still recover automatically once the cooldown elapses. Closes https://linear.app/codercom/issue/AIGOV-421/ai-gateway-a-quarantined-centralized-key-never-recovers-without-a Closes https://linear.app/codercom/issue/AIGOV-533/403s-misclassifying-keys-as-permanently-down-in-ai-gateway > [!NOTE] > Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira
118 lines
3.3 KiB
Go
118 lines
3.3 KiB
Go
package keypool
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"net/http"
|
|
|
|
"cdr.dev/slog/v3"
|
|
"github.com/coder/coder/v2/aibridge/utils"
|
|
)
|
|
|
|
// KeyFailoverConfig is the per-provider configuration consumed by
|
|
// NewKeyFailoverTransport.
|
|
type KeyFailoverConfig struct {
|
|
// Pool is the key pool to walk. Nil disables key failover.
|
|
Pool *Pool
|
|
|
|
Logger slog.Logger
|
|
|
|
// IsBYOK returns true when the request already carries
|
|
// user-supplied auth. BYOK requests skip key failover.
|
|
IsBYOK func(*http.Request) bool
|
|
|
|
// InjectAuthKey writes the key value into the outbound headers
|
|
// in the format the provider expects.
|
|
InjectAuthKey func(*http.Header, string)
|
|
|
|
// BuildKeyPoolResponse renders the response sent to the client
|
|
// when the walker has no more keys to try.
|
|
BuildKeyPoolResponse func(*Error) *http.Response
|
|
}
|
|
|
|
// keyFailoverTransport retries inner across the key pool on
|
|
// key-specific failures.
|
|
type keyFailoverTransport struct {
|
|
inner http.RoundTripper
|
|
config KeyFailoverConfig
|
|
}
|
|
|
|
// NewKeyFailoverTransport returns an http.RoundTripper backed by
|
|
// keyFailoverTransport. If config.Pool is nil, inner is returned
|
|
// unchanged.
|
|
func NewKeyFailoverTransport(inner http.RoundTripper, config KeyFailoverConfig) http.RoundTripper {
|
|
if config.Pool == nil {
|
|
return inner
|
|
}
|
|
return &keyFailoverTransport{
|
|
inner: inner,
|
|
config: config,
|
|
}
|
|
}
|
|
|
|
// RoundTrip is invoked by the proxy once per outer client request,
|
|
// after Rewrite has applied proxy headers.
|
|
//
|
|
// For centralized requests it walks the key pool, retrying on
|
|
// key-specific failures until one key succeeds or the pool is
|
|
// exhausted. BYOK requests skip the failover loop.
|
|
func (t *keyFailoverTransport) RoundTrip(req *http.Request) (*http.Response, error) {
|
|
if t.config.IsBYOK(req) {
|
|
return t.inner.RoundTrip(req)
|
|
}
|
|
|
|
// Buffer once so retries can replay the body.
|
|
body, err := bufferBody(req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Fresh walker per request, independent of other inflight requests.
|
|
walker := t.config.Pool.Walker()
|
|
defer func() { t.config.Pool.RecordAttempts(walker.Attempts()) }()
|
|
for {
|
|
key, keyPoolErr := walker.Next()
|
|
if keyPoolErr != nil {
|
|
resp := t.config.BuildKeyPoolResponse(keyPoolErr)
|
|
if resp == nil {
|
|
// Fallback if BuildKeyPoolResponse returns nil.
|
|
body := []byte(`{"error":"key pool unavailable"}`)
|
|
resp = utils.NewJSONErrorResponse(http.StatusBadGateway, 0, body)
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
// Clone per attempt so the original request isn't mutated.
|
|
outReq := req.Clone(req.Context())
|
|
if body != nil {
|
|
outReq.Body = io.NopCloser(bytes.NewReader(body))
|
|
}
|
|
t.config.InjectAuthKey(&outReq.Header, key.Value())
|
|
|
|
resp, rtErr := t.inner.RoundTrip(outReq)
|
|
if rtErr != nil {
|
|
// Transport-level error, not a key issue.
|
|
return resp, rtErr
|
|
}
|
|
// MarkKeyOnStatus returns true on key-specific failures (e.g. 401/429).
|
|
if t.config.Pool.MarkKeyOnStatus(req.Context(), key, resp, t.config.Logger) {
|
|
// Drain and retry with the next key.
|
|
_, _ = io.Copy(io.Discard, resp.Body)
|
|
_ = resp.Body.Close()
|
|
continue
|
|
}
|
|
// Success or non-key error, forward as-is.
|
|
return resp, nil
|
|
}
|
|
}
|
|
|
|
// bufferBody reads the request body fully so it can be replayed
|
|
// across key-failover retries. Returns nil for a nil body.
|
|
func bufferBody(req *http.Request) ([]byte, error) {
|
|
if req.Body == nil {
|
|
return nil, nil
|
|
}
|
|
defer req.Body.Close()
|
|
return io.ReadAll(req.Body)
|
|
}
|