mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
## Description Adds automatic key failover for centralized OpenAI provider, covering both chat completions and responses APIs. Same shape as the Anthropic PR: each upstream call walks the configured key pool, keys are marked **temporary** on 429 (with cooldown from `Retry-After`) and **permanent** on 401/403. Each agentic-loop iteration gets its own fresh walker so a tool-call continuation can fail over independently of the initial request. BYOK is unchanged: BYOK requests run as a single attempt with no failover. ## Changes - `config.OpenAI` carries a `KeyPool`. `Key` remains for BYOK Authorization Bearer set per interception. - Chat completions blocking interceptor: walks the pool via `newChatCompletionWithKeyFailover`, marks keys on key-specific failures, returns on first success or non-failover error. - Chat completions streaming interceptor: per-iteration walker. Pre-stream failures fail over to the next key; mid-stream errors are relayed as SSE events. - Responses blocking interceptor: extracts `newResponseWithKeyFailover` parallel to chatcompletions. - Responses streaming interceptor: per-iteration walker, retains the existing buffer-then-forward design. ## Related Issues Related to: https://github.com/coder/internal/issues/1446 Related to: https://linear.app/codercom/issue/AIGOV-197/aibridge-automatic-key-failover-for-bridged-and-passthrough-routes ## Follow-up PRs - Bedrock multi-key support. - Refactor provider vs interceptor config separation. - Record the actually-used key in the interception credential hint after failover. > [!NOTE] > Initially generated by Claude Opus 4.7, modified and reviewed by @ssncferreira
217 lines
7.9 KiB
Go
217 lines
7.9 KiB
Go
//go:build !slim
|
|
|
|
package cli
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"golang.org/x/xerrors"
|
|
|
|
"github.com/coder/coder/v2/aibridge"
|
|
"github.com/coder/coder/v2/aibridge/config"
|
|
"github.com/coder/coder/v2/aibridge/keypool"
|
|
"github.com/coder/coder/v2/coderd/tracing"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/enterprise/aibridged"
|
|
"github.com/coder/coder/v2/enterprise/coderd"
|
|
"github.com/coder/quartz"
|
|
)
|
|
|
|
func newAIBridgeDaemon(coderAPI *coderd.API, providers []aibridge.Provider) (*aibridged.Server, error) {
|
|
ctx := context.Background()
|
|
coderAPI.Logger.Debug(ctx, "starting in-memory aibridge daemon")
|
|
|
|
logger := coderAPI.Logger.Named("aibridged")
|
|
|
|
reg := prometheus.WrapRegistererWithPrefix("coder_aibridged_", coderAPI.PrometheusRegistry)
|
|
metrics := aibridge.NewMetrics(reg)
|
|
tracer := coderAPI.TracerProvider.Tracer(tracing.TracerName)
|
|
|
|
// Create pool for reusable stateful [aibridge.RequestBridge] instances (one per user).
|
|
pool, err := aibridged.NewCachedBridgePool(aibridged.DefaultPoolOptions, providers, logger.Named("pool"), metrics, tracer) // TODO: configurable size.
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("create request pool: %w", err)
|
|
}
|
|
|
|
// Create daemon.
|
|
srv, err := aibridged.New(ctx, pool, func(dialCtx context.Context) (aibridged.DRPCClient, error) {
|
|
return coderAPI.CreateInMemoryAIBridgeServer(dialCtx)
|
|
}, logger, tracer)
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("start in-memory aibridge daemon: %w", err)
|
|
}
|
|
return srv, nil
|
|
}
|
|
|
|
// buildProviders constructs the list of aibridge providers from config.
|
|
// It merges legacy single-provider env vars and indexed provider configs:
|
|
// 1. Legacy providers (from CODER_AIBRIDGE_OPENAI_KEY, etc.) are added first.
|
|
// If a legacy name conflicts with an indexed provider, startup fails with
|
|
// a clear error asking the admin to remove one or the other.
|
|
// 2. Indexed providers (from CODER_AIBRIDGE_PROVIDER_<N>_*) are added next.
|
|
func buildProviders(cfg codersdk.AIBridgeConfig) ([]aibridge.Provider, error) {
|
|
var cbConfig *config.CircuitBreaker
|
|
if cfg.CircuitBreakerEnabled.Value() {
|
|
cbConfig = &config.CircuitBreaker{
|
|
FailureThreshold: uint32(cfg.CircuitBreakerFailureThreshold.Value()), //nolint:gosec // Validated by serpent.Validate in deployment options.
|
|
Interval: cfg.CircuitBreakerInterval.Value(),
|
|
Timeout: cfg.CircuitBreakerTimeout.Value(),
|
|
MaxRequests: uint32(cfg.CircuitBreakerMaxRequests.Value()), //nolint:gosec // Validated by serpent.Validate in deployment options.
|
|
}
|
|
}
|
|
|
|
var providers []aibridge.Provider
|
|
usedNames := make(map[string]struct{})
|
|
|
|
// Collect names from indexed providers so we can detect conflicts
|
|
// with legacy providers.
|
|
for _, p := range cfg.Providers {
|
|
name := p.Name
|
|
if name == "" {
|
|
name = p.Type
|
|
}
|
|
usedNames[name] = struct{}{}
|
|
}
|
|
|
|
// Add legacy OpenAI provider if configured.
|
|
if cfg.LegacyOpenAI.Key.String() != "" {
|
|
if _, conflict := usedNames[aibridge.ProviderOpenAI]; conflict {
|
|
return nil, xerrors.Errorf("legacy CODER_AIBRIDGE_OPENAI_KEY conflicts with indexed provider named %q; remove one or the other", aibridge.ProviderOpenAI)
|
|
}
|
|
providers = append(providers, aibridge.NewOpenAIProvider(aibridge.OpenAIConfig{
|
|
Name: aibridge.ProviderOpenAI,
|
|
BaseURL: cfg.LegacyOpenAI.BaseURL.String(),
|
|
Key: cfg.LegacyOpenAI.Key.String(),
|
|
CircuitBreaker: cbConfig,
|
|
SendActorHeaders: cfg.SendActorHeaders.Value(),
|
|
}))
|
|
usedNames[aibridge.ProviderOpenAI] = struct{}{}
|
|
}
|
|
|
|
// Add legacy Anthropic provider if configured. Bedrock credentials
|
|
// alone are sufficient, an Anthropic API key is not required when
|
|
// using AWS Bedrock.
|
|
if cfg.LegacyAnthropic.Key.String() != "" || getBedrockConfig(cfg.LegacyBedrock) != nil {
|
|
if _, conflict := usedNames[aibridge.ProviderAnthropic]; conflict {
|
|
return nil, xerrors.Errorf("legacy CODER_AIBRIDGE_ANTHROPIC_KEY conflicts with indexed provider named %q; remove one or the other", aibridge.ProviderAnthropic)
|
|
}
|
|
var pool *keypool.Pool
|
|
if key := cfg.LegacyAnthropic.Key.String(); key != "" {
|
|
var err error
|
|
pool, err = keypool.New([]string{key}, quartz.NewReal())
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("create legacy anthropic key pool: %w", err)
|
|
}
|
|
}
|
|
providers = append(providers, aibridge.NewAnthropicProvider(aibridge.AnthropicConfig{
|
|
Name: aibridge.ProviderAnthropic,
|
|
BaseURL: cfg.LegacyAnthropic.BaseURL.String(),
|
|
KeyPool: pool,
|
|
CircuitBreaker: cbConfig,
|
|
SendActorHeaders: cfg.SendActorHeaders.Value(),
|
|
}, getBedrockConfig(cfg.LegacyBedrock)))
|
|
usedNames[aibridge.ProviderAnthropic] = struct{}{}
|
|
}
|
|
|
|
// Add indexed providers.
|
|
for _, p := range cfg.Providers {
|
|
name := p.Name
|
|
if name == "" {
|
|
name = p.Type
|
|
}
|
|
switch p.Type {
|
|
case aibridge.ProviderOpenAI:
|
|
var pool *keypool.Pool
|
|
if len(p.Keys) > 0 {
|
|
var err error
|
|
pool, err = keypool.New(p.Keys, quartz.NewReal())
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("create openai key pool for provider %q: %w", name, err)
|
|
}
|
|
}
|
|
providers = append(providers, aibridge.NewOpenAIProvider(aibridge.OpenAIConfig{
|
|
Name: name,
|
|
BaseURL: p.BaseURL,
|
|
KeyPool: pool,
|
|
APIDumpDir: p.DumpDir,
|
|
CircuitBreaker: cbConfig,
|
|
SendActorHeaders: cfg.SendActorHeaders.Value(),
|
|
}))
|
|
case aibridge.ProviderAnthropic:
|
|
var pool *keypool.Pool
|
|
if len(p.Keys) > 0 {
|
|
var err error
|
|
pool, err = keypool.New(p.Keys, quartz.NewReal())
|
|
if err != nil {
|
|
return nil, xerrors.Errorf("create anthropic key pool for provider %q: %w", name, err)
|
|
}
|
|
}
|
|
providers = append(providers, aibridge.NewAnthropicProvider(aibridge.AnthropicConfig{
|
|
Name: name,
|
|
BaseURL: p.BaseURL,
|
|
KeyPool: pool,
|
|
APIDumpDir: p.DumpDir,
|
|
CircuitBreaker: cbConfig,
|
|
SendActorHeaders: cfg.SendActorHeaders.Value(),
|
|
}, bedrockConfigFromProvider(p)))
|
|
case aibridge.ProviderCopilot:
|
|
providers = append(providers, aibridge.NewCopilotProvider(aibridge.CopilotConfig{
|
|
Name: name,
|
|
BaseURL: p.BaseURL,
|
|
APIDumpDir: p.DumpDir,
|
|
CircuitBreaker: cbConfig,
|
|
}))
|
|
default:
|
|
return nil, xerrors.Errorf("unknown provider type %q for provider %q", p.Type, name)
|
|
}
|
|
}
|
|
|
|
return providers, nil
|
|
}
|
|
|
|
// bedrockConfigFromProvider converts Bedrock fields from an indexed
|
|
// AIBridgeProviderConfig into an aibridge AWSBedrockConfig.
|
|
// Returns nil if no Bedrock fields are set.
|
|
func bedrockConfigFromProvider(p codersdk.AIBridgeProviderConfig) *aibridge.AWSBedrockConfig {
|
|
if p.BedrockRegion == "" && p.BedrockBaseURL == "" && len(p.BedrockAccessKeys) == 0 && len(p.BedrockAccessKeySecrets) == 0 {
|
|
return nil
|
|
}
|
|
// Currently, only the first key pair is used, if any.
|
|
// TODO(ssncferreira): pass a keypool.Pool instead.
|
|
var accessKey, accessKeySecret string
|
|
if len(p.BedrockAccessKeys) > 0 {
|
|
accessKey = p.BedrockAccessKeys[0]
|
|
}
|
|
if len(p.BedrockAccessKeySecrets) > 0 {
|
|
accessKeySecret = p.BedrockAccessKeySecrets[0]
|
|
}
|
|
return &aibridge.AWSBedrockConfig{
|
|
BaseURL: p.BedrockBaseURL,
|
|
Region: p.BedrockRegion,
|
|
AccessKey: accessKey,
|
|
AccessKeySecret: accessKeySecret,
|
|
Model: p.BedrockModel,
|
|
SmallFastModel: p.BedrockSmallFastModel,
|
|
}
|
|
}
|
|
|
|
func getBedrockConfig(cfg codersdk.AIBridgeBedrockConfig) *aibridge.AWSBedrockConfig {
|
|
// Bedrock is considered disabled when no region or base URL is configured.
|
|
// Static credentials are optional. When not provided, the AWS SDK default
|
|
// credential chain resolves credentials (environment variables, shared config,
|
|
// IAM roles, etc.).
|
|
if cfg.Region.String() == "" && cfg.BaseURL.String() == "" {
|
|
return nil
|
|
}
|
|
|
|
return &aibridge.AWSBedrockConfig{
|
|
BaseURL: cfg.BaseURL.String(),
|
|
Region: cfg.Region.String(),
|
|
AccessKey: cfg.AccessKey.String(),
|
|
AccessKeySecret: cfg.AccessKeySecret.String(),
|
|
Model: cfg.Model.String(),
|
|
SmallFastModel: cfg.SmallFastModel.String(),
|
|
}
|
|
}
|