mirror of
https://github.com/coder/coder.git
synced 2026-09-21 20:51:01 +08:00
Michael Suchacz
affeeaf9c8
Extends the Agent-chat MCP tools so an unattended UAT evidence loop can
fetch artifacts, monitor long runs, and find prior runs without burning
model context.
## Backend
- New `chat_files_token` crypto key feature (migration 000571) with
rotator support and a dedicated signing keycache on coderd.
- `POST /api/experimental/chats/files/{file}/download-url`
(authenticated) mints a short-lived (5 min) signed URL and returns it
with `sha256`, `size_bytes`, `name`, `mime_type`, and `expires_at`.
- `GET /api/experimental/chats/files/{file}/download?token=` (no session
token) redeems the signed URL: verifies the JWS, requires the token's
`file_id` to match the path, and re-checks the minting user's RBAC
access live at redemption. Clients can `curl -o` artifacts with zero
credentials in the URL consumer.
- `ChatFileMetadata` gains `size_bytes` (via `octet_length`, no bytes
fetched).
## MCP tools (`codersdk/toolsdk`)
- `coder_download_chat_file`: by `file_id` or `chat_id`+`file_name`;
returns the signed URL plus checksum and size instead of base64.
- `coder_await_chat`: blocks (bounded `wait_secs`, 1-120) until a chat
leaves `running`/`interrupting`, using the existing watch stream with
subscribe-before-read.
- `coder_list_chats`: label, query, and limit filtering; chat
projections now include labels.
- `coder_get_chat_messages`: `after_id` forward cursor with
`next_after_id` (exact incremental reads), plus per-message `files`
metadata so artifact-bearing messages are identifiable.
- `coder_get_chat`: file listings now include `size_bytes` and
`created_at`.
- `coder_list_templates`: exposes `agents_allowed` for pre-flight
checks.
## Testing
- coderd: mint/redeem happy path with an unauthenticated client,
expired/tampered/file-mismatched tokens, auth still required on the
plain file endpoint, non-owner mint rejection.
- toolsdk: harness + integration coverage for all new/changed tools,
including signed-URL redemption with checksum verification,
forward-cursor exactness, await transition/timeout paths, and label
filtering.
- Remote dogfood UAT (dev.coder.com Coder Agent) passed all six
acceptance scenarios end to end over both MCP transports.
Note: `go test ./codersdk/toolsdk/` has a pre-existing goleak flake on
main (leaked `agentssh` non-PTY session goroutines from SSH exec tests;
reproduced 3/3 on clean `b4971bc49f1`). It is unrelated to this diff.
> Mux acted on Mike's behalf to create this PR.
<!-- mux-attribution: model=claude-sonnet-4-6 thinking=high -->
50 lines
1.8 KiB
SQL
50 lines
1.8 KiB
SQL
-- name: InsertChatFile :one
|
|
INSERT INTO chat_files (owner_id, organization_id, name, mimetype, data)
|
|
VALUES (@owner_id::uuid, @organization_id::uuid, @name::text, @mimetype::text, @data::bytea)
|
|
RETURNING id, owner_id, organization_id, created_at, name, mimetype;
|
|
|
|
-- name: GetChatFileByID :one
|
|
SELECT * FROM chat_files WHERE id = @id::uuid;
|
|
|
|
-- name: GetChatFilesByIDs :many
|
|
SELECT * FROM chat_files WHERE id = ANY(@ids::uuid[]);
|
|
|
|
-- name: GetChatFileDataPrefixesByIDs :many
|
|
-- GetChatFileDataPrefixesByIDs returns a bounded prefix of each
|
|
-- file's content, keeping full blobs out of server memory. Owner and
|
|
-- organization columns support row-level authorization.
|
|
SELECT id, owner_id, organization_id, substr(data, 1, @prefix_bytes::int) AS data_prefix
|
|
FROM chat_files
|
|
WHERE id = ANY(@ids::uuid[]);
|
|
|
|
-- name: GetChatFileMetadataByChatID :many
|
|
-- GetChatFileMetadataByChatID returns lightweight file metadata for
|
|
-- all files linked to a chat. The data column is excluded to avoid
|
|
-- loading file content.
|
|
SELECT cf.id, cf.owner_id, cf.organization_id, cf.name, cf.mimetype, cf.created_at,
|
|
octet_length(cf.data)::bigint AS size_bytes
|
|
FROM chat_files cf
|
|
JOIN chat_file_links cfl ON cfl.file_id = cf.id
|
|
WHERE cfl.chat_id = @chat_id::uuid
|
|
ORDER BY cf.created_at ASC;
|
|
|
|
-- name: GetOldUnlinkedChatFileIDs :many
|
|
-- Locks candidate rows against foreign-key inserts for the transaction.
|
|
SELECT cf.id
|
|
FROM chat_files cf
|
|
WHERE cf.created_at < @before_time::timestamptz
|
|
AND NOT EXISTS (
|
|
SELECT 1 FROM chat_file_links cfl WHERE cfl.file_id = cf.id
|
|
)
|
|
ORDER BY cf.created_at ASC
|
|
LIMIT @limit_count
|
|
FOR UPDATE OF cf SKIP LOCKED;
|
|
|
|
-- name: DeleteUnlinkedChatFilesByIDs :execrows
|
|
DELETE FROM chat_files cf
|
|
WHERE cf.id = ANY(@ids::uuid[])
|
|
AND cf.created_at < @before_time::timestamptz
|
|
AND NOT EXISTS (
|
|
SELECT 1 FROM chat_file_links cfl WHERE cfl.file_id = cf.id
|
|
);
|