mirror of
https://github.com/coder/coder.git
synced 2026-09-21 20:51:01 +08:00
Spike Curtis
612e50dab7
fixes https://github.com/coder/internal/issues/1602 The `TestValidate/regular` case was failing because it was chaining to a root CA that expired in 2025. We didn't see it until last week because we fake the validation time for the test, but still get the CA certificate itself from the OS. Presumably our CI runners OS got upgraded last week to a version that doesn't ship that CA cert, so we fail to validate, even with the faked time. I spun up a new Azure instance and grabbed its identity document to update the test, and validated that it chains to a CA that expires in 2038, so we should be good to go for a long time. I also checked the other test cases, and they had already migrated to the new CA, so don't need to be updated yet. However, if we want to remove any expired intermediate certificates that are used in the test, we'll have to get new tokens for govcloud at the very least. I also removed the "TestExpiresSoon" test case because we have been skipping it and _not_ removing expiring intermediates (presumably because of the `TestValidate` test cases. Also it makes no sense to remove intermediates when they are expiring "soon" but have not expired. It poses negligible danger to keep the old intermediates around, since we trust the OS to give us the correct time in production.