coder

mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00

Files

T

Kyle Carberry 219d02bdc3 fix(coderd): poll for metrics in TestWorkspaceProvisionerdServerMetrics (#22644 )

## Problem

`TestWorkspaceProvisionerdServerMetrics` flakes because metric
assertions run immediately after
`AwaitWorkspaceBuildJobCompleted` returns, but metrics are updated
**asynchronously after the
DB transaction commits** in `completeWorkspaceBuildJob`.

The timeline in the provisioner server:
1. DB transaction commits (`provisionerdserver.go:~2362`) — job marked
completed
2. Audit logging, notifications, DB queries (`~2370-2427`)
3. **Metric `.Observe()`** (`~2463`) — happens ~100 lines later

The test synchronization (`AwaitWorkspaceBuildJobCompleted`) polls for
`CompletedAt != nil`,
which fires at step 1. The metric assertion then executes before step 3,
causing the flake.

## Fix

Wrap all three metric assertions (prebuild creation, prebuild claim,
regular workspace
creation) in `require.Eventually` to poll until the metric appears, then
assert on the value.

## Test

- `go test -run TestWorkspaceProvisionerdServerMetrics -count=5` — all
pass
- `go test -race -run TestWorkspaceProvisionerdServerMetrics -count=1` —
clean

2026-03-04 22:30:36 -05:00

aibridged

feat: store tool call IDs to determine interception lineage (#22246 )

2026-03-03 21:04:41 +02:00

aibridgedserver

feat: store tool call IDs to determine interception lineage (#22246 )

2026-03-03 21:04:41 +02:00

aibridgeproxyd

chore: remove aibridgeproxyd README (#22027 )

2026-02-10 10:45:26 +00:00

audit

fix: exclude provisioner_state from workspace_build_with_user view (#22159 )