mirror of
https://github.com/coder/coder.git
synced 2026-09-21 20:51:01 +08:00
Exposes the experimental Coder Agents chats API through the MCP tool registry, so MCP clients (the hosted `/api/experimental/mcp/http` server and `coder exp mcp server`) can start and drive server-side coding agents. New tools in `codersdk/toolsdk`, all thin wrappers over existing `codersdk.ExperimentalClient` methods: | Tool | Wraps | |---|---| | `coder_create_chat` | `CreateChat` (prompt, optional org, model config, labels) | | `coder_get_chat` | `GetChat` (status, last error, last turn summary, workspace, files) | | `coder_get_chat_messages` | `GetChatMessages` (user-facing parts, chronological, cursor pagination, queued prompts) | | `coder_send_chat_message` | `CreateChatMessage` (queue or interrupt busy behavior) | | `coder_interrupt_chat` | `InterruptChat` | | `coder_archive_chat` | `UpdateChat` with `archived: true` | | `coder_list_chat_model_configs` | `ListChatModelConfigs` (enabled configs with default flag) | Both MCP servers register tools from `toolsdk.All`, so no additional wiring is needed. Responses are trimmed to what an MCP caller needs (IDs as strings, user-facing transcripts) rather than full SDK payloads. No new endpoints and no database changes. Also adds MCP [prompts](https://modelcontextprotocol.io/specification/2026-07-28/server/prompts) for the chat workflows, defined once in `codersdk/toolsdk` and registered by both servers: | Prompt | Purpose | |---|---| | `coder_agents_delegate` | delegate a task to a Coder Agents chat and monitor it to completion | | `coder_agents_check` | check the status and recent activity of an existing chat | Each prompt declares the tools its workflow needs; the stdio server skips prompts whose tools are excluded by `--allowed-tools`. Tests run the tools against a chat-enabled coderdtest instance (fake OpenAI-compatible provider plus in-process AI bridge), covering the full lifecycle, an interrupt against a blocked turn, pagination cursors, permission-dependent model config filtering, and argument validation. Prompt coverage spans SDK rendering, the hosted `prompts/list`/`prompts/get` round trip, and the stdio server including allowlist gating. > Mux created this PR on Mike's behalf.
99 lines
3.5 KiB
Go
99 lines
3.5 KiB
Go
package coderd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/google/uuid"
|
|
"golang.org/x/xerrors"
|
|
|
|
"cdr.dev/slog/v3"
|
|
"github.com/coder/coder/v2/coderd/database/dbauthz"
|
|
"github.com/coder/coder/v2/coderd/httpapi"
|
|
"github.com/coder/coder/v2/coderd/httpmw"
|
|
"github.com/coder/coder/v2/coderd/mcp"
|
|
"github.com/coder/coder/v2/coderd/rbac/policy"
|
|
"github.com/coder/coder/v2/codersdk"
|
|
"github.com/coder/coder/v2/codersdk/toolsdk"
|
|
"github.com/coder/coder/v2/codersdk/workspacesdk"
|
|
)
|
|
|
|
type MCPToolset string
|
|
|
|
const (
|
|
MCPToolsetStandard MCPToolset = "standard"
|
|
MCPToolsetChatGPT MCPToolset = "chatgpt"
|
|
)
|
|
|
|
// mcpHTTPHandler creates the MCP HTTP transport handler
|
|
// It supports a "toolset" query parameter to select the set of tools to register.
|
|
func (api *API) mcpHTTPHandler() http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
// Create MCP server instance for each request
|
|
mcpServer, err := mcp.NewServer(api.Logger.Named("mcp"))
|
|
if err != nil {
|
|
api.Logger.Error(r.Context(), "failed to create MCP server", slog.Error(err))
|
|
httpapi.Write(r.Context(), w, http.StatusInternalServerError, codersdk.Response{
|
|
Message: "MCP server initialization failed",
|
|
})
|
|
return
|
|
}
|
|
// Extract the original session token from the request
|
|
authenticatedClient := codersdk.New(api.AccessURL,
|
|
codersdk.WithSessionToken(httpmw.APITokenFromRequest(r)))
|
|
|
|
// Wrap the agent connection function to enforce ActionSSH
|
|
// on the workspace. Without this check, a user who can read
|
|
// a workspace but lacks SSH permission could still execute
|
|
// commands through MCP tools.
|
|
toolOpt := toolsdk.WithAgentConnFunc(func(ctx context.Context, agentID uuid.UUID) (workspacesdk.AgentConn, func(), error) {
|
|
if api.Entitlements.Enabled(codersdk.FeatureBrowserOnly) {
|
|
return nil, nil, xerrors.New("non-browser connections are disabled")
|
|
}
|
|
// Use system context for the lookup because the tool
|
|
// handler context does not carry a dbauthz actor. The
|
|
// real authorization happens in the Authorize call below.
|
|
//nolint:gocritic // The system query only fetches the workspace
|
|
// object so we can perform an ActionSSH check against it
|
|
// with the real user's roles via api.Authorize.
|
|
workspace, err := api.Database.GetWorkspaceByAgentID(dbauthz.AsSystemRestricted(ctx), agentID)
|
|
if err != nil {
|
|
return nil, nil, xerrors.Errorf("get workspace by agent ID: %w", err)
|
|
}
|
|
// Enforce the same ActionSSH check that the coordinate
|
|
// endpoint uses (workspaceagents.go:1317).
|
|
if !api.Authorize(r, policy.ActionSSH, workspace) {
|
|
return nil, nil, xerrors.New("unauthorized: you do not have SSH access to this workspace")
|
|
}
|
|
return api.agentProvider.AgentConn(ctx, agentID)
|
|
})
|
|
|
|
toolset := MCPToolset(r.URL.Query().Get("toolset"))
|
|
// Default to standard toolset if no toolset is specified.
|
|
if toolset == "" {
|
|
toolset = MCPToolsetStandard
|
|
}
|
|
|
|
switch toolset {
|
|
case MCPToolsetStandard:
|
|
if err := mcpServer.RegisterTools(authenticatedClient, toolOpt); err != nil {
|
|
api.Logger.Warn(r.Context(), "failed to register MCP tools", slog.Error(err))
|
|
}
|
|
mcpServer.RegisterPrompts()
|
|
case MCPToolsetChatGPT:
|
|
if err := mcpServer.RegisterChatGPTTools(authenticatedClient, toolOpt); err != nil {
|
|
api.Logger.Warn(r.Context(), "failed to register MCP tools", slog.Error(err))
|
|
}
|
|
default:
|
|
httpapi.Write(r.Context(), w, http.StatusBadRequest, codersdk.Response{
|
|
Message: fmt.Sprintf("Invalid toolset: %s", toolset),
|
|
})
|
|
return
|
|
}
|
|
|
|
// Handle the MCP request
|
|
mcpServer.ServeHTTP(w, r)
|
|
})
|
|
}
|