mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
Spike Curtis
e2076beb9f
relates to: https://github.com/coder/internal/issues/1026 On POSIX systems (macOS and Linux) we compile the dbcleaner binary into a temp directory. This allows us to explicitly separate the compilation step and report the time it takes. We suspect this might be a contributing factor in the above linked flakes we see on macOS. This doesn't work on Windows because Go tests clean up the temp directory at the end of the test and the dbcleaner binary will still be executing. On Windows you cannot delete a file being executed nor the directory. However, we are not seeing any flakes on Windows so the old behavior seems to be OK.
12 lines
422 B
Go
12 lines
422 B
Go
//go:build windows
|
|
|
|
package dbtestutil
|
|
|
|
import "os/exec"
|
|
|
|
// cleanerCmd returns a command to execute the cleaner binary. We do this with go run on Windows because we can't
|
|
// delete the temporary directory after the test: the binary will still be running. c.f. cleaner_posix.go.
|
|
func cleanerCmd(_ TBSubset) *exec.Cmd {
|
|
return exec.Command("go", "run", "github.com/coder/coder/v2/coderd/database/dbtestutil/cleanercmd")
|
|
}
|