mirror of
https://github.com/coder/coder.git
synced 2026-10-24 23:14:28 +08:00
* Add ssh tests for longoutput, orphan Signed-off-by: Spike Curtis <spike@coder.com> * PTY/SSH tests & improvements Signed-off-by: Spike Curtis <spike@coder.com> * Fix some tests Signed-off-by: Spike Curtis <spike@coder.com> * Fix linting Signed-off-by: Spike Curtis <spike@coder.com> * fmt Signed-off-by: Spike Curtis <spike@coder.com> * Fix windows test Signed-off-by: Spike Curtis <spike@coder.com> * Windows copy test Signed-off-by: Spike Curtis <spike@coder.com> * WIP Windows pty handling Signed-off-by: Spike Curtis <spike@coder.com> * Fix truncation tests Signed-off-by: Spike Curtis <spike@coder.com> * Appease linter/fmt Signed-off-by: Spike Curtis <spike@coder.com> * Fix typo Signed-off-by: Spike Curtis <spike@coder.com> * Rework truncation test to not assume OS buffers Signed-off-by: Spike Curtis <spike@coder.com> * Disable orphan test on Windows --- uses sh Signed-off-by: Spike Curtis <spike@coder.com> * agent_test running SSH in pty use ptytest.Start Signed-off-by: Spike Curtis <spike@coder.com> * More detail about closing pseudoconsole on windows Signed-off-by: Spike Curtis <spike@coder.com> * Code review fixes Signed-off-by: Spike Curtis <spike@coder.com> * Rearrange ptytest method order Signed-off-by: Spike Curtis <spike@coder.com> * Protect pty.Resize on windows from races Signed-off-by: Spike Curtis <spike@coder.com> * Fix windows bugs Signed-off-by: Spike Curtis <spike@coder.com> * PTY doesn't extend PTYCmd Signed-off-by: Spike Curtis <spike@coder.com> * Fix windows types Signed-off-by: Spike Curtis <spike@coder.com> --------- Signed-off-by: Spike Curtis <spike@coder.com>
72 lines
1.9 KiB
Go
72 lines
1.9 KiB
Go
//go:build !windows
|
|
|
|
package pty
|
|
|
|
import (
|
|
"fmt"
|
|
"os/exec"
|
|
"runtime"
|
|
"strings"
|
|
"syscall"
|
|
|
|
"golang.org/x/xerrors"
|
|
)
|
|
|
|
func startPty(cmd *exec.Cmd, opt ...StartOption) (retPTY *otherPty, proc Process, err error) {
|
|
var opts startOptions
|
|
for _, o := range opt {
|
|
o(&opts)
|
|
}
|
|
|
|
opty, err := newPty(opts.ptyOpts...)
|
|
if err != nil {
|
|
return nil, nil, xerrors.Errorf("newPty failed: %w", err)
|
|
}
|
|
|
|
origEnv := cmd.Env
|
|
if opty.opts.sshReq != nil {
|
|
cmd.Env = append(cmd.Env, fmt.Sprintf("SSH_TTY=%s", opty.Name()))
|
|
}
|
|
if opty.opts.setGPGTTY {
|
|
cmd.Env = append(cmd.Env, fmt.Sprintf("GPG_TTY=%s", opty.Name()))
|
|
}
|
|
|
|
cmd.SysProcAttr = &syscall.SysProcAttr{
|
|
Setsid: true,
|
|
Setctty: true,
|
|
}
|
|
cmd.Stdout = opty.tty
|
|
cmd.Stderr = opty.tty
|
|
cmd.Stdin = opty.tty
|
|
err = cmd.Start()
|
|
if err != nil {
|
|
_ = opty.Close()
|
|
if runtime.GOOS == "darwin" && strings.Contains(err.Error(), "bad file descriptor") {
|
|
// macOS has an obscure issue where the PTY occasionally closes
|
|
// before it's used. It's unknown why this is, but creating a new
|
|
// TTY resolves it.
|
|
cmd.Env = origEnv
|
|
return startPty(cmd, opt...)
|
|
}
|
|
return nil, nil, xerrors.Errorf("start: %w", err)
|
|
}
|
|
// Now that we've started the command, and passed the TTY to it, close our
|
|
// file so that the other process has the only open file to the TTY. Once
|
|
// the process closes the TTY (usually on exit), there will be no open
|
|
// references and the OS kernel returns an error when trying to read or
|
|
// write to our PTY end. Without this, reading from the process output
|
|
// will block until we close our TTY.
|
|
if err := opty.tty.Close(); err != nil {
|
|
_ = cmd.Process.Kill()
|
|
return nil, nil, xerrors.Errorf("close tty: %w", err)
|
|
}
|
|
opty.tty = nil // remove so we don't attempt to close it again.
|
|
oProcess := &otherProcess{
|
|
pty: opty.pty,
|
|
cmd: cmd,
|
|
cmdDone: make(chan any),
|
|
}
|
|
go oProcess.waitInternal()
|
|
return opty, oProcess, nil
|
|
}
|