Cian Johnston
6079c514ee
fix: follow-up fixes for conditional VCS requests ( #27711 )
...
Follow-ups from #27627
- Memoizes `Config.Git()` with a mutex so the provider's ETag response
cache survives across calls. Only successful construction is cached;
errors are retried.
- Moves the HTTP client onto `Config.HTTPClient`, wired through
`ConvertConfig`, so `Git()` no longer takes a per-call argument that
would be silently ignored after memoization.
- `newGitHub` and `newGitLab` now return `(Provider, error)`,
eliminating the typed-nil-interface class in `gitprovider.New` rather
than the single instance.
- Gates the 304 branch on a `haveCached` flag instead of a nil body
check.
- Only caches bodies that decode successfully, preventing poisoned
entries.
- Keys the response cache on the full token digest rather than a
truncated prefix.
- Tests added: `TestConfigGitMemoizesProvider`,
`TestConfigGitRetriesOnConstructorError`,
`TestGitLabConstructorErrorReturnsNilInterface`,
`TestResponseCacheStore`,
`TestConditionalRequestReuse/MalformedResponseNotCached`;
`TestConvertYAML/CustomScopesAndEndpoint` now asserts
`Config.HTTPClient` wiring.
Follow-ups tracked in #28139 , #28140 , #28141 , #28142 .
> 🤖 Generated by Coder Agents on behalf of @johnstcn.
2026-08-18 09:00:20 +01:00
..
2026-07-28 09:58:33 -06:00
2026-08-13 15:00:36 +01:00
2026-08-13 10:38:14 +00:00
2026-08-17 14:08:28 +01:00
2026-08-04 16:57:16 +02:00
2026-06-16 09:01:43 +00:00
2026-08-18 12:40:33 +07:00
2026-03-02 16:02:01 +01:00
2026-07-28 16:59:33 -07:00
2026-06-23 11:37:33 -05:00
2026-07-01 21:24:42 -05:00
2026-06-26 07:24:21 -04:00
2026-06-25 15:41:09 -06:00
2026-03-13 00:22:55 +11:00
2026-08-16 18:18:02 +05:00
2026-04-03 15:47:26 -05:00
2026-07-13 11:00:02 -07:00
2026-08-18 12:40:33 +07:00
2026-05-21 09:19:29 -06:00
2026-08-18 09:00:20 +01:00
2026-04-28 13:06:45 -07:00
2026-07-23 14:55:34 -07:00
2026-08-13 17:47:12 -07:00
2026-06-24 14:27:23 -05:00
2026-03-19 21:51:26 +00:00
2026-08-13 18:32:47 +02:00
2026-08-11 13:16:25 +00:00
2026-08-13 17:47:12 -07:00
2026-07-30 08:37:45 +01:00
2026-04-02 23:51:02 +02:00
2026-06-17 13:10:53 +02:00
2026-08-10 14:43:16 -05:00
2026-08-11 11:04:51 -05:00
2026-08-11 11:04:51 -05:00
2026-08-06 09:18:46 -04:00
2026-08-10 12:58:01 +02:00
2026-06-23 17:32:47 -05:00
2026-08-16 18:18:02 +05:00
2026-05-07 17:10:50 +01:00
2026-08-06 14:14:37 +10:00
2026-07-15 14:05:18 -04:00
2026-05-21 09:19:29 -06:00
2026-07-09 14:02:18 +00:00
2026-07-30 08:37:45 +01:00
2026-06-10 02:18:44 -05:00
2026-08-10 14:43:16 -05:00
2026-06-17 00:22:41 +10:00
2026-07-28 15:30:12 -05:00
2026-08-03 15:56:56 -05:00
2026-06-25 15:41:09 -06:00
2026-05-21 09:19:29 -06:00
2026-07-07 09:18:30 -07:00
2026-07-07 09:18:30 -07:00
2026-08-13 21:30:57 +02:00
2026-03-12 18:07:52 +02:00
2026-07-01 15:59:55 +03:00
2026-07-06 23:00:09 +01:00
2026-07-01 20:44:15 +00:00
2026-07-06 23:00:09 +01:00
2026-07-06 23:00:09 +01:00
2026-05-27 11:58:43 +02:00
2026-08-04 15:21:23 -04:00
2026-07-06 23:00:09 +01:00
2026-05-25 18:04:12 +02:00
2026-07-28 09:22:58 +01:00
2026-08-13 11:27:05 -05:00
2026-07-14 13:39:58 -04:00
2026-04-01 09:54:59 -04:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-05-28 18:37:57 +01:00
2026-06-16 09:01:43 +00:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-08-06 09:18:46 -04:00
2026-07-07 10:42:01 +00:00
2026-05-12 22:13:55 +10:00
2026-07-01 20:15:03 +01:00
2026-07-15 17:07:57 -07:00
2026-08-13 17:47:12 -07:00
2026-07-14 12:29:38 -07:00
2026-07-14 12:29:38 -07:00
2026-03-13 14:09:39 +00:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-08-04 12:27:38 +02:00
2026-07-06 13:15:58 +01:00
2026-06-12 13:03:45 +00:00
2026-08-03 18:27:39 +02:00
2026-08-16 20:30:32 +02:00
2026-08-13 21:07:26 +02:00
2026-08-18 09:00:20 +01:00
2026-05-05 02:54:03 +05:00
2026-06-22 19:26:34 -06:00
2026-07-15 12:16:25 -08:00
2026-07-23 11:56:07 -06:00
2026-06-02 10:11:49 -07:00
2026-06-02 10:11:49 -07:00
2026-06-02 08:36:01 -06:00
2026-07-06 13:15:58 +01:00
2026-07-06 13:15:58 +01:00
2026-03-23 19:54:43 +00:00
2026-05-05 02:54:03 +05:00
2026-03-04 18:01:56 -08:00
2026-05-05 02:54:03 +05:00
2026-08-13 18:32:47 +02:00
2026-05-03 11:31:48 -04:00
2026-08-11 12:02:34 +02:00
2026-08-11 12:02:34 +02:00
2026-08-11 12:02:34 +02:00
2026-08-13 10:47:14 +00:00
2026-04-07 12:25:32 -06:00
2026-08-16 18:18:02 +05:00
2026-05-05 02:54:03 +05:00
2026-07-28 16:59:33 -07:00
2026-07-28 16:59:33 -07:00
2026-07-28 16:59:33 -07:00
2026-08-12 13:36:52 -07:00
2026-08-13 09:58:51 -07:00
2026-07-28 16:59:33 -07:00
2026-05-05 02:54:03 +05:00
2026-05-21 09:19:29 -06:00
2026-06-03 10:46:07 +01:00
2026-05-05 02:54:03 +05:00
2026-07-14 13:39:58 -04:00
2026-06-03 10:46:07 +01:00
2026-04-10 09:50:11 -05:00
2026-07-14 13:39:58 -04:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-05-11 08:41:17 -06:00
2026-06-23 23:06:44 +10:00
2026-06-15 11:07:16 -04:00
2026-07-27 16:10:40 -04:00
2026-08-06 14:04:23 +10:00
2026-08-06 14:14:37 +10:00
2026-08-06 14:14:37 +10:00
2026-08-06 14:14:37 +10:00
2026-08-06 14:14:37 +10:00
2026-07-23 16:39:53 -06:00
2026-07-23 16:39:53 -06:00
2026-05-05 02:54:03 +05:00
2026-06-04 14:37:19 -04:00
2026-07-28 21:05:50 +10:00
2026-07-23 11:56:07 -06:00
2026-08-11 13:16:25 +00:00
2026-08-16 18:18:02 +05:00
2026-07-28 09:58:33 -06:00
2026-07-28 09:58:33 -06:00
2026-07-28 09:58:33 -06:00
2026-07-28 09:58:33 -06:00
2026-05-20 19:50:50 +02:00
2026-05-20 00:09:09 +02:00
2026-04-15 11:31:43 +02:00
2026-04-26 14:49:10 -07:00
2026-05-05 02:54:03 +05:00
2026-05-05 02:54:03 +05:00
2026-07-01 15:59:55 +03:00
2026-07-14 13:50:25 +01:00
2026-08-05 13:08:41 -07:00
2026-08-05 13:08:41 -07:00
2026-05-11 14:27:40 -05:00
2026-03-12 18:07:52 +02:00
2026-07-01 20:15:03 +01:00
2026-07-28 13:20:59 -07:00
2026-05-05 02:54:03 +05:00
2026-07-07 09:18:30 -07:00
2026-06-25 15:47:35 -07:00
2026-08-05 22:17:59 +00:00
2026-05-05 02:54:03 +05:00
2026-05-18 08:33:29 -04:00
2026-05-13 14:14:07 +00:00
2026-05-11 11:03:38 +02:00
2026-08-10 14:53:48 -05:00
2026-08-10 14:53:48 -05:00