coder

mirror of https://github.com/coder/coder.git synced 2026-09-22 05:05:20 +08:00

Files

T

Ethan 51a627c107 ci: remove unnecessary brew install google-chrome from macOS CI (#22835 )

Closes https://github.com/coder/internal/issues/1391

## Problem

The `test-go-pg (macos-latest)` job hit its 25m timeout without ever
running
tests because `brew install google-chrome` stalled for 23+ minutes
downloading
from the Homebrew CDN:

```
==> Fetching downloads for: google-chrome
Error: The operation was canceled.
```

## Why this is safe to remove

`brew install google-chrome` was added in Oct 2023 (`70a4e56c0`) the day
after
chromedp was integrated into the scaletest/dashboard package
(`1c48610d5`). At
that time, `run.go` called `initChromeDPCtx` directly (hardcoded), so
the unit
test actually launched a real Chrome process.

In Jun 2024, #13650 refactored this to accept a mock `InitChromeDPCtx`
via the
`Config` struct, and the test now passes a stub that never launches a
browser.
No test file in the repo references `chromedp` directly — the only test
(`scaletest/dashboard/run_test.go`) fully mocks Chrome initialization.

The `chromedp` Go library compiles fine without Chrome installed; it
only needs
the binary at runtime, and no test exercises that path.

## Impact

- Removes a ~200MB+ download from every macOS CI run
- Eliminates a fragile external dependency on Homebrew CDN availability
- Saves several minutes per run even when the download succeeds

_Generated with mux but reviewed by a human_

2026-03-10 00:07:35 +11:00

actions

fix(Makefile): align test-race with CI configuration (#22727 )

2026-03-09 10:39:13 +00:00

fly-wsproxies

chore: remove brazil fly.io proxy (#20601 )

2025-10-31 02:40:56 +00:00

ISSUE_TEMPLATE

chore: remove needs-triage label from bug template (#22679 )

2026-03-06 10:55:20 +00:00

pr-deployments

chore: update deprecated usage of coder_workspace.owner* fields (#13390 )