mirror of
https://github.com/coder/coder.git
synced 2026-09-22 05:05:20 +08:00
Andrew Aquino
4f98fa1e03
Followup to #26907, which re-enabled sticky positioning within `#main-content` throughout the site. From https://github.com/coder/coder/pull/26907#issuecomment-4860536495: >Updating [`HorizontalSection` in OrganizationSettingsPageView.tsx]'s sticky styles will be a little more involved, so I'll save that for a separate PR. ## before Note that I inflated this section's height to 1000px in DevTools to be able to demo sticky positioning not working. This page isn't tall enough at the moment for the lack of sticky positioning to be much of a problem. But this will future-proof it (since `FormSection`, whose sticky styles were fixed in #26907, was built for this purpose) and allow us to remove some redundant components/files. No other files imported `HorizontalContainer` or `HorizontalSection`, so OrganizationSettingsPage/Horizontal.tsx can be safely deleted. Also note that the **Info** section is sticky as expected, since it was already using `FormSection`. The **Workspace Sharing** and **Delete Organization** sections are the ones whose stickiness is fixed by this PR https://github.com/user-attachments/assets/9ffed486-87f7-4762-a97a-4268d0328829 ## after https://github.com/user-attachments/assets/581cb33e-50b5-466e-9be9-2518dc22bfa6