McKayla はな 2f879910af fix(coderd): harden oauth2 redirect validation (#27274) ...

Closes DEVEX-604

Hardens `redirect` URL handling in the OAuth2/OIDC/external-auth
callback flows so redirects are always reduced to a safe, relative path
local to the application. Previously a redirect value with an opaque
scheme (e.g. `javascript:...`) or a path with multiple leading slashes
(e.g. `///evil.com`) could survive sanitization mostly intact.

Also de-duplicates the previously copy-pasted `uriFromURL` helper (now
exported `httpmw.URIFromURL`) so there's a single implementation shared
by `coderd/userauth.go`, `coderd/externalauth.go`, and
`coderd/httpmw/oauth2.go`.

<details>
<summary>Context</summary>

Addresses a low-severity finding reported via a pentest disclosure: the
redirect sanitizer used `url.Parse(...).RequestURI()`, which doesn't
reject non-hierarchical (opaque) URLs and doesn't collapse extra leading
slashes, so crafted `redirect` values could partially survive
sanitization.

</details>

This PR was authored by a Coder Agent on behalf of @aslilac.

2026-07-23 11:56:07 -06:00

..

agentapi

fix: create agent firewall sessions without requiring agent read access (#26990)

2026-07-07 10:42:01 +00:00

agentmetrics

…

aibridge

feat: fall back to the Everyone group for AI spend attribution (#27364)

2026-07-23 09:26:25 +01:00

aibridged

feat: add AWS Bedrock mantle endpoint to AI Gateway (#26745)

2026-07-13 19:44:36 -04:00

aibridgedserver

feat: fall back to the Everyone group for AI spend attribution (#27364)

2026-07-23 09:26:25 +01:00

aibridgedtest

feat: synchronise provider changes with WatchAIProviders (#27091)

2026-07-08 15:32:17 +02:00

aiseats

refactor: rename Ai* database identifiers to AI* (AIGOV-369) (#26327)

2026-06-16 09:01:43 +00:00

apidoc

feat: add persisted whole-chat summary with background generation (#26657)

2026-07-23 16:36:23 +01:00

apikey

…

appearance

…

audit

refactor: rename Ai* database identifiers to AI* (AIGOV-369) (#26327)

2026-06-16 09:01:43 +00:00

authlink

chore: add --force-reset-all flag to oidc link repair cli (#26534)

2026-06-23 11:37:33 -05:00

autobuild

fix: reword autostop reminder to use relative countdown (#26948)

2026-07-01 21:24:42 -05:00

awsidentity

…

azureidentity

test: fix azureidentity Verify test by replacing with recent token (#26720)

2026-06-26 07:24:21 -04:00

boundaryusage

refactor: use sync.WaitGroup.Go in tests (#26671)

2026-06-25 15:41:09 -06:00

cachecompress

fix(site): avoid duplicating bin download headers (#22981)

2026-03-13 00:22:55 +11:00

coderdtest

test: use NATS in coderdtest by default (#27343)

2026-07-21 11:19:23 +02:00

connectionlog

feat: batch connection logs to avoid DB lock contention (#23727)

2026-04-03 15:47:26 -05:00

cryptokeys

feat: NATS mTLS pubsub implementation (#26902)

2026-07-13 11:00:02 -07:00

database

feat: add persisted whole-chat summary with background generation (#26657)

2026-07-23 16:36:23 +01:00

devtunnel

…

dynamicparameters

chore: remove coder_secret Terraform integration (#25512)

2026-05-21 09:19:29 -06:00

entitlements

…

externalauth

fix: prevent concurrent token refreshes (#26530)

2026-07-15 12:16:25 -08:00

files

…

gitsshkey

…

healthcheck

fix(coderd/healthcheck/derphealth): avoid data races in DERP report (#24795)

2026-04-28 13:06:45 -07:00

httpapi

fix(coderd): harden oauth2 redirect validation (#27274)

2026-07-23 11:56:07 -06:00

httpmw

fix(coderd): harden oauth2 redirect validation (#27274)

2026-07-23 11:56:07 -06:00

idpsync

feat: escape composite-literal fields in NameOrganizationPair (#26675)

2026-06-24 14:27:23 -05:00

jobreaper

refactor: extract test helpers in coderd/jobreaper to reduce duplication (#23001)

2026-03-19 21:51:26 +00:00

jwtutils

…

mcp

fix: isolate MCP HTTP transports from DefaultTransport in tests (#25821)

2026-06-01 16:17:29 +03:00

metricscache

…

notifications

feat: notify users when chats are shared (#26914)

2026-07-06 13:15:58 +01:00

oauth2provider

chore: standardize on *_internal_test.go for white-box tests (#25601)

2026-05-22 20:24:38 +10:00

oauthpki

…

portsharing

…

pproflabel

feat: add workspace restart functionality to API (#25757)

2026-07-07 09:18:30 -07:00

prebuilds

fix: make prebuild claiming durable and idempotent (#23108)

2026-04-02 23:51:02 +02:00

prometheusmetrics

chore: export AI Gateway metrics under new branding + keep old as alias (#26413)

2026-06-17 13:10:53 +02:00

promoauth

fix: prevent concurrent token refreshes (#26530)

2026-07-15 12:16:25 -08:00

provisionerdserver

chore: wire quartz.Clock into Acquirer (#27291)

2026-07-20 10:30:02 +01:00

provisionerkey

…

proxyhealth

…

pubsub

fix(coderd): invalidate chatd provider cache on AI provider changes (#26987)

2026-07-07 00:20:54 +10:00

rbac

feat: add synthetic gateway keys (#27170)

2026-07-18 20:45:13 +02:00

render

feat: surface template README to agent template tools (#26334)

2026-06-24 12:32:46 +01:00

runtimeconfig

…

schedule

feat: plumb time_til_autostop_notify template field (#26439)

2026-06-23 17:32:47 -05:00

searchquery

feat: Add full text search over chat messages (#27126)

2026-07-16 15:21:57 +01:00

taskname

fix(coderd/taskname): parse task name JSON with trailing text (#25005)

2026-05-07 17:10:50 +01:00

telemetry

chore: report Coder Agents experiments in telemetry (#27042)

2026-07-14 14:18:39 +10:00

templatebuilder

fix(coderd/templatebuilder): prompt for DigitalOcean base variables (#27268)

2026-07-15 14:05:18 -04:00

testdata

chore: remove coder_secret Terraform integration (#25512)

2026-05-21 09:19:29 -06:00

tracing

feat: setup logging, tracing and metrics in standalone AI Gateway (#27068)

2026-07-09 14:02:18 +00:00

updatecheck

…

usage

chore: add tallyman events for ai seat tracking (#22689)

2026-03-18 09:30:22 -05:00

userpassword

fix: use a random value for a simulated hash for built-in users (#26205)

2026-06-10 02:18:44 -05:00

util

fix: normalize command paths to base names in shellparse (#25599)

2026-05-22 13:36:53 +03:00

webpush

test: use httptest server.Client() to isolate transport (#26409)

2026-06-17 00:22:41 +10:00

workspaceapps

fix: prevent open redirect in proxy authentication flow (#26647)

2026-06-25 11:17:23 -05:00

workspaceconnwatcher

test: include per-org default roles in rbac user subjects (#26003)

2026-06-05 15:01:45 -05:00

workspacestats

refactor: use sync.WaitGroup.Go in tests (#26671)

2026-06-25 15:41:09 -06:00

wsbuilder

chore: remove coder_secret Terraform integration (#25512)

2026-05-21 09:19:29 -06:00

wsbuildorchestrator

feat: add workspace restart functionality to API (#25757)

2026-07-07 09:18:30 -07:00

wspubsub

feat: add workspace restart functionality to API (#25757)

2026-07-07 09:18:30 -07:00

x

feat: add persisted whole-chat summary with background generation (#26657)

2026-07-23 16:36:23 +01:00

activitybump_test.go

test: add testutil.WaitBuffer and replace time.Sleep in tests (#22922)

2026-03-12 18:07:52 +02:00

ai_providers_backfill_test.go

refactor: drop chat_model_configs provider column (#26877)

2026-07-01 15:59:55 +03:00

ai_providers_backfill.go

feat: add custom AI provider icons and instance-based model picker grouping (#27026)

2026-07-06 23:00:09 +01:00

ai_providers_internal_test.go

feat: generate STS external ID for Bedrock role assumption (#26869)

2026-07-01 20:44:15 +00:00

ai_providers_migrate_test.go

feat: add custom AI provider icons and instance-based model picker grouping (#27026)

2026-07-06 23:00:09 +01:00

ai_providers_migrate.go

feat: add custom AI provider icons and instance-based model picker grouping (#27026)

2026-07-06 23:00:09 +01:00

ai_providers_pubsub_test.go

feat: hot-reload aibridged and aibridgeproxyd providers on DB changes (#25673)

2026-05-27 11:58:43 +02:00

ai_providers_test.go

feat: add custom AI provider icons and instance-based model picker grouping (#27026)

2026-07-06 23:00:09 +01:00

ai_providers.go

feat: add custom AI provider icons and instance-based model picker grouping (#27026)

2026-07-06 23:00:09 +01:00

aibridge_test.go

refactor: route TransportFor by provider name (#25650)

2026-05-25 18:04:12 +02:00

aibridged.go

refactor: use Options struct in aibridgedserver.NewServer (#27200)

2026-07-16 16:09:25 +01:00

aitasks_internal_test.go

…

aitasks_test.go

fix: prevent concurrent token refreshes (#26530)

2026-07-15 12:16:25 -08:00

aitasks.go

docs: wrap placeholder syntax in backticks in CLI help and swagger annotations (#27194)

2026-07-14 13:39:58 -04:00

apikey_scopes_validation_test.go

…

apikey_test.go

fix: persist session cookie to disk to prevent PWA logout (#23746)

2026-04-01 09:54:59 -04:00

apikey.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

apiroot.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

audit_internal_test.go

fix: improve chat audit log descriptions and diff rendering (#25728)

2026-05-28 18:37:57 +01:00

audit_test.go

…

audit.go

refactor: rename Ai* database identifiers to AI* (AIGOV-369) (#26327)

2026-06-16 09:01:43 +00:00

authorize_test.go

…

authorize.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

boundary_logs_test.go

fix: create agent firewall sessions without requiring agent read access (#26990)

2026-07-07 10:42:01 +00:00

chat_testhooks.go

test(coderd): centralize chat test harness and stabilize flakes (#25171)

2026-05-12 22:13:55 +10:00

client_test.go

…

coderd_internal_test.go

refactor: deprecate AIGatewayRoutingEnabled, remove direct chat routing (#26862)

2026-07-01 20:15:03 +01:00

coderd_test.go

fix: normalize path before rate-limit bucket keying (#27273)

2026-07-15 17:07:57 -07:00

coderd.go

test: use NATS in coderdtest by default (#27343)

2026-07-21 11:19:23 +02:00

csp_test.go

fix: enforce max body size on CSP violation report endpoint (#27243)

2026-07-14 12:29:38 -07:00

csp.go

fix: enforce max body size on CSP violation report endpoint (#27243)

2026-07-14 12:29:38 -07:00

debug_test.go

feat(coderd): add consolidated /debug/profile endpoint for pprof collection (#22892)

2026-03-13 14:09:39 +00:00

debug.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

deployment_test.go

…

deployment.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

deprecated.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

exp_chats_acl_test.go

feat: notify users when chats are shared (#26914)

2026-07-06 13:15:58 +01:00

exp_chats_acl.go

feat: notify users when chats are shared (#26914)

2026-07-06 13:15:58 +01:00

exp_chats_chatstate_test.go

fix(coderd): disable chat worker in tests asserting transient states (#26333)

2026-06-12 13:03:45 +00:00

exp_chats_internal_test.go

fix: use backend-selected chat agent for desktop, git, terminal (#26959)

2026-07-14 13:50:25 +01:00

exp_chats_test.go

feat: add manual chat compaction via /compact (#27081)

2026-07-21 10:58:08 +02:00

exp_chats.go

feat: add manual chat compaction via /compact (#27081)

2026-07-21 10:58:08 +02:00

experiments_test.go

…

experiments.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

export_test.go

refactor: remove legacy live-read and injected-history chat context paths (#26585)

2026-06-22 19:26:34 -06:00

externalauth_test.go

fix: prevent concurrent token refreshes (#26530)

2026-07-15 12:16:25 -08:00

externalauth.go

fix(coderd): harden oauth2 redirect validation (#27274)

2026-07-23 11:56:07 -06:00

files_test.go

fix: reject oversized and invalid zip uploads (#25877)

2026-06-02 10:11:49 -07:00

files.go

fix: reject oversized and invalid zip uploads (#25877)

2026-06-02 10:11:49 -07:00

gitsshkey_test.go

…

gitsshkey.go

feat: encrypt gitsshkeys.private_key at rest via dbcrypt (#25872)

2026-06-02 08:36:01 -06:00

inboxnotifications_internal_test.go

feat: notify users when chats are shared (#26914)

2026-07-06 13:15:58 +01:00

inboxnotifications_test.go

…

inboxnotifications.go

feat: notify users when chats are shared (#26914)

2026-07-06 13:15:58 +01:00

initscript_test.go

test: share coderdtest instances to stop paying the startup tax 22 times (#23454)

2026-03-23 19:54:43 +00:00

initscript.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

insights_internal_test.go

…

insights_test.go

…

insights.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

latencycheck.go

…

mcp_http.go

fix(coderd): enforce ActionSSH in MCP HTTP agent connection path (#24607)

2026-04-22 12:34:17 +02:00

mcp_internal_test.go

feat: add user_oidc auth type for MCP servers (#24793)

2026-05-03 11:31:48 -04:00

mcp_test.go

feat: revoke MCP server OAuth grants at the provider on disconnect (#27300)

2026-07-20 00:14:03 +02:00

mcp.go

feat: revoke MCP server OAuth grants at the provider on disconnect (#27300)

2026-07-20 00:14:03 +02:00

members_test.go

feat: make service accounts a Premium feature (#24020)

2026-04-07 12:25:32 -06:00

members.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

notifications_test.go

…

notifications.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

oauth2_error_compliance_test.go

test: reduce number of coderdtest instances (#23463)

2026-03-25 09:53:06 +00:00

oauth2_metadata_test.go

…

oauth2_metadata_validation_test.go

test: share coderdtest instances in OAuth2 validation tests (#23455)

2026-03-23 21:03:34 +00:00

oauth2_security_test.go

refactor: use sync.WaitGroup.Go in tests (#26671)

2026-06-25 15:41:09 -06:00

oauth2_test.go

fix(coderd): use dbtime.Now() instead of time.Now() in test assertions against DB timestamps (#22685)

2026-03-06 09:14:11 +00:00

oauth2.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

organizations_test.go

…

organizations.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

pagination_test.go

…

pagination.go

…

parameters_test.go

chore: remove coder_secret Terraform integration (#25512)

2026-05-21 09:19:29 -06:00

parameters.go

feat: add coderd_api_websocket_probes_total metric (#25012)

2026-06-03 10:46:07 +01:00

presets_test.go

…

presets.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

provisionerdaemons_test.go

…

provisionerdaemons.go

docs: wrap placeholder syntax in backticks in CLI help and swagger annotations (#27194)

2026-07-14 13:39:58 -04:00

provisionerjobs_internal_test.go

feat: add coderd_api_websocket_probes_total metric (#25012)

2026-06-03 10:46:07 +01:00

provisionerjobs_test.go

feat: add workspace build transition to provisioner job list (#24131)

2026-04-10 09:50:11 -05:00

provisionerjobs.go

docs: wrap placeholder syntax in backticks in CLI help and swagger annotations (#27194)

2026-07-14 13:39:58 -04:00

roles_test.go

…

roles.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

scopes_catalog_api_test.go

…

scopes_catalog.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

swagger_request_interceptor.js

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

tailnet_test.go

test: use typed atomics in test files (#25071)

2026-05-11 08:41:17 -06:00

tailnet.go

fix: pin workspace agent API client to intended agent (#26600)

2026-06-23 23:06:44 +10:00

templatebuilder_compose_test.go

feat: add POST /api/v2/templatebuilder/compose endpoint (#26351)

2026-06-15 11:07:16 -04:00

templatebuilder_handler_test.go

fix(coderd): declare project_id variable in GCP template builder bases (#27015)

2026-07-06 16:48:00 -04:00

templatebuilder_handler.go

fix: stop the template builder build progress bar from looping (#27276)

2026-07-16 09:14:07 -04:00

templates_meta_update_internal_test.go

feat: plumb time_til_autostop_notify template field (#26439)

2026-06-23 17:32:47 -05:00

templates_meta_update.go

feat: plumb time_til_autostop_notify template field (#26439)

2026-06-23 17:32:47 -05:00

templates_test.go

fix: remove excess calls to prepareSQLFilter for workspace and template endpoints (#27248)

2026-07-15 14:23:44 -07:00

templates.go

fix: remove excess calls to prepareSQLFilter for workspace and template endpoints (#27248)

2026-07-15 14:23:44 -07:00

templateversions_test.go

test(coderd): make TestTemplateVersionDryRun/ImportNotFinished deterministic (#27386)

2026-07-21 13:16:26 -05:00

templateversions.go

fix(coderd): enforce required external auth on workspace create (#26314)

2026-06-25 15:47:35 -07:00

updatecheck_test.go

…

updatecheck.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

userauth_internal_test.go

fix!: reject OIDC login when email_verified claim is non-bool or absent (#25713)

2026-06-04 14:37:19 -04:00

userauth_test.go

Revert "fix(coderd): explain default GitHub app org visibility on login rejection" (#27388)

2026-07-21 16:17:27 +00:00

userauth.go

fix(coderd): harden oauth2 redirect validation (#27274)

2026-07-23 11:56:07 -06:00

users_test.go

fix(coderd): allow user-admin password resets to succeed (#26537)

2026-07-07 09:05:14 -07:00

users.go

fix(coderd): allow user-admin password resets to succeed (#26537)

2026-07-07 09:05:14 -07:00

usersecrets_audit_test.go

feat: audit user secret create, update, and delete (#24756)

2026-04-29 12:57:47 -06:00

usersecrets_test.go

feat: enforce per-user limits on user_secrets (#25588)

2026-05-26 14:42:31 -06:00

usersecrets.go

feat: add user secrets file parser and shared validator (PLAT-240) (#26723)

2026-07-22 06:23:38 -07:00

userskills_test.go

feat: support personal skills in chats (#25366)

2026-05-20 19:50:50 +02:00

userskills.go

feat: add personal skill storage, API, and SDK (#25363)

2026-05-20 00:09:09 +02:00

webpush_internal_test.go

fix(coderd): validate webpush subscription endpoints (#24347)

2026-04-15 11:31:43 +02:00

webpush_test.go

fix: recover web push subscriptions after PWA reinstall (#24720)

2026-04-26 14:49:10 -07:00

webpush.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

workspaceagentportshare_test.go

…

workspaceagentportshare.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

workspaceagents_active_chat_internal_test.go

refactor: drop chat_model_configs provider column (#26877)

2026-07-01 15:59:55 +03:00

workspaceagents_internal_test.go

fix: use backend-selected chat agent for desktop, git, terminal (#26959)

2026-07-14 13:50:25 +01:00

workspaceagents_test.go

fix: prevent concurrent token refreshes (#26530)

2026-07-15 12:16:25 -08:00

workspaceagents.go

feat: expose external auth token expiry in agent API and CLI (#26883)

2026-07-07 12:38:37 -07:00

workspaceagentsrpc_internal_test.go

feat: event driven agent connection metric (#24355)

2026-05-11 14:27:40 -05:00

workspaceagentsrpc_test.go

test: add testutil.WaitBuffer and replace time.Sleep in tests (#22922)

2026-03-12 18:07:52 +02:00

workspaceagentsrpc.go

refactor: deprecate AIGatewayRoutingEnabled, remove direct chat routing (#26862)

2026-07-01 20:15:03 +01:00

workspaceapps_test.go

…

workspaceapps.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

workspacebuilds_on_success_test.go

feat: add workspace restart functionality to API (#25757)

2026-07-07 09:18:30 -07:00

workspacebuilds_test.go

fix(coderd): enforce required external auth on workspace create (#26314)

2026-06-25 15:47:35 -07:00

workspacebuilds.go

feat: add workspace restart functionality to API (#25757)

2026-07-07 09:18:30 -07:00

workspaceproxies_test.go

…

workspaceproxies.go

fix: correct SCIM Swagger try it out URLs (#24779)

2026-05-05 02:54:03 +05:00

workspaceresourceauth_test.go

fix: soft-delete stale workspace agents on new build (#25207)

2026-05-18 08:33:29 -04:00

workspaceresourceauth.go

fix: verify PKCS7 signature on Azure instance identity tokens (#25286)

2026-05-13 14:14:07 +00:00

workspaces_scoped_test.go

fix: isolate test HTTP clients (#25038)

2026-05-11 11:03:38 +02:00

workspaces_test.go

fix: remove excess calls to prepareSQLFilter for workspace and template endpoints (#27248)

2026-07-15 14:23:44 -07:00

workspaces.go

fix: remove excess calls to prepareSQLFilter for workspace and template endpoints (#27248)

2026-07-15 14:23:44 -07:00

workspaceupdates_test.go

…

workspaceupdates.go

…