mirror of
https://github.com/coder/coder.git
synced 2026-10-16 14:48:56 +08:00
Danielle Maywood
63a95d87f3
Part 1 of 6. `chat_diff_statuses` had one row per chat, so a chat could only track one PR, and switching branches overwrote the old branch's PR data. The primary key is now `(chat_id, git_remote_origin, git_branch)`, so each ref the agent reports gets its own row. The API still returns a single `diff_status`: the first row of the chat's statuses, ordered by `updated_at`, newest report first. The primary ref changes only when the agent reports a ref: refreshes, claims, backoffs and URL writes do not advance `updated_at`, so they cannot reorder the primary. The gitsync worker now claims, backs off and clears rows by the full key, not the whole chat. When the diff GET discovers a PR URL, it updates the existing ref row and no longer inserts one. Telemetry picks one row per chat. **NOTE**: Migration `000606` swaps the primary key under an ACCESS EXCLUSIVE lock. The table is small. Existing rows already fit the new key, so no data is rewritten. The down migration keeps only the primary row per chat. Stop old coderd instances before migrating: their `ON CONFLICT (chat_id)` upserts fail once the old key is gone. Generated by Coder Agents.
17 lines
792 B
SQL
17 lines
792 B
SQL
-- Remote URLs can carry a token, such as https://<token>@github.com/o/r.git.
|
|
-- Strip it with the same pattern as originCredentials in coderd/x/gitsync.
|
|
-- Each chat still has one row here, so this cannot create duplicate keys.
|
|
UPDATE chat_diff_statuses
|
|
SET git_remote_origin = regexp_replace(git_remote_origin, '^(https?://)[^/]*@', '\1')
|
|
WHERE git_remote_origin ~ '^https?://[^/]*@';
|
|
|
|
-- One row per chat, origin, and branch. This lets a chat track
|
|
-- more than one pull request. Both columns are NOT NULL with a
|
|
-- default of '', and the old key allowed one row per chat, so
|
|
-- existing rows already obey the new key.
|
|
ALTER TABLE chat_diff_statuses
|
|
DROP CONSTRAINT chat_diff_statuses_pkey;
|
|
|
|
ALTER TABLE chat_diff_statuses
|
|
ADD PRIMARY KEY (chat_id, git_remote_origin, git_branch);
|