mirror of
https://github.com/coder/coder.git
synced 2026-09-22 05:05:20 +08:00
Surface base template prerequisites to admins before they create a
template in the Template Builder wizard.
Today, template prerequisites (Docker socket setup, Kubernetes auth, AWS
IAM policies) are only visible in the registry README after import.
Admins hit opaque provisioner errors and have to hunt for docs. This
change extracts the prerequisites from the README and serves them via
the API so the frontend can display them inline.
## How it works
Each base template README uses HTML comment markers (`<!--
prerequisites:start -->` / `<!-- prerequisites:end -->`) to delimit the
prerequisites section. At boot time, the base catalog loader reads the
README, extracts the content between markers via `strings.Index`, and
caches both the full README and the prerequisites string.
The prerequisites are served via a new `prerequisites` field on `GET
/api/v2/templatebuilder/bases`. The full README is included in the
composed template tar bundle and stored as the template version readme.
## Changes
- Add `README.md` with prerequisite markers to
`coderd/templatebuilder/bases/{docker,kubernetes,aws-linux}/`
- New `ExtractPrerequisites()` in `prerequisites.go` using literal
string matching
- `bases.go`: load README at boot, fail loudly if missing, extract
prerequisites
- `compose.go`: include README in `ComposeResult` and tar bundle
- `codersdk`: add `Prerequisites` field to `TemplateBuilderBase`
- Handler: populate prerequisites in bases response, set readme on
template version
<details>
<summary>Implementation notes</summary>
- Prerequisites extraction uses `strings.Index` for exact literal marker
matching; no regex or AST parser needed since we control the markers.
- YAML frontmatter is deliberately retained in the stored README. The
frontend `TemplateDocsPage` already strips it at render time via
`front-matter`.
- The prerequisite markers are HTML comments, invisible in rendered
markdown.
- The `RejectsMissingReadme` test enforces that every base template must
include a README.
- AWS Linux prerequisites span two H2 sections (`## Prerequisites` and
`## Required permissions / policy`), which is why heading-based parsing
was rejected in favor of explicit markers.
*Generated with the assistance of an AI coding agent. Reviewed by
@jeremyruppel.*
</details>
Relates to https://linear.app/codercom/issue/DEVEX-446
147 lines
4.0 KiB
Go
147 lines
4.0 KiB
Go
package templatebuilder_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/coderd/templatebuilder"
|
|
)
|
|
|
|
func TestBaseTemplateOS(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("Docker", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Equal(t, templatebuilder.BaseOSLinux, templatebuilder.BaseTemplateOS("docker"))
|
|
})
|
|
|
|
t.Run("Kubernetes", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Equal(t, templatebuilder.BaseOSLinux, templatebuilder.BaseTemplateOS("kubernetes"))
|
|
})
|
|
|
|
t.Run("AWSLinux", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Equal(t, templatebuilder.BaseOSLinux, templatebuilder.BaseTemplateOS("aws-linux"))
|
|
})
|
|
|
|
t.Run("UnknownReturnsEmpty", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Equal(t, templatebuilder.BaseOS(""), templatebuilder.BaseTemplateOS("unknown-template"))
|
|
})
|
|
}
|
|
|
|
func TestBaseTemplateIDs(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ids := templatebuilder.BaseTemplateIDs()
|
|
require.Len(t, ids, 3)
|
|
require.Contains(t, ids, "docker")
|
|
require.Contains(t, ids, "kubernetes")
|
|
require.Contains(t, ids, "aws-linux")
|
|
}
|
|
|
|
func TestDefaultBaseRenderContext(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("Docker", func(t *testing.T) {
|
|
t.Parallel()
|
|
rc := templatebuilder.DefaultBaseRenderContext("docker")
|
|
require.Equal(t, "codercom/enterprise-base:ubuntu", rc.ContainerImage)
|
|
require.Nil(t, rc.ImageOptions)
|
|
})
|
|
|
|
t.Run("Kubernetes", func(t *testing.T) {
|
|
t.Parallel()
|
|
rc := templatebuilder.DefaultBaseRenderContext("kubernetes")
|
|
require.Equal(t, "codercom/enterprise-base:ubuntu", rc.ContainerImage)
|
|
require.Nil(t, rc.ImageOptions)
|
|
})
|
|
|
|
t.Run("AWSLinux", func(t *testing.T) {
|
|
t.Parallel()
|
|
rc := templatebuilder.DefaultBaseRenderContext("aws-linux")
|
|
require.Empty(t, rc.ContainerImage)
|
|
require.Nil(t, rc.ImageOptions)
|
|
})
|
|
|
|
t.Run("Unknown", func(t *testing.T) {
|
|
t.Parallel()
|
|
rc := templatebuilder.DefaultBaseRenderContext("unknown")
|
|
require.Empty(t, rc.ContainerImage)
|
|
})
|
|
|
|
t.Run("AllBaseTemplatesHaveDefaults", func(t *testing.T) {
|
|
t.Parallel()
|
|
// Verify that every known base template produces a render
|
|
// context via DefaultBaseRenderContext (not just the zero value
|
|
// from an unknown ID). This catches forgotten entries.
|
|
for _, id := range templatebuilder.BaseTemplateIDs() {
|
|
rc := templatebuilder.DefaultBaseRenderContext(id)
|
|
_ = rc // existence is the assertion; the value varies per template
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestBaseTemplateFS(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("KnownTemplate", func(t *testing.T) {
|
|
t.Parallel()
|
|
fsys, err := templatebuilder.BaseTemplateFS("docker")
|
|
require.NoError(t, err)
|
|
require.NotNil(t, fsys)
|
|
})
|
|
|
|
t.Run("UnknownTemplate", func(t *testing.T) {
|
|
t.Parallel()
|
|
_, err := templatebuilder.BaseTemplateFS("nonexistent")
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), "unknown base template")
|
|
})
|
|
}
|
|
|
|
func TestBaseReadme(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("KnownBasesHaveReadme", func(t *testing.T) {
|
|
t.Parallel()
|
|
for _, id := range templatebuilder.BaseTemplateIDs() {
|
|
readme := templatebuilder.BaseReadme(id)
|
|
require.NotEmpty(t, readme, "base %q should have a README", id)
|
|
}
|
|
})
|
|
|
|
t.Run("UnknownReturnsEmpty", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Empty(t, templatebuilder.BaseReadme("nonexistent"))
|
|
})
|
|
}
|
|
|
|
func TestBasePrerequisites(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
t.Run("KnownBasesHavePrerequisites", func(t *testing.T) {
|
|
t.Parallel()
|
|
for _, id := range templatebuilder.BaseTemplateIDs() {
|
|
prereqs := templatebuilder.BasePrerequisites(id)
|
|
require.NotEmpty(t, prereqs, "base %q should have prerequisites", id)
|
|
require.Contains(t, prereqs, "## Prerequisites",
|
|
"base %q prerequisites should contain the heading", id)
|
|
}
|
|
})
|
|
|
|
t.Run("AWSLinuxIncludesPermissions", func(t *testing.T) {
|
|
t.Parallel()
|
|
prereqs := templatebuilder.BasePrerequisites("aws-linux")
|
|
require.Contains(t, prereqs, "## Required permissions / policy",
|
|
"AWS Linux prerequisites should include the permissions section")
|
|
})
|
|
|
|
t.Run("UnknownReturnsEmpty", func(t *testing.T) {
|
|
t.Parallel()
|
|
require.Empty(t, templatebuilder.BasePrerequisites("nonexistent"))
|
|
})
|
|
}
|