mirror of
https://github.com/coder/coder.git
synced 2026-09-22 21:22:17 +08:00
Closes [DOCS-256](https://linear.app/coder/issue/DOCS-256). Sibling to [DOCS-253](https://linear.app/coder/issue/DOCS-253) (#25740). Updates docs URL references across the non-TypeScript surface of `coder/coder` to match the current docs site structure. Source-of-truth for redirects is `coder/coder.com/redirects.json` (parent ticket [DOCS-209](https://linear.app/coder/issue/DOCS-209)). ## What changed | Area | Files | URL mapping | |---|---|---| | Top-level README | `README.md` | `/docs/workspaces` -> `/docs/user-guides/workspace-management`, `/docs/templates` -> `/docs/admin/templates`, `/docs/ides` -> `/docs/user-guides/workspace-access` | | Docs source | `docs/admin/security/0001_user_apikeys_invalidation.md` | `/docs/admin/audit-logs` -> `/docs/admin/security/audit-logs` | | Docs source | `docs/install/cloud/azure-vm.md` | `/docs/coder-oss/latest/install` -> `/docs/install` | | Dogfood | `dogfood/coder/guide.md` | `/docs/ides` -> `/docs/user-guides/workspace-access` | | Helm | `helm/coder/values.yaml` | `/docs/admin/workspace-proxies` -> `/docs/admin/networking/workspace-proxies` | | Enterprise coderd | `enterprise/coderd/coderd.go` | `/docs/admin/encryption` -> `/docs/admin/security/database-encryption` (error message) | | Release tooling | `scripts/release/main_internal_test.go` | `/docs/admin/upgrade` -> `/docs/install/upgrade` (test fixture, matches `generate_release_notes.sh`) | | AI bridge | `aibridge/client.go` | repinned to current `main` SHA on renamed `docs/ai-coder/ai-gateway/monitoring.md`, line range `#L47-L57` | | Example templates | 12 `examples/templates/*/README.md`, `examples/parameters/*`, `examples/parameters-dynamic-options/README.md`, `examples/workspace-tags/README.md`, `examples/parameters/main.tf`, `examples/examples.gen.json` (regenerated) | `/docs/workspaces` -> `/docs/user-guides/workspace-management`, `/docs/templates/parameters` -> `/docs/admin/templates/extending-templates/parameters`, `/docs/templates/dev-containers` -> `/docs/admin/integrations/devcontainers`, `/docs/dotfiles` -> `/docs/user-guides/workspace-dotfiles`, `/docs/about/architecture#agents` -> `/docs/admin/infrastructure/architecture#agents` | | Live notification templates (DB) | New migration `000510_fix_dormancy_notification_docs_urls.up.sql` and `.down.sql` plus the four regenerated SMTP/webhook goldens under `coderd/notifications/testdata/rendered-templates/` | `/docs/templates/schedule#dormancy-threshold-enterprise` -> `/docs/admin/templates/managing-templates/schedule#dormancy-threshold`, `/docs/templates/schedule#dormancy-auto-deletion-enterprise` -> `/docs/admin/templates/managing-templates/schedule#dormancy-auto-deletion` | The migration uses `REPLACE(body_template, ...)` scoped by template id and `LIKE '%/docs/templates/schedule%'`, so it works regardless of which intermediate state (`000232`, `000262`, `000305`, or `000311`) is currently in the row. ## What did not change Historical SQL migrations `000232`, `000262`, `000305`, and `000311` are not modified because migrations are immutable history. The 18 remaining stale URL references in those files are superseded at runtime by migration `000510`. This decision matches the pattern used in the A1 sister PR (#25740). ## Verification - `go test ./coderd/database/migrations/... -count=1` (UP+DOWN) - `go test ./coderd/notifications/ -run TestNotificationTemplates_Golden -update -count=1` to regenerate the four `.golden` files - `go test ./scripts/release/ -run Test_removeMainlineBlurb -count=1` - `make pre-commit` (gen + fmt + lint + slim build) ran clean as part of the commit hook I also fixed a pre-existing emdash on line 35 of `examples/templates/azure-linux/README.md` that the lint flagged once the file entered my diff. The line was already in `main`, but `make gen` rewrites `examples/examples.gen.json` whenever a `README.md` changes, so the line came back as a `+` in the diff against `origin/main` and the `lint/emdash` step refused it. <details> <summary>Pre-mortem</summary> | Risk | Mitigation | |---|---| | Migration overwrites future template edits | Used `REPLACE` instead of full body overwrite. `WHERE id IN (...) AND body_template LIKE '%/docs/templates/schedule%'` further scopes the write | | Goldens drift from migrated body | Regenerated goldens via `-update` after the migration was in place, so the goldens reflect the post-migration state | | Down migration leaves stale URLs | Down migration reverses the REPLACE so a rollback restores the prior URLs | | Fragment loss when redirect strips fragment | Verified the destination `schedule.md` contains `## Dormancy threshold` and `## Dormancy auto-deletion` anchors | | Terraform parse breakage in `examples/parameters/main.tf` | Only comments changed; Terraform parser is unaffected | | Test fixtures in `scripts/release` diverging from `generate_release_notes.sh` | Updated to match the script, which already emits `/docs/install/upgrade` | </details> --- Generated by Coder Agent on behalf of @nickvigilante.
184 lines
4.8 KiB
Go
184 lines
4.8 KiB
Go
package main
|
|
|
|
import (
|
|
"context"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/spf13/afero"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func Test_removeMainlineBlurb(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
body string
|
|
want string
|
|
}{
|
|
{
|
|
name: "NoMainlineBlurb",
|
|
body: `## Changelog
|
|
|
|
### Chores
|
|
|
|
- Add support for additional Azure Instance Identity RSA Certificates (#13028) (@kylecarbs)
|
|
|
|
Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/coder/compare/v2.10.1...v2.10.2)
|
|
|
|
## Container image
|
|
|
|
- ` + "`" + `docker pull ghcr.io/coder/coder:v2.10.2` + "`" + `
|
|
|
|
## Install/upgrade
|
|
|
|
Refer to our docs to [install](https://coder.com/docs/install) or [upgrade](https://coder.com/docs/install/upgrade) Coder, or use a release asset below.
|
|
`,
|
|
want: `## Changelog
|
|
|
|
### Chores
|
|
|
|
- Add support for additional Azure Instance Identity RSA Certificates (#13028) (@kylecarbs)
|
|
|
|
Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/coder/compare/v2.10.1...v2.10.2)
|
|
|
|
## Container image
|
|
|
|
- ` + "`" + `docker pull ghcr.io/coder/coder:v2.10.2` + "`" + `
|
|
|
|
## Install/upgrade
|
|
|
|
Refer to our docs to [install](https://coder.com/docs/install) or [upgrade](https://coder.com/docs/install/upgrade) Coder, or use a release asset below.
|
|
`,
|
|
},
|
|
{
|
|
name: "WithMainlineBlurb",
|
|
body: `## Changelog
|
|
|
|
> [!NOTE]
|
|
> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/install/releases).
|
|
|
|
### Chores
|
|
|
|
- Add support for additional Azure Instance Identity RSA Certificates (#13028) (@kylecarbs)
|
|
|
|
Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/coder/compare/v2.10.1...v2.10.2)
|
|
|
|
## Container image
|
|
|
|
- ` + "`" + `docker pull ghcr.io/coder/coder:v2.10.2` + "`" + `
|
|
|
|
## Install/upgrade
|
|
|
|
Refer to our docs to [install](https://coder.com/docs/install) or [upgrade](https://coder.com/docs/install/upgrade) Coder, or use a release asset below.
|
|
`,
|
|
want: `## Changelog
|
|
|
|
### Chores
|
|
|
|
- Add support for additional Azure Instance Identity RSA Certificates (#13028) (@kylecarbs)
|
|
|
|
Compare: [` + "`" + `v2.10.1...v2.10.2` + "`" + `](https://github.com/coder/coder/compare/v2.10.1...v2.10.2)
|
|
|
|
## Container image
|
|
|
|
- ` + "`" + `docker pull ghcr.io/coder/coder:v2.10.2` + "`" + `
|
|
|
|
## Install/upgrade
|
|
|
|
Refer to our docs to [install](https://coder.com/docs/install) or [upgrade](https://coder.com/docs/install/upgrade) Coder, or use a release asset below.
|
|
`,
|
|
},
|
|
{
|
|
name: "EntireQuotedBlurbIsRemoved",
|
|
body: `## Changelog
|
|
|
|
> [!NOTE]
|
|
> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/install/releases).
|
|
> This is an extended note.
|
|
> This is another extended note.
|
|
|
|
### Best release yet!
|
|
|
|
Enjoy.
|
|
`,
|
|
want: `## Changelog
|
|
|
|
### Best release yet!
|
|
|
|
Enjoy.
|
|
`,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
if diff := cmp.Diff(removeMainlineBlurb(tt.body), tt.want); diff != "" {
|
|
require.Fail(t, "removeMainlineBlurb() mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_addStableSince(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
date := time.Date(2024, time.April, 23, 0, 0, 0, 0, time.UTC)
|
|
body := "## Changelog"
|
|
|
|
want := "> ## Stable (since April 23, 2024)\n\n## Changelog"
|
|
got := addStableSince(date, body)
|
|
|
|
if diff := cmp.Diff(want, got); diff != "" {
|
|
require.Fail(t, "addStableSince() mismatch (-want +got):\n%s", diff)
|
|
}
|
|
|
|
// Test that it doesn't add twice.
|
|
got = addStableSince(date, got)
|
|
|
|
if diff := cmp.Diff(want, got); diff != "" {
|
|
require.Fail(t, "addStableSince() mismatch (-want +got):\n%s", diff, "addStableSince() should not add twice")
|
|
}
|
|
}
|
|
|
|
func Test_release_autoversion(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx := context.Background()
|
|
dir := filepath.Join("testdata", "autoversion")
|
|
|
|
fs := afero.NewCopyOnWriteFs(afero.NewOsFs(), afero.NewMemMapFs())
|
|
r := releaseCommand{
|
|
fs: afero.NewBasePathFs(fs, dir),
|
|
}
|
|
|
|
err := r.autoversion(ctx, "mainline", "v2.11.1")
|
|
require.NoError(t, err)
|
|
|
|
err = r.autoversion(ctx, "stable", "v2.9.4")
|
|
require.NoError(t, err)
|
|
|
|
files, err := filepath.Glob(filepath.Join(dir, "docs", "*.md"))
|
|
require.NoError(t, err)
|
|
|
|
for _, file := range files {
|
|
t.Run(file, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got, err := afero.ReadFile(fs, file)
|
|
require.NoError(t, err)
|
|
|
|
want, err := afero.ReadFile(fs, file+".golden")
|
|
require.NoError(t, err)
|
|
|
|
if diff := cmp.Diff(string(got), string(want)); diff != "" {
|
|
require.Failf(t, "mismatch (-want +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|