Files
coder/coderd/x/chatd/model_routing_aibridge.go
T
Cian Johnston 843754a547 refactor(coderd/x/chatd): remove dead model-routing dispatch shim (#26942)
Follow-up to #26862 ("remove direct chat routing"), which collapsed the
routing discriminated union into a single `aiGatewayModelRoute` but left
a one-path dispatch shim behind in `model_routing.go`.

Removes
`resolveModelRouteForConfig`/`resolveModelRouteForProviderType`/`newModel`
wrapper functions that did nothing but call their `*AIGateway*`
counterparts, and renames the `*AIGateway*` targets to take over those
names directly. Also collapses a redundant if/else in
`title_override.go` where both branches called the same function with
the same effective argument, and has `chatutil.NormalizedStringPointer`
delegate to the existing `coderd/util/strings.EmptyToNil` instead of
reimplementing empty-string-to-nil logic.

No behavior change.

<details>
<summary>Investigation notes / decision log</summary>

Two independent read-only investigations were run over `coderd/x/chatd`
looking for cleanup opportunities following #26862: one focused on
residue from that PR specifically, one a general over-engineering pass
on the whole package. Both independently converged on the
`model_routing.go` shim as the top finding (verified zero divergent call
sites).

Other candidates considered and explicitly deferred/rejected for this
PR:

- Renaming away the vestigial `AIGateway` prefix package-wide:
cosmetic-only, touches many call sites, skipped.
- Inlining the `chatcost` subpackage into `chatd`: unrelated to #26862,
skipped.
- Deleting the deprecated `AIGatewayRoutingEnabled` deployment flag:
confirmed dead/no-op, but intentionally kept as a back-compat shim per
#26862; removal should follow the same deprecation cadence as other
deprecated deployment options, as a separate, differently-timed change.
- Folding `chatutil` entirely into `chatprovider`/`chatopenai`:
`NormalizedStringPointer` overlapped with
`coderd/util/strings.EmptyToNil` (now reused), but `NormalizedEnumValue`
has no equivalent elsewhere in the repo and still has 2 real call sites,
so the package stays.

</details>

---
Generated by Coder Agents on behalf of @johnstcn.
2026-07-02 11:22:56 +01:00

336 lines
9.6 KiB
Go

package chatd
import (
"context"
"database/sql"
"net/http"
"strings"
"charm.land/fantasy"
fantasyanthropic "charm.land/fantasy/providers/anthropic"
fantasyopenai "charm.land/fantasy/providers/openai"
fantasyopenaicompat "charm.land/fantasy/providers/openaicompat"
"github.com/google/uuid"
"golang.org/x/xerrors"
"github.com/coder/coder/v2/coderd/aibridge"
"github.com/coder/coder/v2/coderd/database"
"github.com/coder/coder/v2/coderd/x/chatd/chatdebug"
"github.com/coder/coder/v2/coderd/x/chatd/chaterror"
"github.com/coder/coder/v2/coderd/x/chatd/chatprovider"
"github.com/coder/coder/v2/codersdk"
)
const (
aibridgeLocalBaseURL = "http://coder-aibridge"
// aibridgePlaceholderAPIKey satisfies fantasy clients that require a
// non-empty API key before aibridged resolves the real credential.
aibridgePlaceholderAPIKey = "coder-aibridge"
aibridgeDelegatedBYOKMarker = "delegated"
)
type aiGatewayModelRoute struct {
Provider database.AIProvider
ModelProviderHint string
ProviderAuth aiGatewayProviderAuth
}
func newAIGatewayModelRoute(
provider database.AIProvider,
modelProviderHint string,
auth aiGatewayProviderAuth,
) aiGatewayModelRoute {
return aiGatewayModelRoute{
Provider: provider,
ModelProviderHint: modelProviderHint,
ProviderAuth: auth,
}
}
type aiGatewayProviderAuth struct {
Headers map[string]string
}
func (aiGatewayProviderAuth) String() string {
return "aiGatewayProviderAuth{Headers:<redacted>}"
}
func (a aiGatewayProviderAuth) GoString() string {
return a.String()
}
type aiGatewayRequestFormat int
const (
aiGatewayRequestFormatOpenAI aiGatewayRequestFormat = iota
aiGatewayRequestFormatAnthropic
)
type aiGatewayRoundTripper struct {
base http.RoundTripper
apiKeyID string
providerAuth aiGatewayProviderAuth
}
func (t *aiGatewayRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
ctx := aibridge.WithDelegatedAPIKeyID(req.Context(), t.apiKeyID)
cloned := req.Clone(ctx)
for name, value := range t.providerAuth.Headers {
cloned.Header.Set(name, value)
}
if len(t.providerAuth.Headers) > 0 {
cloned.Header.Set(aibridge.HeaderCoderToken, aibridgeDelegatedBYOKMarker)
}
return t.base.RoundTrip(cloned)
}
// ValidateAIGatewayProviderModel rejects slash-namespaced models on
// OpenRouter-like providers typed as openai, where the provider type
// strips the vendor prefix.
func ValidateAIGatewayProviderModel(provider database.AIProvider, model string) error {
if provider.Type != database.AIProviderTypeOpenai {
return nil
}
if !isSlashNamespacedAIGatewayModel(model) || !isOpenRouterLikeAIGatewayProvider(provider) {
return nil
}
return xerrors.New("OpenRouter-like provider configured as type openai does not support slash-namespaced models")
}
func isSlashNamespacedAIGatewayModel(model string) bool {
prefix, suffix, ok := strings.Cut(strings.TrimSpace(model), "/")
return ok && strings.TrimSpace(prefix) != "" && strings.TrimSpace(suffix) != ""
}
func isOpenRouterLikeAIGatewayProvider(provider database.AIProvider) bool {
if strings.EqualFold(strings.TrimSpace(provider.Name), "openrouter") {
return true
}
host := chatprovider.ProviderBaseURLHostname(provider.BaseUrl)
return host == "openrouter.ai" || strings.HasSuffix(host, ".openrouter.ai")
}
func (p *Server) newModel(
_ context.Context,
req modelClientRequest,
route aiGatewayModelRoute,
opts modelBuildOptions,
) (fantasy.LanguageModel, error) {
if route.Provider.ID == uuid.Nil {
return nil, xerrors.New("AI Gateway routing requires a concrete AI provider")
}
if route.Provider.Name == "" {
return nil, xerrors.New("AI Gateway routing requires an AI provider name")
}
if opts.ActiveAPIKeyID == "" {
return nil, chaterror.WithClassification(
xerrors.New("AI Gateway routing requires the active turn API key ID"),
chaterror.ClassifiedError{
Kind: codersdk.ChatErrorKindMissingKey,
Retryable: false,
Detail: "If this error persists after resending, please report it as a bug.",
},
)
}
if err := ValidateAIGatewayProviderModel(route.Provider, req.ModelName); err != nil {
return nil, chaterror.WithClassification(
err,
chaterror.ClassifiedError{
Kind: codersdk.ChatErrorKindConfig,
Retryable: false,
Detail: "Ask an administrator to change the AI provider type to openrouter or openai-compat.",
},
)
}
factoryPtr := p.aibridgeTransportFactory
if factoryPtr == nil {
return nil, xerrors.New("AI Gateway transport factory is not configured")
}
factory := factoryPtr.Load()
if factory == nil || *factory == nil {
return nil, xerrors.New("AI Gateway transport factory is not configured")
}
rt, err := (*factory).TransportFor(route.Provider.Name, aibridge.SourceAgents)
if err != nil {
return nil, xerrors.Errorf("create AI Gateway transport: %w", err)
}
baseRT := http.RoundTripper(&aiGatewayRoundTripper{
base: rt,
apiKeyID: opts.ActiveAPIKeyID,
providerAuth: route.ProviderAuth,
})
if opts.RecordHTTP {
baseRT = &chatdebug.RecordingTransport{Base: baseRT}
}
config := fantasyConfigForAIBridge(route.Provider.Type)
return newLanguageModel(
config.ProviderHint,
req.ModelName,
config.Keys,
req.UserAgent,
req.ExtraHeaders,
&http.Client{Transport: baseRT},
)
}
type aibridgeFantasyConfig struct {
ProviderHint string
Keys chatprovider.ProviderAPIKeys
}
func fantasyConfigForAIBridge(providerType database.AIProviderType) aibridgeFantasyConfig {
var fantasyProvider string
baseURL := aibridgeLocalBaseURL + "/v1"
switch providerType {
case database.AIProviderTypeAnthropic, database.AIProviderTypeBedrock:
fantasyProvider = fantasyanthropic.Name
baseURL = aibridgeLocalBaseURL
case database.AIProviderTypeOpenai:
fantasyProvider = fantasyopenai.Name
default:
fantasyProvider = fantasyopenaicompat.Name
}
return aibridgeFantasyConfig{
ProviderHint: fantasyProvider,
Keys: chatprovider.ProviderAPIKeys{
ByProvider: map[string]string{
fantasyProvider: aibridgePlaceholderAPIKey,
},
BaseURLByProvider: map[string]string{
fantasyProvider: baseURL,
},
},
}
}
func aiGatewayRequestFormatForProviderType(providerType database.AIProviderType) aiGatewayRequestFormat {
switch providerType {
case database.AIProviderTypeAnthropic, database.AIProviderTypeBedrock:
return aiGatewayRequestFormatAnthropic
default:
return aiGatewayRequestFormatOpenAI
}
}
func (p *Server) aiGatewayProviderAuthForUser(
ctx context.Context,
ownerID uuid.UUID,
provider database.AIProvider,
format aiGatewayRequestFormat,
) (aiGatewayProviderAuth, error) {
if !p.allowBYOK {
return aiGatewayProviderAuth{}, nil
}
userKey, err := p.db.GetUserAIProviderKeyByProviderID(ctx, database.GetUserAIProviderKeyByProviderIDParams{
UserID: ownerID,
AIProviderID: provider.ID,
})
if err != nil {
if xerrors.Is(err, sql.ErrNoRows) {
return aiGatewayProviderAuth{}, nil
}
return aiGatewayProviderAuth{}, xerrors.Errorf("get user AI provider key: %w", err)
}
apiKey := strings.TrimSpace(userKey.APIKey)
if apiKey == "" {
return aiGatewayProviderAuth{}, nil
}
headers := map[string]string{}
switch format {
case aiGatewayRequestFormatAnthropic:
headers["X-Api-Key"] = apiKey
default:
headers["Authorization"] = "Bearer " + apiKey
}
return aiGatewayProviderAuth{Headers: headers}, nil
}
func (p *Server) resolveAIGatewayRoute(
ctx context.Context,
ownerID uuid.UUID,
provider database.AIProvider,
modelProviderHint string,
) (aiGatewayModelRoute, error) {
auth, err := p.aiGatewayProviderAuthForUser(
ctx,
ownerID,
provider,
aiGatewayRequestFormatForProviderType(provider.Type),
)
if err != nil {
return aiGatewayModelRoute{}, xerrors.Errorf("resolve AI Gateway provider auth: %w", err)
}
return newAIGatewayModelRoute(provider, modelProviderHint, auth), nil
}
func (p *Server) resolveModelRouteForConfig(
ctx context.Context,
ownerID uuid.UUID,
modelConfig database.ChatModelConfig,
) (aiGatewayModelRoute, error) {
provider, err := p.gatewayProviderForConfig(ctx, modelConfig)
if err != nil {
return aiGatewayModelRoute{}, err
}
return p.resolveAIGatewayRoute(ctx, ownerID, provider, string(provider.Type))
}
func (p *Server) resolveModelRouteForProviderType(
ctx context.Context,
ownerID uuid.UUID,
providerType string,
) (aiGatewayModelRoute, error) {
provider, err := p.aiProviderForProviderType(ctx, providerType)
if err != nil {
return aiGatewayModelRoute{}, err
}
return p.resolveAIGatewayRoute(
ctx,
ownerID,
provider,
chatprovider.NormalizeProvider(providerType),
)
}
func (p *Server) gatewayProviderForConfig(
ctx context.Context,
modelConfig database.ChatModelConfig,
) (database.AIProvider, error) {
if !modelConfig.AIProviderID.Valid {
return database.AIProvider{}, xerrors.Errorf(
"AI Gateway routing requires AI provider metadata for model config %s (%s)",
modelConfig.ID,
modelConfig.Model,
)
}
return p.enabledAIProviderByID(ctx, modelConfig.AIProviderID.UUID)
}
func (p *Server) aiProviderForProviderType(
ctx context.Context,
providerType string,
) (database.AIProvider, error) {
providers, err := p.db.GetAIProviders(ctx, database.GetAIProvidersParams{})
if err != nil {
return database.AIProvider{}, xerrors.Errorf("get enabled AI providers: %w", err)
}
normalizedProviderType := chatprovider.NormalizeProvider(providerType)
for _, provider := range providers {
if !provider.Enabled {
continue
}
if chatprovider.NormalizeProvider(string(provider.Type)) != normalizedProviderType {
continue
}
return provider, nil
}
return database.AIProvider{}, xerrors.Errorf(
"AI Gateway routing requires a usable AI provider for provider type %q",
providerType,
)
}