mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
# Support IAM role assumption for AWS Bedrock in AI Bridge ## Summary Implements https://linear.app/codercom/issue/AIGOV-371/support-dynamic-bedrock-assumerole-across-aws-accounts-for-ai-gateway A Bedrock provider can now be configured with an IAM role to assume. Before calling Bedrock, the gateway assumes that role via STS and signs requests with the resulting temporary credentials. Whether the role lives in the same account or another one is entirely a matter of the role's trust policy. ## Problem Many organizations prohibit long-lived AWS access keys and expect workloads to authenticate through assumed IAM roles instead. A common case is an organization that runs Bedrock across several AWS accounts, one per business unit, and needs each unit's usage billed to its own account by assuming a role there. AI Bridge previously authenticated a Bedrock provider only with static keys or the gateway's own ambient AWS identity, which is shared by every provider, with no way to assume a role. These deployments had no clean path. ## How it works When a provider is configured with a role ARN, the gateway uses its base identity to assume that role via STS and signs Bedrock requests with the temporary credentials it returns. The base identity is whatever the AWS default credential chain resolves, IRSA, EKS Pod Identity, EC2 Instance Profile, or static keys. Credentials are resolved once when the provider is set up and are then cached and rotated, so individual requests are served from the cache rather than triggering a new STS call. A deployment that needs several roles configures several providers, each pointing at its own role. ## Configuration The role ARN is part of the Bedrock provider settings and is set through the AI provider API. It is optional: a provider with no role ARN behaves exactly as before. ## Scope and trade-offs - This PR is backend only. The settings UI for the role ARN ships in a follow-up. - Configuration is not exposed through environment variables. Environment-based provider configuration is being phased out in favor of database-managed providers, so the role ARN is intentionally database and API only. Follow-up PR: https://github.com/coder/coder/pull/26578
318 lines
10 KiB
Go
318 lines
10 KiB
Go
package integrationtest
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"context"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/coder/coder/v2/aibridge"
|
|
"github.com/coder/coder/v2/aibridge/aibridgetest"
|
|
"github.com/coder/coder/v2/aibridge/config"
|
|
"github.com/coder/coder/v2/aibridge/fixtures"
|
|
"github.com/coder/coder/v2/aibridge/intercept/apidump"
|
|
"github.com/coder/coder/v2/aibridge/internal/testutil"
|
|
"github.com/coder/coder/v2/aibridge/provider"
|
|
)
|
|
|
|
const osSep = string(filepath.Separator)
|
|
|
|
func TestAPIDump(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
cases := []struct {
|
|
name string
|
|
fixture []byte
|
|
providerFunc func(addr, dumpDir string) aibridge.Provider
|
|
path string
|
|
headers http.Header
|
|
expectProviderDir string
|
|
}{
|
|
{
|
|
name: "anthropic",
|
|
fixture: fixtures.AntSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return aibridgetest.NewAnthropicProvider(t, anthropicCfgWithAPIDump(addr, apiKey, dumpDir), nil)
|
|
},
|
|
path: pathAnthropicMessages,
|
|
expectProviderDir: config.ProviderAnthropic,
|
|
},
|
|
{
|
|
name: "openai_chat_completions",
|
|
fixture: fixtures.OaiChatSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewOpenAI(openaiCfgWithAPIDump(addr, apiKey, dumpDir))
|
|
},
|
|
path: pathOpenAIChatCompletions,
|
|
expectProviderDir: config.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "openai_responses",
|
|
fixture: fixtures.OaiResponsesBlockingSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewOpenAI(openaiCfgWithAPIDump(addr, apiKey, dumpDir))
|
|
},
|
|
path: pathOpenAIResponses,
|
|
expectProviderDir: config.ProviderOpenAI,
|
|
},
|
|
{
|
|
name: "copilot_chat_completions",
|
|
fixture: fixtures.OaiChatSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewCopilot(config.Copilot{BaseURL: addr, APIDumpDir: dumpDir})
|
|
},
|
|
path: pathCopilotChatCompletions,
|
|
headers: http.Header{"Authorization": {"Bearer test-copilot-token"}},
|
|
expectProviderDir: config.ProviderCopilot,
|
|
},
|
|
{
|
|
name: "copilot_responses",
|
|
fixture: fixtures.OaiResponsesBlockingSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewCopilot(config.Copilot{BaseURL: addr, APIDumpDir: dumpDir})
|
|
},
|
|
path: pathCopilotResponses,
|
|
headers: http.Header{"Authorization": {"Bearer test-copilot-token"}},
|
|
expectProviderDir: config.ProviderCopilot,
|
|
},
|
|
{
|
|
name: "copilot_custom_name_chat_completions",
|
|
fixture: fixtures.OaiChatSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewCopilot(config.Copilot{
|
|
Name: "copilot-business",
|
|
BaseURL: addr,
|
|
APIDumpDir: dumpDir,
|
|
})
|
|
},
|
|
path: "/copilot-business/chat/completions",
|
|
headers: http.Header{"Authorization": {"Bearer test-copilot-token"}},
|
|
expectProviderDir: "copilot-business",
|
|
},
|
|
{
|
|
name: "copilot_custom_name_responses",
|
|
fixture: fixtures.OaiChatSimple,
|
|
providerFunc: func(addr, dumpDir string) aibridge.Provider {
|
|
return provider.NewCopilot(config.Copilot{
|
|
Name: "copilot-enterprise",
|
|
BaseURL: addr,
|
|
APIDumpDir: dumpDir,
|
|
})
|
|
},
|
|
path: "/copilot-enterprise/chat/completions",
|
|
headers: http.Header{"Authorization": {"Bearer test-copilot-token"}},
|
|
expectProviderDir: "copilot-enterprise",
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx, cancel := context.WithTimeout(t.Context(), testutil.WaitLong)
|
|
t.Cleanup(cancel)
|
|
|
|
// Setup mock upstream server.
|
|
fix := fixtures.Parse(t, tc.fixture)
|
|
srv := testutil.NewMockUpstream(ctx, t, testutil.NewFixtureResponse(fix))
|
|
|
|
// Create temp dir for API dumps.
|
|
dumpDir := t.TempDir()
|
|
|
|
bridgeServer := newBridgeTestServer(ctx, t, srv.URL,
|
|
withCustomProvider(tc.providerFunc(srv.URL, dumpDir)),
|
|
)
|
|
|
|
resp, err := bridgeServer.makeRequest(t, http.MethodPost, tc.path, fix.Request(), tc.headers)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
_, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
|
|
// Verify dump files were created.
|
|
interceptions := bridgeServer.Recorder.RecordedInterceptions()
|
|
require.Len(t, interceptions, 1)
|
|
interceptionID := interceptions[0].ID
|
|
|
|
// Find dump files for this interception by walking the dump directory.
|
|
var reqDumpFile, respDumpFile string
|
|
err = filepath.Walk(dumpDir, func(path string, info os.FileInfo, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if info.IsDir() {
|
|
return nil
|
|
}
|
|
// Files are named: {timestamp}-{interceptionID}.{req|resp}.txt
|
|
if strings.Contains(path, interceptionID) {
|
|
if strings.HasSuffix(path, apidump.SuffixRequest) {
|
|
reqDumpFile = path
|
|
} else if strings.HasSuffix(path, apidump.SuffixResponse) {
|
|
respDumpFile = path
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
require.NoError(t, err)
|
|
require.NotEmpty(t, reqDumpFile, "request dump file should exist")
|
|
require.NotEmpty(t, respDumpFile, "response dump file should exist")
|
|
|
|
// Verify dump files are in the correct provider subdirectory.
|
|
require.Contains(t, reqDumpFile, filepath.Join(dumpDir, tc.expectProviderDir)+osSep,
|
|
"request dump should be in the %s provider directory", tc.expectProviderDir)
|
|
require.Contains(t, respDumpFile, filepath.Join(dumpDir, tc.expectProviderDir)+osSep,
|
|
"response dump should be in the %s provider directory", tc.expectProviderDir)
|
|
|
|
// Verify request dump contains expected HTTP request format.
|
|
reqDumpData, err := os.ReadFile(reqDumpFile)
|
|
require.NoError(t, err)
|
|
|
|
// Parse the dumped HTTP request.
|
|
dumpReq, err := http.ReadRequest(bufio.NewReader(bytes.NewReader(reqDumpData)))
|
|
require.NoError(t, err)
|
|
dumpBody, err := io.ReadAll(dumpReq.Body)
|
|
require.NoError(t, err)
|
|
|
|
// Compare requests semantically (key order may differ).
|
|
require.JSONEq(t, string(dumpBody), string(fix.Request()), "request body JSON should match semantically")
|
|
|
|
// Verify response dump contains expected HTTP response format.
|
|
respDumpData, err := os.ReadFile(respDumpFile)
|
|
require.NoError(t, err)
|
|
|
|
// Parse the dumped HTTP response.
|
|
dumpResp, err := http.ReadResponse(bufio.NewReader(bytes.NewReader(respDumpData)), nil)
|
|
require.NoError(t, err)
|
|
defer dumpResp.Body.Close()
|
|
require.Equal(t, http.StatusOK, dumpResp.StatusCode)
|
|
dumpRespBody, err := io.ReadAll(dumpResp.Body)
|
|
require.NoError(t, err)
|
|
|
|
// Compare responses semantically (key order may differ).
|
|
expectedRespBody := fix.NonStreaming()
|
|
require.JSONEq(t, string(expectedRespBody), string(dumpRespBody), "response body JSON should match semantically")
|
|
|
|
bridgeServer.Recorder.VerifyAllInterceptionsEnded(t)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAPIDumpPassthrough(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
const responseBody = `{"object":"list","data":[{"id":"gpt-4","object":"model"}]}`
|
|
|
|
cases := []struct {
|
|
name string
|
|
providerFunc func(addr string, dumpDir string) aibridge.Provider
|
|
requestPath string
|
|
expectDumpName string
|
|
}{
|
|
{
|
|
name: "anthropic",
|
|
providerFunc: func(addr string, dumpDir string) aibridge.Provider {
|
|
return aibridgetest.NewAnthropicProvider(t, anthropicCfgWithAPIDump(addr, apiKey, dumpDir), nil)
|
|
},
|
|
requestPath: "/anthropic/v1/models",
|
|
expectDumpName: "-v1-models-",
|
|
},
|
|
{
|
|
name: "openai",
|
|
providerFunc: func(addr string, dumpDir string) aibridge.Provider {
|
|
return provider.NewOpenAI(openaiCfgWithAPIDump(addr, apiKey, dumpDir))
|
|
},
|
|
requestPath: "/openai/v1/models",
|
|
expectDumpName: "-models-",
|
|
},
|
|
{
|
|
name: "copilot",
|
|
providerFunc: func(addr string, dumpDir string) aibridge.Provider {
|
|
return provider.NewCopilot(config.Copilot{BaseURL: addr, APIDumpDir: dumpDir})
|
|
},
|
|
requestPath: "/copilot/models",
|
|
expectDumpName: "-models-",
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
ctx, cancel := context.WithTimeout(t.Context(), testutil.WaitLong)
|
|
t.Cleanup(cancel)
|
|
|
|
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.Write([]byte(responseBody))
|
|
}))
|
|
t.Cleanup(upstream.Close)
|
|
|
|
dumpDir := t.TempDir()
|
|
|
|
bridgeServer := newBridgeTestServer(ctx, t, upstream.URL,
|
|
withCustomProvider(tc.providerFunc(upstream.URL, dumpDir)),
|
|
)
|
|
|
|
resp, err := bridgeServer.makeRequest(t, http.MethodGet, tc.requestPath, nil)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
|
|
// Find dump files in the passthrough directory.
|
|
passthroughDir := filepath.Join(dumpDir, tc.name, "passthrough")
|
|
var reqDumpFile, respDumpFile string
|
|
err = filepath.Walk(passthroughDir, func(path string, info os.FileInfo, err error) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if info.IsDir() {
|
|
return nil
|
|
}
|
|
if strings.HasSuffix(path, apidump.SuffixRequest) {
|
|
reqDumpFile = path
|
|
} else if strings.HasSuffix(path, apidump.SuffixResponse) {
|
|
respDumpFile = path
|
|
}
|
|
return nil
|
|
})
|
|
require.NoError(t, err, "walking failed: %v", err)
|
|
|
|
require.NotEmpty(t, reqDumpFile, "request dump file should exist")
|
|
require.FileExists(t, reqDumpFile)
|
|
require.Contains(t, reqDumpFile, osSep+"passthrough"+osSep)
|
|
require.Contains(t, reqDumpFile, tc.expectDumpName)
|
|
|
|
require.NotEmpty(t, respDumpFile, "response dump file should exist")
|
|
require.FileExists(t, respDumpFile)
|
|
require.Contains(t, respDumpFile, osSep+"passthrough"+osSep)
|
|
require.Contains(t, respDumpFile, tc.expectDumpName)
|
|
|
|
// Verify request dump.
|
|
reqDumpData, err := os.ReadFile(reqDumpFile)
|
|
require.NoError(t, err)
|
|
dumpReq, err := http.ReadRequest(bufio.NewReader(bytes.NewReader(reqDumpData)))
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.MethodGet, dumpReq.Method)
|
|
|
|
// Verify response dump.
|
|
respDumpData, err := os.ReadFile(respDumpFile)
|
|
require.NoError(t, err)
|
|
dumpResp, err := http.ReadResponse(bufio.NewReader(bytes.NewReader(respDumpData)), nil)
|
|
require.NoError(t, err)
|
|
defer dumpResp.Body.Close()
|
|
require.Equal(t, http.StatusOK, dumpResp.StatusCode)
|
|
dumpRespBody, err := io.ReadAll(dumpResp.Body)
|
|
require.NoError(t, err)
|
|
require.JSONEq(t, responseBody, string(dumpRespBody))
|
|
})
|
|
}
|
|
}
|