mirror of
https://github.com/coder/coder.git
synced 2026-09-23 22:20:22 +08:00
# Support IAM role assumption for AWS Bedrock in AI Bridge ## Summary Implements https://linear.app/codercom/issue/AIGOV-371/support-dynamic-bedrock-assumerole-across-aws-accounts-for-ai-gateway A Bedrock provider can now be configured with an IAM role to assume. Before calling Bedrock, the gateway assumes that role via STS and signs requests with the resulting temporary credentials. Whether the role lives in the same account or another one is entirely a matter of the role's trust policy. ## Problem Many organizations prohibit long-lived AWS access keys and expect workloads to authenticate through assumed IAM roles instead. A common case is an organization that runs Bedrock across several AWS accounts, one per business unit, and needs each unit's usage billed to its own account by assuming a role there. AI Bridge previously authenticated a Bedrock provider only with static keys or the gateway's own ambient AWS identity, which is shared by every provider, with no way to assume a role. These deployments had no clean path. ## How it works When a provider is configured with a role ARN, the gateway uses its base identity to assume that role via STS and signs Bedrock requests with the temporary credentials it returns. The base identity is whatever the AWS default credential chain resolves, IRSA, EKS Pod Identity, EC2 Instance Profile, or static keys. Credentials are resolved once when the provider is set up and are then cached and rotated, so individual requests are served from the cache rather than triggering a new STS call. A deployment that needs several roles configures several providers, each pointing at its own role. ## Configuration The role ARN is part of the Bedrock provider settings and is set through the AI provider API. It is optional: a provider with no role ARN behaves exactly as before. ## Scope and trade-offs - This PR is backend only. The settings UI for the role ARN ships in a follow-up. - Configuration is not exposed through environment variables. Environment-based provider configuration is being phased out in favor of database-managed providers, so the role ARN is intentionally database and API only. Follow-up PR: https://github.com/coder/coder/pull/26578
141 lines
4.1 KiB
Go
141 lines
4.1 KiB
Go
package intercept
|
|
|
|
import (
|
|
"context"
|
|
|
|
"cdr.dev/slog/v3"
|
|
"github.com/coder/coder/v2/aibridge/keypool"
|
|
"github.com/coder/coder/v2/aibridge/utils"
|
|
)
|
|
|
|
// CredentialKind identifies how a request was authenticated.
|
|
// Keep in sync with the credential_kind enum in coderd's database.
|
|
type CredentialKind string
|
|
|
|
const (
|
|
CredentialKindCentralized CredentialKind = "centralized"
|
|
CredentialKindBYOK CredentialKind = "byok"
|
|
)
|
|
|
|
// Auth header names shared by providers (which set them on resolved
|
|
// credentials) and interceptors (which present credentials under them).
|
|
const (
|
|
AuthHeaderXAPIKey = "X-Api-Key" //nolint:gosec // G101 false positive: HTTP header name, not a credential.
|
|
AuthHeaderAuthorization = "Authorization"
|
|
)
|
|
|
|
// Hint placeholders for credentials with no static key value to mask: a pool
|
|
// before failover selects a key, and a key resolved dynamically at request time.
|
|
const (
|
|
hintFailoverKey = "<failover key>"
|
|
hintBedrockChainKey = "<aws chain>"
|
|
)
|
|
|
|
// Credential is the per-request upstream authentication for an interception:
|
|
// - BYOK: a user-supplied secret.
|
|
// - Bedrock: AWS Bedrock credentials, used to sign requests.
|
|
// - CentralizedPool: a provider-managed key pool with failover.
|
|
type Credential interface {
|
|
Kind() CredentialKind
|
|
// AuthHeader is the header carrying this request's credential, or empty when
|
|
// the credential is not carried in a header.
|
|
AuthHeader() string
|
|
// Hint is a masked, identifiable fragment of the credential.
|
|
Hint() string
|
|
// Length is the length of the credential value.
|
|
Length() int
|
|
}
|
|
|
|
// BYOK authenticates with a single user-supplied secret.
|
|
type BYOK struct {
|
|
Secret string
|
|
Header string
|
|
}
|
|
|
|
func (BYOK) Kind() CredentialKind { return CredentialKindBYOK }
|
|
func (b BYOK) AuthHeader() string { return b.Header }
|
|
func (b BYOK) Hint() string { return utils.MaskSecret(b.Secret) }
|
|
func (b BYOK) Length() int { return len(b.Secret) }
|
|
|
|
// Bedrock authenticates with AWS Bedrock: requests are signed (so there is no
|
|
// auth header) using either static credentials (when an access key is set) or
|
|
// the AWS default credential chain. There is no key pool or failover.
|
|
type Bedrock struct {
|
|
AccessKey string
|
|
}
|
|
|
|
func (Bedrock) Kind() CredentialKind { return CredentialKindCentralized }
|
|
func (Bedrock) AuthHeader() string { return "" }
|
|
func (b Bedrock) Length() int { return len(b.AccessKey) }
|
|
|
|
func (b Bedrock) Hint() string {
|
|
if b.AccessKey == "" {
|
|
return hintBedrockChainKey
|
|
}
|
|
return utils.MaskSecret(b.AccessKey)
|
|
}
|
|
|
|
// CentralizedPool authenticates with a provider-managed key pool and fails over
|
|
// across keys.
|
|
type CentralizedPool struct {
|
|
Pool *keypool.Pool
|
|
Header string
|
|
// currentKey is the key most recently handed out by NextKey, nil until the first call.
|
|
currentKey *keypool.Key
|
|
}
|
|
|
|
func (*CentralizedPool) Kind() CredentialKind { return CredentialKindCentralized }
|
|
func (c *CentralizedPool) AuthHeader() string { return c.Header }
|
|
|
|
func (c *CentralizedPool) Hint() string {
|
|
if c.currentKey != nil {
|
|
return c.currentKey.Hint()
|
|
}
|
|
return hintFailoverKey
|
|
}
|
|
|
|
func (c *CentralizedPool) Length() int {
|
|
if c.currentKey != nil {
|
|
return c.currentKey.Length()
|
|
}
|
|
return 0
|
|
}
|
|
|
|
// NextKey advances the failover walker and records the selected key as the one
|
|
// in use.
|
|
func (c *CentralizedPool) NextKey(w *keypool.Walker) (*keypool.Key, *keypool.Error) {
|
|
key, err := w.Next()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
c.currentKey = key
|
|
return key, nil
|
|
}
|
|
|
|
var (
|
|
_ Credential = BYOK{}
|
|
_ Credential = Bedrock{}
|
|
_ Credential = &CentralizedPool{}
|
|
)
|
|
|
|
// AsBYOK reports whether c is a BYOK credential and returns it if so.
|
|
func AsBYOK(c Credential) (BYOK, bool) {
|
|
b, ok := c.(BYOK)
|
|
return b, ok
|
|
}
|
|
|
|
// AsCentralizedPool reports whether c is a key-pool credential that fails over,
|
|
// and returns it if so.
|
|
func AsCentralizedPool(c Credential) (*CentralizedPool, bool) {
|
|
pool, ok := c.(*CentralizedPool)
|
|
return pool, ok
|
|
}
|
|
|
|
// WithCredentialInfo returns a context carrying the credential hint and length.
|
|
func WithCredentialInfo(ctx context.Context, cred Credential) context.Context {
|
|
return slog.With(ctx,
|
|
slog.F("credential_hint", cred.Hint()),
|
|
slog.F("credential_length", cred.Length()),
|
|
)
|
|
}
|