mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
> Mux is working on behalf of Mike. ## Summary Add a per-user synthetic API key for chatd AI Gateway attribution. Chatd resolves the key from the chat owner, extends it before expiry, and discards the generated bearer token so the key is never a usable credential. There is no mapping table. The key is resolved from `api_keys` by a deterministic token name (`chatd_<owner_id>_session_token`), mirroring the provisionerd session token model, with three deltas that chatd needs: - **Login type guard**: token names are unvalidated user input, so a user can create a bearer token with the colliding name. The lookup excludes `login_type = 'token'` rows, so chatd never picks up (or extends) a real user token. Synthetic keys are minted with the owner's login type, which is never `token`. - **In-place expiry extension instead of delete-and-reinsert**: chat generations have no stop boundary, and an in-flight generation may have already delegated the current key ID to aibridged. Extending `expires_at` keeps the key ID stable forever. - **Advisory-lock mint**: the unique index on token names is partial (`WHERE login_type = 'token'`), so nothing DB-enforces uniqueness for synthetic keys. A per-user advisory lock serializes concurrent mints. Keys carry a minimal scope (`api_key:read`) as defense in depth; the delegated gateway path never evaluates scopes and the secret is discarded at mint. Migration 000544 removes the foreign keys from the legacy message and queue `api_key_id` columns while chatd continues stamping them for rolling compatibility. Stale IDs are tolerated because routing uses `chats.owner_id`. Individual key deletion, delete-all, and password reset remove the key without changing chat history or queue versions, and the next lookup remints it. Suspension does not delete the key; delegated gateway authorization rejects inactive users at request time. This is the first PR in a three-PR rollout and must be fully deployed before #27171. Refs https://linear.app/codercom/issue/CODAGT-561/maintain-synthetic-api-key-per-user-per-chat
116 lines
3.9 KiB
Go
116 lines
3.9 KiB
Go
package chatd
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"golang.org/x/xerrors"
|
|
|
|
"github.com/coder/coder/v2/coderd/apikey"
|
|
"github.com/coder/coder/v2/coderd/database"
|
|
"github.com/coder/coder/v2/coderd/database/dbauthz"
|
|
)
|
|
|
|
const (
|
|
syntheticAPIKeyLifetime = 30 * 24 * time.Hour
|
|
syntheticAPIKeyRenewMargin = 24 * time.Hour
|
|
)
|
|
|
|
// GatewayTokenName returns the deterministic token name of the synthetic
|
|
// gateway key for a user. The name is the lookup key: no mapping table exists,
|
|
// so attribution resolves the key by (user_id, token_name, login_type !=
|
|
// 'token').
|
|
func GatewayTokenName(ownerID uuid.UUID) string {
|
|
return fmt.Sprintf("chatd_%s_session_token", ownerID)
|
|
}
|
|
|
|
// ensureSyntheticAPIKeyID returns the ID of the synthetic gateway key for the
|
|
// given user, minting or extending it as needed. The key ID is stable for the
|
|
// lifetime of the user: near-expiry keys are extended in place rather than
|
|
// replaced, because an in-flight generation may have already delegated the
|
|
// current key ID to the gateway.
|
|
func (p *Server) ensureSyntheticAPIKeyID(ctx context.Context, ownerID uuid.UUID) (string, error) {
|
|
ctx = dbauthz.AsChatdKeyMinter(ctx, ownerID)
|
|
key, err := p.db.GetChatGatewayAPIKey(ctx, database.GetChatGatewayAPIKeyParams{
|
|
UserID: ownerID,
|
|
TokenName: GatewayTokenName(ownerID),
|
|
})
|
|
switch {
|
|
case err == nil && key.ExpiresAt.After(p.clock.Now().Add(syntheticAPIKeyRenewMargin)):
|
|
return key.ID, nil
|
|
case err != nil && !xerrors.Is(err, sql.ErrNoRows):
|
|
return "", xerrors.Errorf("get synthetic API key: %w", err)
|
|
}
|
|
return p.mintSyntheticAPIKey(ctx, ownerID)
|
|
}
|
|
|
|
// mintSyntheticAPIKey extends or mints the synthetic gateway key under a
|
|
// per-user advisory lock. The lock serializes concurrent mints because the
|
|
// partial unique index on token names only covers login_type 'token' rows, so
|
|
// nothing else prevents duplicate synthetic keys.
|
|
func (p *Server) mintSyntheticAPIKey(ctx context.Context, ownerID uuid.UUID) (string, error) {
|
|
tokenName := GatewayTokenName(ownerID)
|
|
var keyID string
|
|
err := p.db.InTx(func(tx database.Store) error {
|
|
err := tx.AcquireLock(ctx, database.GenLockID("chatd_gateway_key:"+ownerID.String()))
|
|
if err != nil {
|
|
return xerrors.Errorf("acquire chat gateway key lock: %w", err)
|
|
}
|
|
key, err := tx.GetChatGatewayAPIKey(ctx, database.GetChatGatewayAPIKeyParams{
|
|
UserID: ownerID,
|
|
TokenName: tokenName,
|
|
})
|
|
if err == nil {
|
|
keyID = key.ID
|
|
if key.ExpiresAt.After(p.clock.Now().Add(syntheticAPIKeyRenewMargin)) {
|
|
return nil
|
|
}
|
|
err = tx.UpdateAPIKeyByID(ctx, database.UpdateAPIKeyByIDParams{
|
|
ID: key.ID,
|
|
LastUsed: key.LastUsed,
|
|
ExpiresAt: p.clock.Now().Add(syntheticAPIKeyLifetime),
|
|
IPAddress: key.IPAddress,
|
|
})
|
|
if err != nil {
|
|
return xerrors.Errorf("extend synthetic API key: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
if !xerrors.Is(err, sql.ErrNoRows) {
|
|
return xerrors.Errorf("get synthetic API key: %w", err)
|
|
}
|
|
|
|
owner, err := tx.GetUserForChatSyntheticAPIKeyByID(ctx, ownerID)
|
|
if err != nil {
|
|
return xerrors.Errorf("get synthetic API key owner: %w", err)
|
|
}
|
|
params, _, err := apikey.Generate(apikey.CreateParams{
|
|
UserID: ownerID,
|
|
LoginType: owner.LoginType,
|
|
ExpiresAt: p.clock.Now().Add(syntheticAPIKeyLifetime),
|
|
LifetimeSeconds: int64(syntheticAPIKeyLifetime.Seconds()),
|
|
TokenName: tokenName,
|
|
// The key only attributes gateway requests; the secret is
|
|
// discarded, so it is never usable as a bearer credential. The
|
|
// minimal scope is defense in depth on top of that.
|
|
Scopes: database.APIKeyScopes{database.ApiKeyScopeApiKeyRead},
|
|
})
|
|
if err != nil {
|
|
return xerrors.Errorf("generate synthetic API key: %w", err)
|
|
}
|
|
inserted, err := tx.InsertAPIKey(ctx, params)
|
|
if err != nil {
|
|
return xerrors.Errorf("insert synthetic API key: %w", err)
|
|
}
|
|
keyID = inserted.ID
|
|
return nil
|
|
}, nil)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return keyID, nil
|
|
}
|