mirror of
https://github.com/coder/coder.git
synced 2026-10-16 14:48:56 +08:00
Michael Suchacz
0702372dcf
Adds a `frontend-deep-review` agent skill and tells agents to run it and fix its findings whenever they modify frontend code. The skill reviews a `site/` diff with eight parallel read-only reviewer roles (simplicity, comments, tests and stories, React patterns, reuse, styling and a11y, types and naming, data flow). Each role owns numbered checkpoints distilled from 671 human inline review comments on `site/` PRs between April and September 2026. It complements the existing `frontend-review` FE1 to FE10 gate rather than replacing it. Where a checkpoint conflicts with the root `AGENTS.md`, `site/AGENTS.md`, or `FRONTEND_PATTERNS.md`, the repository rule wins and the reviewer reports the conflict. To review someone else's PR, the skill does not check out the branch, so the author's Git hooks never run. Instead it pins the head and base SHAs, reads the PR only as Git objects, reads the rules at the base branch tip, and treats the PR's text and file names as data. Changes: - `.claude/skills/frontend-deep-review/`: `SKILL.md`, `reviewer-prompt.md`, and eight `roles/*.md` checkpoint files, symlinked from `.agents/skills/` like `frontend-review`. - `AGENTS.md` and `site/AGENTS.md`: run the skill for frontend changes and fix `blocking` and `should-fix` findings before handoff. - `.claude/skills/frontend-review/SKILL.md`: points to the new skill after the FE audit passes. The published version drops reviewer names, verbatim quoted comments, PR references, per-checkpoint comment counts, and the raw comment dataset from the internal original, keeping only the checkpoints and their fixes. The helpers, files, and lint rules a checkpoint recommends or cites as a correct example exist on `main`. Identifiers inside a checkpoint's examples of what to flag come from past reviews, and some have since been renamed or removed; `SKILL.md` and the reviewer prompt tell reviewers to match the pattern, not the name. Testing: `make lint/agents lint/markdown lint/emdash`, `markdownlint-cli2` on the skill files, and the pre-commit hook pass. Every file path and identifier the skill cites was checked against `origin/main` with `git grep`; the only misses are those past-review example names and placeholders such as `mockX`. > Xum opened this PR on behalf of Mike.