opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-11-07 21:29:37 +08:00
Code Issues Packages Projects Releases Wiki Activity
12,927 Commits 479 Branches 427 Tags
e94de0bdabcaeed735d468bb6d279d06f8b8b2d1
Commit Graph
12927 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Dean Sheather 528a0686c0 chore: fix deadlock in dbfake and incorrect lock types (#7218) 
I manually went through every single dbfake function and ensured it has
the correct lock type depending on whether it writes or only reads.
There were a surprising amount of methods that had the wrong lock type
(Lock when only reading, or RLock when writing (!!!)).

This also manually fixes every method that acquires a RLock and then
calls a method that also acquires it's own RLock to use noLock methods
instead. You cannot rely on acquiring a RLock twice in the same
goroutine as RWMutex prioritizes any waiting Lock calls.

I tried writing a ruleguard rule for this but because of limitations in
ruleguard it doesn't seem possible.
 2023-04-20 21:53:34 +10:00
Colin Adler 5f5edb18b0 chore(healthcheck): fix DERP test flakes (#7211) 2023-04-19 20:03:05 -05:00
Colin Adler f60b5579a7 chore: remove usage of k8s.io/utils/pointer (#7209) 2023-04-19 15:53:47 -05:00
Mathias Fredriksson c2871e12aa fix(cli/ssh): Avoid connection hang when workspace is stopped (#7201) 
* fix(cli/ssh): Avoid connection hang when workspace is stopped

Two issues are addressed here:
1. We were not detecting disconnects due to waiting for Stdin to close
   (disconnect would only propagate after entering input and failing to
   write to the connection).
2. In other scenarios, where the connection drop is not detected, we now
   also watch workspace status and drop the connection when a workspace
   reaches the stopped state.

Fixes: https://github.com/coder/jetbrains-coder/issues/199

Refs: #6180, #6175
 2023-04-19 21:32:28 +03:00
Marc fff2b1dc90 fix(cli): Fix postgres TDE failing version check (#7203) 2023-04-19 11:59:56 -05:00
Ammar Bandukwala 2b9d12828a cli: add --debug-http flag (#7192) 
This makes it easier to help debug client issues.
 2023-04-19 11:07:53 -05:00
Marcin Tojek f94ac55f02 feat(agent): Expose magicsock metrics (#7183) 
* feat: Expose magicsock metrics

* golden-files
 2023-04-19 09:09:23 +02:00
Colin Adler fbf329fbb7 fix(tailnet): set TCP keepalive idle to 72 hours for SSH conns (#7196) 2023-04-18 17:53:11 -05:00
Colin Adler 57c4de4647 feat(healthcheck): add accessurl check (#7193) 2023-04-18 15:52:00 -05:00
Dean Sheather fa5387ce07 chore: fix make gen (#7190) 2023-04-18 17:56:52 +00:00
Kyle Carberry 888eb238ec fix: use CODER_HTTP_ADDRESS in docker-compose.yml (#7185) 
Fixes #7184.
 2023-04-18 11:44:41 -05:00
Steven Masley 7f041fecd8 test: Enable filter test with cancelled context (#7189) 
* test: Enable filter test with cancelled context

* fixup! test: Enable filter test with cancelled context
 2023-04-18 11:06:10 -05:00
Cian Johnston b26826ee3f chore(docs): update advice for cache dir (#7182) 
* Adds a note in openshift documentation regarding CODER_CACHE_DIRECTORY with readOnlyRootFS=true
 2023-04-18 14:13:45 +01:00
Kyle Carberry 693e5d94bc fix: add global headers to vscodessh command (#7181) 2023-04-18 08:07:10 -05:00
Bruno Quaresma 56bf9cfdbe fix(site): Handle carriage on logs output (#7172) 2023-04-17 20:45:48 +00:00
Colin Adler b44e6e6711 fix(healthcheck): remove t.Parallel() from healthcheck tests (#7174) 2023-04-17 15:01:47 -05:00
Steven MasleyandDean Sheather 658246d5f2 chore: add workspace proxies to the backend (#7032) 
Co-authored-by: Dean Sheather <dean@deansheather.com>
 2023-04-17 19:57:21 +00:00
Kira Pilot dc5e16ae22 feat: add success modal with token value to create token page (#7170) 
* added token success modal

* added a test for new modal
 2023-04-17 11:54:43 -07:00
Bruno Quaresma 76b5deea78 chore(site): Remove template editor out of experimental (#7165) 2023-04-17 14:40:21 -03:00
Ammar Bandukwala 80bf042528 chore(coderd): remove timing check (#7144) 2023-04-17 17:40:02 +00:00
Mathias Fredriksson b3b26a62f2 test(agent/reaper): Fix restructure issue (#7168) 
In #7164 we accidentally removed the "in CI" check, this fixes it.
 2023-04-17 17:39:10 +00:00
Bruno Quaresma bb3b8bab78 fix(site): Reset delete modal data when selected user changes (#7167) 2023-04-17 12:29:08 -05:00
Mathias Fredriksson bf0fed4f3f chore: Update pion/udp and improve parallel/non-parallel tests (#7164) 
* test(all): Improve and fix subtests with parallell/nonparallel parents

* chore: Update pion/udp to fix buffer close
 2023-04-17 20:23:10 +03:00
Ammar BandukwalaandKyle Carberry c6b2861493 feat: allow disabling stun addresses via env (#7066) 
* feat: allow disabling stun addresses via env

Resolves #6791

* Specify a dummy access URL so the tunnel wouldn't start

* Document

---------

Co-authored-by: Kyle Carberry <kyle@carberry.com>
 2023-04-17 17:20:26 +00:00
Cian Johnston 25c1e45930 chore(helm): add unit tests for setting labels / annotations on serviceaccount / deployment / pod (#7156) 
* chore(helm): add unit tests for setting sa annotations

* chore(cli): also add test for labels / annotations / podLabels / podAnnotations
v0.22.2 		2023-04-17 16:49:25 +01:00
Kyle Carberry 26cfc18b74 fix: use proper deployment access setting name (#7162) 2023-04-17 10:01:51 -05:00
Mathias Fredriksson 51841e9e11 test(cli): Fix TestTemplatePush/UseWorkingDir bad use of chdir (#7160) 2023-04-17 17:58:25 +03:00
Bruno Quaresma 53f521aaf9 chore(site): Make requests when offline (#7161) 2023-04-17 14:44:38 +00:00
Muhammad Atif Ali 4061a254a5 docs: fix a broken link in docs/README.md (#7150) 2023-04-17 13:05:12 +00:00
Mathias Fredriksson 8b2aead7f4 test(coderd/rbac): Use static name for tests (#7155) 2023-04-17 12:17:18 +00:00
Bruno Quaresma d639e6b898 feat(site): Ask for missing template variables in the template editor (#7108) 2023-04-17 09:12:28 -03:00
Marcin Tojek c39c0dcc7c fix: select default option value (#7152) 2023-04-17 12:55:28 +02:00
Ammar BandukwalaandMuhammad Atif Ali 285646bf24 docs: disclaim write load for agent metadata (#7048) 
* docs: disclaim write load for agent metadata

* Update docs/templates/agent-metadata.md

Co-authored-by: Muhammad Atif Ali <atif@coder.com>

* Update docs/templates/agent-metadata.md

Co-authored-by: Muhammad Atif Ali <atif@coder.com>

---------

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
v0.22.1 		2023-04-16 05:46:04 +00:00
Kyle Carberry d3356fa48e fix: upgrade terraform in apk (#7146) 2023-04-14 20:10:17 -05:00
Eric Paulsen c37f22ba78 feat(helm): add labels for coder pod (#7139) 
* feat(helm): add labels for coder pod

* feedback & syntax fix

* ordering

* fix: notation
 2023-04-14 18:55:38 +00:00
am009 706326715d fix(docs): fix a wrong word. (#7113) 2023-04-14 18:32:38 +00:00
Ben PotterandMuhammad Atif Ali 9afbd152fc chore: fix one broken link (#7143) 
* fix one broken link

* Fix the hopefully last broken link

---------

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
 2023-04-14 18:28:58 +00:00
Steven Masley 2137db0445 test: Handle Filter flake with ctx errors (#7119) 
* test: Handle Fitler flake with ctx errors
* Add unit test to check filter for proper error
* Correctly return category of errors
 2023-04-14 12:30:35 -05:00
Ammar Bandukwala c87ec484ff docs: restore supportLinks (#7142) 
* docs: restore supportLinks

* fixup! docs: restore supportLinks
 2023-04-14 17:28:34 +00:00
Kyle Carberry 7f12020229 fix: remove irrelevant help info from coder tokens create (#7135) 
The additional text didn't help much, and made it much harder to script around.
 2023-04-14 12:18:01 -05:00
Ammar Bandukwala f36a4a0b07 chore: fix race check for AgentMetadata test (#7141) 2023-04-14 20:02:44 +03:00
Muhammad Atif Ali 0e50afe4cf fix(docs): fix broken docs (#7138) 
* fixing a lot of broken links

* more fixes

* add 0 as valid status codes

https://tools.ietf.org/html/rfc7231#section-6.3.1 --> 0 as status code
 2023-04-14 11:11:51 -05:00
Kira PilotandBrunoQuaresma 9ec16d4454 feat(UI): add workspace restart button (#7137) 
* Refactor primary buttons

* refactor(site): Always show the main actions

* Remove tests that are testes on Storybook

* Fix tests

* Fix keys

* added restart btn

---------

Co-authored-by: BrunoQuaresma <bruno_nonato_quaresma@hotmail.com>
 2023-04-14 08:48:05 -07:00
Bruno Quaresma 7bbbb91df5 refactor(site): Refactor workspace actions (#7124) 2023-04-14 15:28:52 +00:00
Muhammad Atif Ali 9c0f59e3e5 chore: Also check README.md for dead links (#7130) 2023-04-14 14:46:16 +00:00
Muhammad Atif Ali 69797add49 chore: turn on experiments while developing (#7121) 2023-04-14 17:42:03 +03:00
Kyle Carberry 0bbe1562f3 fix: adjust manifest for networking doc (#7136) 2023-04-14 09:36:23 -05:00
Muhammad Atif AliandMathias Fredriksson bb43713d38 fix: VSCode desktop connection (#7120) 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-04-14 17:32:18 +03:00
Marcin Tojek 942aba3a66 feat: expose agent stats via Prometheus endpoint (#7115) 
* WIP

* WIP

* WIP

* Agents

* fix

* 1min

* fix

* WIP

* Test

* docs

* fmt

* Add timer to measure the metrics collection

* Use CachedGaugeVec

* Unit tests

* WIP

* WIP

* db: GetWorkspaceAgentStatsAndLabels

* fmt

* WIP

* gauges

* feat: collect

* fix

* fmt

* minor fixes

* Prometheus flag

* fix

* WIP

* fix tests

* WIP

* fix json

* Rx Tx bytes

* CloseFunc

* fix

* fix

* Fixes

* fix

* fix: IgnoreErrors

* Fix: Windows

* fix

* reflect.DeepEquals
 2023-04-14 16:14:52 +02:00
Mathias Fredriksson e0689456cb fix(scripts): Use gh api to fetch ci logs more reliably (#7133) 2023-04-14 16:29:13 +03:00