mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
chore: remove unnecessary redeclarations in for loops (#18440)
This commit is contained in:
@@ -163,10 +163,7 @@ func TestRenderChart(t *testing.T) {
|
||||
require.NoError(t, err, "failed to build Helm dependencies")
|
||||
|
||||
for _, tc := range testCases {
|
||||
tc := tc
|
||||
|
||||
for _, ns := range namespaces {
|
||||
tc := tc
|
||||
tc.namespace = ns
|
||||
|
||||
t.Run(tc.namespace+"/"+tc.name, func(t *testing.T) {
|
||||
@@ -213,14 +210,12 @@ func TestUpdateGoldenFiles(t *testing.T) {
|
||||
require.NoError(t, err, "failed to build Helm dependencies")
|
||||
|
||||
for _, tc := range testCases {
|
||||
tc := tc
|
||||
if tc.expectedError != "" {
|
||||
t.Logf("skipping test case %q with render error", tc.name)
|
||||
continue
|
||||
}
|
||||
|
||||
for _, ns := range namespaces {
|
||||
tc := tc
|
||||
tc.namespace = ns
|
||||
|
||||
valuesPath := tc.valuesFilePath()
|
||||
|
||||
Reference in New Issue
Block a user