chore: remove unnecessary redeclarations in for loops (#18440)

codersdk/agentsdk/logs_test.go

@@ -168,7 +168,6 @@ func TestStartupLogsWriter_Write(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -253,7 +252,6 @@ func TestStartupLogsSender(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

codersdk/client_internal_test.go

@@ -76,8 +76,6 @@ func TestIsConnectionErr(t *testing.T) {
 	}
 
 	for _, c := range cases {
-		c := c
-
 		t.Run(c.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -298,7 +296,6 @@ func Test_readBodyAsError(t *testing.T) {
 	}
 
 	for _, c := range tests {
-		c := c
 		t.Run(c.name, func(t *testing.T) {
 			t.Parallel()
 

codersdk/deployment_internal_test.go

@@ -28,8 +28,6 @@ func TestRemoveTrailingVersionInfo(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		stripped := removeTrailingVersionInfo(tc.Version)
 		require.Equal(t, tc.ExpectedAfterStrippingInfo, stripped)
 	}

codersdk/deployment_test.go

@@ -196,7 +196,6 @@ func TestSSHConfig_ParseOptions(t *testing.T) {
 	}
 
 	for _, tt := range testCases {
-		tt := tt
 		t.Run(tt.Name, func(t *testing.T) {
 			t.Parallel()
 			c := codersdk.SSHConfig{
@@ -277,7 +276,6 @@ func TestTimezoneOffsets(t *testing.T) {
 	}
 
 	for _, c := range testCases {
-		c := c
 		t.Run(c.Name, func(t *testing.T) {
 			t.Parallel()
 
@@ -524,8 +522,6 @@ func TestFeatureComparison(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
 
@@ -619,8 +615,6 @@ func TestNotificationsCanBeDisabled(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

codersdk/healthsdk/healthsdk_test.go

@@ -148,7 +148,6 @@ func TestSummarize(t *testing.T) {
 			},
 		},
 	} {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			actual := tt.br.Summarize(tt.pfx, tt.docsURL)

codersdk/healthsdk/interfaces_internal_test.go

@@ -160,7 +160,6 @@ func Test_generateInterfacesReport(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			r := generateInterfacesReport(&tc.state)

codersdk/name_test.go

@@ -60,7 +60,6 @@ func TestUsernameValid(t *testing.T) {
 		{"123456789012345678901234567890123123456789012345678901234567890123", false},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.Username, func(t *testing.T) {
 			t.Parallel()
 			valid := codersdk.NameValid(testCase.Username)
@@ -115,7 +114,6 @@ func TestTemplateDisplayNameValid(t *testing.T) {
 		{"12345678901234567890123456789012345678901234567890123456789012345", false},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.Name, func(t *testing.T) {
 			t.Parallel()
 			valid := codersdk.DisplayNameValid(testCase.Name)
@@ -156,7 +154,6 @@ func TestTemplateVersionNameValid(t *testing.T) {
 		{"!!!!1 ?????", false},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.Name, func(t *testing.T) {
 			t.Parallel()
 			valid := codersdk.TemplateVersionNameValid(testCase.Name)
@@ -197,7 +194,6 @@ func TestFrom(t *testing.T) {
 		{"", ""},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.From, func(t *testing.T) {
 			t.Parallel()
 			converted := codersdk.UsernameFrom(testCase.From)
@@ -243,7 +239,6 @@ func TestUserRealNameValid(t *testing.T) {
 		{strings.Repeat("a", 129), false},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.Name, func(t *testing.T) {
 			t.Parallel()
 			err := codersdk.UserRealNameValid(testCase.Name)
@@ -277,7 +272,6 @@ func TestGroupNameValid(t *testing.T) {
 		{random256String, false},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.Name, func(t *testing.T) {
 			t.Parallel()
 			err := codersdk.GroupNameValid(testCase.Name)

codersdk/pagination_test.go

@@ -42,7 +42,6 @@ func TestPagination_asRequestOption(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

codersdk/richparameters_test.go

@@ -322,7 +322,6 @@ func TestRichParameterValidation(t *testing.T) {
 		}
 
 		for _, tc := range tests {
-			tc := tc
 			t.Run(tc.parameterName+"-"+tc.value, func(t *testing.T) {
 				t.Parallel()
 

codersdk/time_test.go

@@ -47,7 +47,6 @@ func TestNullTime_MarshalJSON(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -104,7 +103,6 @@ func TestNullTime_UnmarshalJSON(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -145,7 +143,6 @@ func TestNullTime_IsZero(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

codersdk/workspacedisplaystatus_internal_test.go

@@ -90,7 +90,6 @@ func TestWorkspaceDisplayStatus(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 			if got := WorkspaceDisplayStatus(tt.jobStatus, tt.transition); got != tt.want {