chore: remove unnecessary redeclarations in for loops (#18440)

coderd/database/db2sdk/db2sdk_test.go

@@ -119,8 +119,6 @@ func TestProvisionerJobStatus(t *testing.T) {
 	org := dbgen.Organization(t, db, database.Organization{})
 
 	for i, tc := range cases {
-		tc := tc
-		i := i
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			// Populate standard fields

coderd/database/dbauthz/customroles_test.go

@@ -46,7 +46,6 @@ func TestInsertCustomRoles(t *testing.T) {
 	merge := func(u ...interface{}) rbac.Roles {
 		all := make([]rbac.Role, 0)
 		for _, v := range u {
-			v := v
 			switch t := v.(type) {
 			case rbac.Role:
 				all = append(all, t)
@@ -201,8 +200,6 @@ func TestInsertCustomRoles(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			db := dbmem.New()

coderd/database/dbauthz/groupsauth_test.go

@@ -135,7 +135,6 @@ func TestGroupsAuth(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
 

coderd/database/dbauthz/setup_test.go

@@ -458,7 +458,6 @@ type AssertRBAC struct {
 func values(ins ...any) []reflect.Value {
 	out := make([]reflect.Value, 0)
 	for _, input := range ins {
-		input := input
 		out = append(out, reflect.ValueOf(input))
 	}
 	return out

coderd/database/dbmem/dbmem.go

@@ -1811,7 +1811,6 @@ func (q *FakeQuerier) CustomRoles(_ context.Context, arg database.CustomRolesPar
 
 	found := make([]database.CustomRole, 0)
 	for _, role := range q.data.customRoles {
-		role := role
 		if len(arg.LookupRoles) > 0 {
 			if !slices.ContainsFunc(arg.LookupRoles, func(pair database.NameOrganizationPair) bool {
 				if pair.Name != role.Name {
@@ -2920,7 +2919,6 @@ func (q *FakeQuerier) GetAuthorizationUserRoles(_ context.Context, userID uuid.U
 	roles := make([]string, 0)
 	for _, u := range q.users {
 		if u.ID == userID {
-			u := u
 			roles = append(roles, u.RBACRoles...)
 			roles = append(roles, "member")
 			user = &u
@@ -8123,7 +8121,6 @@ func (q *FakeQuerier) GetWorkspaceByOwnerIDAndName(_ context.Context, arg databa
 
 	var found *database.WorkspaceTable
 	for _, workspace := range q.workspaces {
-		workspace := workspace
 		if workspace.OwnerID != arg.OwnerID {
 			continue
 		}
@@ -8181,7 +8178,6 @@ func (q *FakeQuerier) GetWorkspaceByWorkspaceAppID(_ context.Context, workspaceA
 	defer q.mutex.RUnlock()
 
 	for _, workspaceApp := range q.workspaceApps {
-		workspaceApp := workspaceApp
 		if workspaceApp.ID == workspaceAppID {
 			return q.getWorkspaceByAgentIDNoLock(context.Background(), workspaceApp.AgentID)
 		}
@@ -10424,7 +10420,6 @@ func (q *FakeQuerier) OrganizationMembers(_ context.Context, arg database.Organi
 			continue
 		}
 
-		organizationMember := organizationMember
 		user, _ := q.getUserByIDNoLock(organizationMember.UserID)
 		tmp = append(tmp, database.OrganizationMembersRow{
 			OrganizationMember: organizationMember,

coderd/database/dbmem/dbmem_test.go

@@ -188,7 +188,6 @@ func TestProxyByHostname(t *testing.T) {
 	}
 
 	for _, c := range cases {
-		c := c
 		t.Run(c.name, func(t *testing.T) {
 			t.Parallel()
 

coderd/database/migrations/migrate_test.go

@@ -288,8 +288,6 @@ func TestMigrateUpWithFixtures(t *testing.T) {
 	})
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

coderd/database/querier_test.go

@@ -1156,7 +1156,6 @@ func TestProxyByHostname(t *testing.T) {
 	}
 
 	for _, c := range cases {
-		c := c
 		t.Run(c.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -1394,7 +1393,6 @@ func TestGetUsers_IncludeSystem(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -1862,8 +1860,6 @@ func TestReadCustomRoles(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		t.Run(tc.Name, func(t *testing.T) {
 			t.Parallel()
 
@@ -2506,7 +2502,6 @@ func TestGetProvisionerJobsByIDsWithQueuePosition(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // Capture loop variable to avoid data races
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			db, _ := dbtestutil.NewDB(t)
@@ -2947,7 +2942,6 @@ func TestGetUserStatusCounts(t *testing.T) {
 	}
 
 	for _, tz := range timezones {
-		tz := tz
 		t.Run(tz, func(t *testing.T) {
 			t.Parallel()
 
@@ -2995,7 +2989,6 @@ func TestGetUserStatusCounts(t *testing.T) {
 				}
 
 				for _, tc := range testCases {
-					tc := tc
 					t.Run(tc.name, func(t *testing.T) {
 						t.Parallel()
 						db, _ := dbtestutil.NewDB(t)
@@ -3163,7 +3156,6 @@ func TestGetUserStatusCounts(t *testing.T) {
 				}
 
 				for _, tc := range testCases {
-					tc := tc
 					t.Run(tc.name, func(t *testing.T) {
 						t.Parallel()
 						db, _ := dbtestutil.NewDB(t)
@@ -3296,7 +3288,6 @@ func TestGetUserStatusCounts(t *testing.T) {
 				}
 
 				for _, tc := range testCases {
-					tc := tc
 					t.Run(tc.name, func(t *testing.T) {
 						t.Parallel()