chore: remove unnecessary redeclarations in for loops (#18440)

cli/cliui/agent_test.go

@@ -369,7 +369,6 @@ func TestAgent(t *testing.T) {
 			wantErr: true,
 		},
 	} {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -648,7 +647,6 @@ func TestPeerDiagnostics(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			r, w := io.Pipe()
@@ -852,7 +850,6 @@ func TestConnDiagnostics(t *testing.T) {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 			r, w := io.Pipe()

cli/cliui/provisionerjob_test.go

@@ -124,8 +124,6 @@ func TestProvisionerJob(t *testing.T) {
 		}
 
 		for _, tc := range tests {
-			tc := tc
-
 			t.Run(tc.name, func(t *testing.T) {
 				t.Parallel()
 

cli/cliui/resources_internal_test.go

@@ -40,7 +40,6 @@ func TestRenderAgentVersion(t *testing.T) {
 		},
 	}
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.name, func(t *testing.T) {
 			t.Parallel()
 			actual := renderAgentVersion(testCase.agentVersion, testCase.serverVersion)

cli/cliui/table_test.go

@@ -169,7 +169,6 @@ foo   <nil>      10  [a, b, c]  foo1               11  foo2        12         fo
 		// Test with pointer values.
 		inPtr := make([]*tableTest1, len(in))
 		for i, v := range in {
-			v := v
 			inPtr[i] = &v
 		}
 		out, err = cliui.DisplayTable(inPtr, "", nil)