From f517e5f3e055df96b4c3c1612fd5e574e7299ab9 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Tue, 31 Dec 2024 16:39:19 +0200 Subject: [PATCH] fix(enterprise/cli): add missing defer close of closer funcs (#15986) --- enterprise/cli/proxyserver.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/enterprise/cli/proxyserver.go b/enterprise/cli/proxyserver.go index 758c52a8ff..9e10048146 100644 --- a/enterprise/cli/proxyserver.go +++ b/enterprise/cli/proxyserver.go @@ -34,15 +34,15 @@ import ( "github.com/coder/serpent" ) -type closers []func() +type closerFuncs []func() -func (c closers) Close() { +func (c closerFuncs) Close() { for _, closeF := range c { closeF() } } -func (c *closers) Add(f func()) { +func (c *closerFuncs) Add(f func()) { *c = append(*c, f) } @@ -113,7 +113,8 @@ func (r *RootCmd) proxyServer() *serpent.Command { serpent.RequireNArgs(0), ), Handler: func(inv *serpent.Invocation) error { - var closers closers + var closers closerFuncs + defer closers.Close() // Main command context for managing cancellation of running // services. ctx, topCancel := context.WithCancel(inv.Context())