mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
fix: limit calls to GetWorkspaceAgentByID in agentapi (#23015)
We currently call GetWorkspaceAgentByID millions of times at scale unnecessarily. This PR embeds immutable fields into the relevant services instead of fetching for them every time. resolves https://github.com/coder/scaletest/issues/84 Confirmed with a 10k scaletest that this changeset takes the query from 10M+ queries down to 39k
This commit is contained in:
@@ -81,12 +81,9 @@ func TestSubAgentAPI(t *testing.T) {
|
||||
return &agentapi.SubAgentAPI{
|
||||
OwnerID: user.ID,
|
||||
OrganizationID: org.ID,
|
||||
AgentID: agent.ID,
|
||||
AgentFn: func(context.Context) (database.WorkspaceAgent, error) {
|
||||
return agent, nil
|
||||
},
|
||||
Clock: clock,
|
||||
Database: dbauthz.New(db, auth, logger, accessControlStore),
|
||||
AgentFn: func(ctx context.Context) (database.WorkspaceAgent, error) { return agent, nil },
|
||||
Clock: clock,
|
||||
Database: dbauthz.New(db, auth, logger, accessControlStore),
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user