chore: remove dynamic-parameters experiment (#18290)

Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>
Co-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Co-authored-by: Steven Masley <stevenmasley@gmail.com>

coderd/wsbuilder/wsbuilder.go

@@ -1042,8 +1042,15 @@ func (b *Builder) checkRunningBuild() error {
 }
 
 func (b *Builder) usingDynamicParameters() bool {
-	if !b.experiments.Enabled(codersdk.ExperimentDynamicParameters) {
-		// Experiment required
+	if b.dynamicParametersEnabled != nil {
+		return *b.dynamicParametersEnabled
+	}
+
+	tpl, err := b.getTemplate()
+	if err != nil {
+		return false // Let another part of the code get this error
+	}
+	if tpl.UseClassicParameterFlow {
 		return false
 	}
 
@@ -1056,15 +1063,7 @@ func (b *Builder) usingDynamicParameters() bool {
 		return false
 	}
 
-	if b.dynamicParametersEnabled != nil {
-		return *b.dynamicParametersEnabled
-	}
-
-	tpl, err := b.getTemplate()
-	if err != nil {
-		return false // Let another part of the code get this error
-	}
-	return !tpl.UseClassicParameterFlow
+	return true
 }
 
 func ProvisionerVersionSupportsDynamicParameters(version string) bool {

coderd/wsbuilder/wsbuilder_test.go

@@ -894,10 +894,11 @@ func withTemplate(mTx *dbmock.MockStore) {
 	mTx.EXPECT().GetTemplateByID(gomock.Any(), templateID).
 		Times(1).
 		Return(database.Template{
-			ID:              templateID,
-			OrganizationID:  orgID,
-			Provisioner:     database.ProvisionerTypeTerraform,
-			ActiveVersionID: activeVersionID,
+			ID:                      templateID,
+			OrganizationID:          orgID,
+			Provisioner:             database.ProvisionerTypeTerraform,
+			ActiveVersionID:         activeVersionID,
+			UseClassicParameterFlow: true,
 		}, nil)
 }