From eeab33b1c3928a825e179a3a5ccd14c1678a3934 Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Tue, 3 Oct 2023 09:29:34 -0500 Subject: [PATCH] fix: do not require `client_secret` for external auth providers (#10016) Device-based auth does not need a client secret. --- coderd/externalauth/externalauth.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/coderd/externalauth/externalauth.go b/coderd/externalauth/externalauth.go index 4db6ec695c..34bd7e9253 100644 --- a/coderd/externalauth/externalauth.go +++ b/coderd/externalauth/externalauth.go @@ -383,9 +383,6 @@ func ConvertConfig(entries []codersdk.ExternalAuthConfig, accessURL *url.URL) ([ if entry.ClientID == "" { return nil, xerrors.Errorf("%q external auth provider: client_id must be provided", entry.ID) } - if entry.ClientSecret == "" { - return nil, xerrors.Errorf("%q external auth provider: client_secret must be provided", entry.ID) - } _, exists := ids[entry.ID] if exists {