From dec6d310a89431b7e14b76481352edb4c33e5116 Mon Sep 17 00:00:00 2001 From: Dean Sheather Date: Tue, 28 Oct 2025 17:19:52 +1100 Subject: [PATCH] fix: avoid bad switch statement in license code (#20509) Noticed this while trying to investigate a flake. Relates to https://github.com/coder/internal/issues/788 --- enterprise/coderd/license/license.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/enterprise/coderd/license/license.go b/enterprise/coderd/license/license.go index 7fbac30fae..e66915f221 100644 --- a/enterprise/coderd/license/license.go +++ b/enterprise/coderd/license/license.go @@ -490,15 +490,15 @@ func LicensesEntitlements( if featureArguments.ManagedAgentCountFn != nil { managedAgentCount, err = featureArguments.ManagedAgentCountFn(ctx, agentLimit.UsagePeriod.Start, agentLimit.UsagePeriod.End) } - switch { - case xerrors.Is(err, context.Canceled) || xerrors.Is(err, context.DeadlineExceeded): + if xerrors.Is(err, context.Canceled) || xerrors.Is(err, context.DeadlineExceeded) { // If the context is canceled, we want to bail the entire // LicensesEntitlements call. return entitlements, xerrors.Errorf("get managed agent count: %w", err) - case err != nil: - entitlements.Errors = append(entitlements.Errors, - fmt.Sprintf("Error getting managed agent count: %s", err.Error())) - default: + } + if err != nil { + entitlements.Errors = append(entitlements.Errors, fmt.Sprintf("Error getting managed agent count: %s", err.Error())) + // no return + } else { agentLimit.Actual = &managedAgentCount entitlements.AddFeature(codersdk.FeatureManagedAgentLimit, agentLimit)