From ddb27990099d422af67f81ffbf091b2ff27d8daf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?McKayla=20=E3=81=AF=E3=81=AA?= Date: Mon, 10 Aug 2026 14:15:57 -0600 Subject: [PATCH] fix: hide the favorite button for workspaces you don't own (#28000) --- .../WorkspaceActions/WorkspaceActions.stories.tsx | 9 +++++++++ .../WorkspaceActions/WorkspaceActions.tsx | 13 ++++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx index 0ec276605c..1ffca1a677 100644 --- a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.stories.tsx @@ -211,6 +211,15 @@ export const CancelHiddenForUser: Story = { }, }; +export const FavoriteHiddenForNonOwner: Story = { + args: { + workspace: Mocks.MockWorkspace, + }, + parameters: { + user: Mocks.MockUserMember, + }, +}; + export const OpenDownloadLogs: Story = { args: { workspace: Mocks.MockWorkspace, diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx index 72ab7e6443..d94ec53bbc 100644 --- a/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx +++ b/site/src/pages/WorkspacePage/WorkspaceActions/WorkspaceActions.tsx @@ -178,11 +178,14 @@ export const WorkspaceActions: FC = ({ {canCancel && } - + {/* Only the owner can favorite a workspace. */} + {user.id === workspace.owner_id && ( + + )} {permissions.shareWorkspace && (