From d8fcb062bc898a61897a1562c0d9c2acbad89209 Mon Sep 17 00:00:00 2001 From: Spike Curtis Date: Mon, 14 Apr 2025 16:15:06 +0400 Subject: [PATCH] chore: add logging for coderdtest server lifecycle (#17376) regarding https://github.com/coder/internal/issues/581 Adds logging around the lifecyle of the coderd HTTP server. --- coderd/coderdtest/coderdtest.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index 0f0a99807a..dbf1f62abf 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -421,6 +421,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can handler.ServeHTTP(w, r) } })) + t.Logf("coderdtest server listening on %s", srv.Listener.Addr().String()) srv.Config.BaseContext = func(_ net.Listener) context.Context { return ctx } @@ -433,7 +434,12 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can } else { srv.Start() } - t.Cleanup(srv.Close) + t.Logf("coderdtest server started on %s", srv.URL) + t.Cleanup(func() { + t.Logf("closing coderdtest server on %s", srv.Listener.Addr().String()) + srv.Close() + t.Logf("closed coderdtest server on %s", srv.Listener.Addr().String()) + }) tcpAddr, ok := srv.Listener.Addr().(*net.TCPAddr) require.True(t, ok)