From d415964b9f8699315979f1966c4d793fe5d99cb6 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Wed, 3 Sep 2025 09:23:37 +0200 Subject: [PATCH] fix: show popup on successful template build (#19674) Fixes: https://github.com/coder/coder/issues/18364 --- .../TemplateVersionEditorPage/TemplateVersionEditor.tsx | 5 ++++- .../TemplateVersionEditorPage.test.tsx | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx index 740f5e42ab..79c990544b 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx @@ -21,7 +21,7 @@ import { TopbarDivider, TopbarIconButton, } from "components/FullPageLayout/Topbar"; -import { displayError } from "components/GlobalSnackbar/utils"; +import { displayError, displaySuccess } from "components/GlobalSnackbar/utils"; import { Loader } from "components/Loader/Loader"; import { ChevronLeftIcon, @@ -185,6 +185,9 @@ export const TemplateVersionEditor: FC = ({ templateVersion.job.status === "succeeded" ) { setDirty(false); + displaySuccess( + `Template version "${previousVersion.current.name}" built successfully.`, + ); } previousVersion.current = templateVersion; }, [templateVersion]); diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx index 066433f541..f4db52b2ef 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx @@ -104,6 +104,9 @@ const buildTemplateVersion = async ( }); await user.click(buildButton); await within(topbar).findByText("Success"); + await screen.findByText( + `Template version "${templateVersion.name}" built successfully.`, + ); }; test("Use custom name, message and set it as active when publishing", async () => {