opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(helm): disable liveness probes by default, allow all probe settings (#21789)

Browse Source 
Liveness checks are currently causing pods to be killed during
long-running migrations.

They are generally not advisable for our workloads; if a pod becomes
unresponsive we _need_ to know about it (due to a deadlock, etc) and not
paper over the issue by killing the pod.

I've also made all probe settings configurable.

---------

Signed-off-by: Danny Kopping <danny@coder.com>
This commit is contained in:
Danny Kopping
2026-02-02 13:33:49 +00:00
committed by GitHub
parent bcc57632dd
commit d0c67ccb88
62 changed files with 904 additions and 321 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/install/kubernetes.md
-9
View File
@@ -258,15 +258,6 @@ reference, and not all security requirements may apply to your business.
- Both the control plane and workspaces set resource request/limits by
default.
7. **All Kubernetes objects must define liveness and readiness probes**
- Control plane - The control plane Deployment has liveness and readiness
probes
[configured by default here](https://github.com/coder/coder/blob/f57ce97b5aadd825ddb9a9a129bb823a3725252b/helm/coder/templates/_coder.tpl#L98-L107).
- Workspaces - the Kubernetes Deployment template does not configure
liveness/readiness probes for the workspace, but this can be added to the
Terraform template, and is supported.
## Load balancing considerations
### AWS