From cd0a2849d0cb32b80b293afbf243308a7a34cab8 Mon Sep 17 00:00:00 2001 From: Bruno Quaresma Date: Fri, 24 Oct 2025 11:56:57 -0300 Subject: [PATCH] fix: fix URL parameter for task (#20463) --- site/src/pages/TaskPage/TaskPage.stories.tsx | 13 +++++++++++-- site/src/pages/TaskPage/TaskPage.tsx | 4 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/site/src/pages/TaskPage/TaskPage.stories.tsx b/site/src/pages/TaskPage/TaskPage.stories.tsx index 730aa1b1734..19003eb6216 100644 --- a/site/src/pages/TaskPage/TaskPage.stories.tsx +++ b/site/src/pages/TaskPage/TaskPage.stories.tsx @@ -72,10 +72,11 @@ const meta: Meta = { reactRouter: reactRouterParameters({ location: { pathParams: { - taskId: MockTasks[0].id, + username: MockTask.owner_name, + taskId: MockTask.id, }, }, - routing: { path: "/tasks/:taskId" }, + routing: { path: "/tasks/:username/:taskId" }, }), }, }; @@ -89,6 +90,14 @@ export const LoadingTask: Story = { () => new Promise(() => {}), ); }, + play: async () => { + await waitFor(() => { + expect(API.experimental.getTask).toHaveBeenCalledWith( + MockTask.owner_name, + MockTask.id, + ); + }); + }, }; export const LoadingWorkspace: Story = { diff --git a/site/src/pages/TaskPage/TaskPage.tsx b/site/src/pages/TaskPage/TaskPage.tsx index f136a16ceb4..9724c09f5d2 100644 --- a/site/src/pages/TaskPage/TaskPage.tsx +++ b/site/src/pages/TaskPage/TaskPage.tsx @@ -55,8 +55,8 @@ const TaskPageLayout: FC = ({ children }) => { }; const TaskPage = () => { - const { task: taskId, username } = useParams() as { - task: string; + const { taskId, username } = useParams() as { + taskId: string; username: string; }; const { data: task, ...taskQuery } = useQuery({