diff --git a/site/e2e/tests/roles.spec.ts b/site/e2e/tests/roles.spec.ts index 0bf80391c0..a1d39c7c42 100644 --- a/site/e2e/tests/roles.spec.ts +++ b/site/e2e/tests/roles.spec.ts @@ -22,10 +22,10 @@ const adminSettings = [ ] as const; async function hasAccessToAdminSettings(page: Page, settings: AdminSetting[]) { - // Organizations and Audit Logs both require a license to be visible + // Audit Logs requires a license to be visible const visibleSettings = license ? settings - : settings.filter((it) => it !== "Organizations" && it !== "Audit Logs"); + : settings.filter((it) => it !== "Audit Logs"); const adminSettingsButton = page.getByRole("button", { name: "Admin settings", }); diff --git a/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx b/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx index fc9ab9baaa..de236e693d 100644 --- a/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx +++ b/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx @@ -30,8 +30,8 @@ export const DeploymentDropdown: FC = ({ if ( !canViewAuditLog && !canViewConnectionLog && - !canViewOrganizations && !canViewDeployment && + !canViewOrganizations && !canViewHealth && !canViewAIBridge ) { @@ -63,7 +63,6 @@ export const DeploymentDropdown: FC = ({ const DeploymentDropdownContent: FC = ({ canViewDeployment, - canViewOrganizations, canViewAuditLog, canViewHealth, canViewConnectionLog, @@ -76,11 +75,9 @@ const DeploymentDropdownContent: FC = ({ Deployment )} - {canViewOrganizations && ( - - Organizations - - )} + + Organizations + {canViewAuditLog && ( Audit Logs diff --git a/site/src/modules/dashboard/Navbar/MobileMenu.tsx b/site/src/modules/dashboard/Navbar/MobileMenu.tsx index a6c7df982a..81822669b0 100644 --- a/site/src/modules/dashboard/Navbar/MobileMenu.tsx +++ b/site/src/modules/dashboard/Navbar/MobileMenu.tsx @@ -203,7 +203,6 @@ const ProxySettingsSub: FC = ({ proxyContextValue }) => { const AdminSettingsSub: FC = ({ canViewDeployment, - canViewOrganizations, canViewAuditLog, canViewConnectionLog, canViewHealth, @@ -235,14 +234,12 @@ const AdminSettingsSub: FC = ({ Deployment )} - {canViewOrganizations && ( - - Organizations - - )} + + Organizations + {canViewAuditLog && ( { + const canvas = within(canvasElement); + await userEvent.click( + canvas.getByRole("button", { name: "Admin settings" }), + ); + }, +}; + export const ForMember: Story = { args: { user: MockUserMember, diff --git a/site/src/pages/OrganizationSettingsPage/OrganizationMembersPage.tsx b/site/src/pages/OrganizationSettingsPage/OrganizationMembersPage.tsx index d887044b0b..be020df108 100644 --- a/site/src/pages/OrganizationSettingsPage/OrganizationMembersPage.tsx +++ b/site/src/pages/OrganizationSettingsPage/OrganizationMembersPage.tsx @@ -102,7 +102,6 @@ const OrganizationMembersPage: FC = () => { error={ membersQuery.error ?? organizationRolesQuery.error ?? - groupsByUserIdQuery.error ?? addMemberMutation.error ?? removeMemberMutation.error ?? updateMemberRolesMutation.error