opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: revert dynamic params as a safe experiment (#17510)

Browse Source
This commit is contained in:
Steven Masley
2025-04-22 16:21:15 +00:00
committed by GitHub
parent 5d97d82422
commit ca38729840
6 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/prometheusmetrics/prometheusmetrics.go
+1 -1
View File
@@ -655,7 +655,7 @@ func Experiments(registerer prometheus.Registerer, active codersdk.Experiments)
return err
}
for _, exp := range codersdk.ExperimentsAll {
for _, exp := range codersdk.ExperimentsSafe {
var val float64
for _, enabled := range active {
if exp == enabled {
coderd/prometheusmetrics/prometheusmetrics_test.go
+4 -4
View File
@@ -612,7 +612,7 @@ func TestAgentStats(t *testing.T) {
func TestExperimentsMetric(t *testing.T) {
t.Parallel()
if len(codersdk.ExperimentsAll) == 0 {
if len(codersdk.ExperimentsSafe) == 0 {
t.Skip("No experiments are currently defined; skipping test.")
}
@@ -624,17 +624,17 @@ func TestExperimentsMetric(t *testing.T) {
{
name: "Enabled experiment is exported in metrics",
experiments: codersdk.Experiments{
codersdk.ExperimentsAll[0],
codersdk.ExperimentsSafe[0],
},
expected: map[codersdk.Experiment]float64{
codersdk.ExperimentsAll[0]: 1,
codersdk.ExperimentsSafe[0]: 1,
},
},
{
name: "Disabled experiment is exported in metrics",
experiments: codersdk.Experiments{},
expected: map[codersdk.Experiment]float64{
codersdk.ExperimentsAll[0]: 0,
codersdk.ExperimentsSafe[0]: 0,
},
},
{