opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: only return group member count for workspace acl (#26206)

Browse Source
This commit is contained in:
Jon Ayers
2026-06-23 11:58:00 -05:00
committed by GitHub
parent 6acf32701e
commit c7ddcce62c
5 changed files with 150 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enterprise/cli/sharing_test.go
+5 -2
View File
@@ -216,14 +216,17 @@ func TestSharingStatus(t *testing.T) {
err = inv.WithContext(ctx).Run()
require.NoError(t, err)
// The ACL endpoint omits group member rosters to avoid leaking member
// PII, so the output lists the group itself rather than its members.
found := false
for _, line := range strings.Split(out.String(), "\n") {
if strings.Contains(line, orgMember.Username) && strings.Contains(line, string(codersdk.WorkspaceRoleUse)) && strings.Contains(line, group.Name) {
if strings.Contains(line, group.Name) && strings.Contains(line, string(codersdk.WorkspaceRoleUse)) {
found = true
break
}
}
assert.True(t, found, "expected to find username %s with role %s in the output: %s", orgMember.Username, codersdk.WorkspaceRoleUse, out.String())
assert.True(t, found, "expected to find group %s with role %s in the output: %s", group.Name, codersdk.WorkspaceRoleUse, out.String())
assert.NotContains(t, out.String(), orgMember.Username, "group member roster must not be exposed in sharing status output")
})
}