opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(coderd): optimize chatdebug (#27129)

Browse Source 
Adds a bund of optimizations to chatdebug:

In `coderd/x/chatd/chatdebug`:
- Adds a benchmark (excluding LLM and database stuff)
- Replaces string concatenation with strings.Builder when accumulating
stream parts (~105,000ns -> ~50,00ns)
- Removes double JSON encode in RecordingTransport (114,000ns ->
64,000ns)

In `coderd/util/strings`:
- Adds a benchmark for Truncate
- Removes unnecessary allocations in Truncate (~110,000ns -> 1,550ns in
truncation case, 1 alloc -> 0 allocs in no truncation case)

> 🤖 Claude helped with this.
This commit is contained in:
Cian Johnston
2026-08-05 11:59:37 +01:00
committed by GitHub
parent 05baba1e63
commit c62079c053
8 changed files with 664 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
coderd/x/chatd/chatdebug/model_normalization_internal_test.go
+45 -10
View File
@@ -132,16 +132,30 @@ func TestNormalizers_SkipTypedNilInterfaceValues(t *testing.T) {
func TestAppendNormalizedStreamContent_PreservesOrderAndCanonicalTypes(t *testing.T) {
t.Parallel()
var content []normalizedContentPart
var (
content []normalizedContentPart
currentText *strings.Builder
currentTextIdx int
)
argBuilders := make(map[string]*strings.Builder)
streamDebugBytes := 0
for _, part := range []fantasy.StreamPart{
{Type: fantasy.StreamPartTypeTextDelta, Delta: "before "},
// "before " and "after" each arrive as two consecutive
// same-type deltas (rather than one) so this also exercises
// accumulating into an already-existing text part across
// multiple appendNormalizedStreamContent calls, not just
// starting a fresh one.
{Type: fantasy.StreamPartTypeTextDelta, Delta: "bef"},
{Type: fantasy.StreamPartTypeTextDelta, Delta: "ore "},
{Type: fantasy.StreamPartTypeToolCall, ID: "call-1", ToolCallName: "search_docs", ToolCallInput: `{"query":"debug"}`},
{Type: fantasy.StreamPartTypeToolResult, ID: "call-1", ToolCallName: "search_docs", ToolCallInput: `{"matches":1}`},
{Type: fantasy.StreamPartTypeTextDelta, Delta: "after"},
{Type: fantasy.StreamPartTypeTextDelta, Delta: "aft"},
{Type: fantasy.StreamPartTypeTextDelta, Delta: "er"},
} {
content = appendNormalizedStreamContent(content, part, &streamDebugBytes)
content, currentText, currentTextIdx = appendNormalizedStreamContent(
content, currentText, currentTextIdx, argBuilders, part, &streamDebugBytes)
}
materializeStreamContent(content, currentText, currentTextIdx, argBuilders)
require.Equal(t, []normalizedContentPart{
{Type: "text", Text: "before "},
@@ -154,7 +168,12 @@ func TestAppendNormalizedStreamContent_PreservesOrderAndCanonicalTypes(t *testin
func TestAppendNormalizedStreamContent_ToolInputAttributionPerCall(t *testing.T) {
t.Parallel()
var content []normalizedContentPart
var (
content []normalizedContentPart
currentText *strings.Builder
currentTextIdx int
)
argBuilders := make(map[string]*strings.Builder)
streamDebugBytes := 0
for _, part := range []fantasy.StreamPart{
{Type: fantasy.StreamPartTypeToolInputStart, ID: "call-a", ToolCallName: "search", Delta: `{"q`},
@@ -164,8 +183,10 @@ func TestAppendNormalizedStreamContent_ToolInputAttributionPerCall(t *testing.T)
{Type: fantasy.StreamPartTypeToolInputDelta, ID: "call-a", ToolCallName: "search", Delta: `":"x"}`},
{Type: fantasy.StreamPartTypeToolInputEnd, ID: "call-b", ToolCallName: "calc", Delta: `":"add"}`},
} {
content = appendNormalizedStreamContent(content, part, &streamDebugBytes)
content, currentText, currentTextIdx = appendNormalizedStreamContent(
content, currentText, currentTextIdx, argBuilders, part, &streamDebugBytes)
}
materializeStreamContent(content, currentText, currentTextIdx, argBuilders)
require.Equal(t, []normalizedContentPart{
{Type: "tool_input", ToolCallID: "call-a", ToolName: "search", Arguments: `{"query":"x"}`},
@@ -176,7 +197,12 @@ func TestAppendNormalizedStreamContent_ToolInputAttributionPerCall(t *testing.T)
func TestAppendNormalizedStreamContent_ToolInputAcrossInterleavedText(t *testing.T) {
t.Parallel()
var content []normalizedContentPart
var (
content []normalizedContentPart
currentText *strings.Builder
currentTextIdx int
)
argBuilders := make(map[string]*strings.Builder)
streamDebugBytes := 0
for _, part := range []fantasy.StreamPart{
{Type: fantasy.StreamPartTypeToolInputStart, ID: "call-a", ToolCallName: "search", Delta: `{"q`},
@@ -184,8 +210,10 @@ func TestAppendNormalizedStreamContent_ToolInputAcrossInterleavedText(t *testing
{Type: fantasy.StreamPartTypeTextDelta, Delta: "thinking..."},
{Type: fantasy.StreamPartTypeToolInputDelta, ID: "call-a", ToolCallName: "search", Delta: `uery":"x"}`},
} {
content = appendNormalizedStreamContent(content, part, &streamDebugBytes)
content, currentText, currentTextIdx = appendNormalizedStreamContent(
content, currentText, currentTextIdx, argBuilders, part, &streamDebugBytes)
}
materializeStreamContent(content, currentText, currentTextIdx, argBuilders)
require.Equal(t, []normalizedContentPart{
{Type: "tool_input", ToolCallID: "call-a", ToolName: "search", Arguments: `{"query":"x"}`},
@@ -198,14 +226,21 @@ func TestAppendNormalizedStreamContent_GlobalTextCap(t *testing.T) {
streamDebugBytes := 0
long := strings.Repeat("a", maxStreamDebugTextBytes)
var content []normalizedContentPart
var (
content []normalizedContentPart
currentText *strings.Builder
currentTextIdx int
)
argBuilders := make(map[string]*strings.Builder)
for _, part := range []fantasy.StreamPart{
{Type: fantasy.StreamPartTypeTextDelta, Delta: long},
{Type: fantasy.StreamPartTypeToolCall, ID: "call-1", ToolCallName: "search_docs", ToolCallInput: `{}`},
{Type: fantasy.StreamPartTypeTextDelta, Delta: "tail"},
} {
content = appendNormalizedStreamContent(content, part, &streamDebugBytes)
content, currentText, currentTextIdx = appendNormalizedStreamContent(
content, currentText, currentTextIdx, argBuilders, part, &streamDebugBytes)
}
materializeStreamContent(content, currentText, currentTextIdx, argBuilders)
require.Len(t, content, 2)
require.Equal(t, strings.Repeat("a", maxStreamDebugTextBytes), content[0].Text)