From c31768dfe79b6b16a0c5d1946e495c7bd6cb7c68 Mon Sep 17 00:00:00 2001 From: Asher Date: Mon, 15 Sep 2025 09:00:30 -0800 Subject: [PATCH] fix: use filepath to construct mcp test write path (#19808) Hopefully fixes https://github.com/coder/internal/issues/993 ``` file path must be absolute: "/test/some/path" ``` Not sure if this is the right fix though, since I am not sure how this only flakes rather than always failing. It looks like starting with `/` should not be considered absolute in Windows, but then how did it ever pass at all? --- codersdk/toolsdk/toolsdk_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/codersdk/toolsdk/toolsdk_test.go b/codersdk/toolsdk/toolsdk_test.go index 69ca9212a0..39e2a08e4a 100644 --- a/codersdk/toolsdk/toolsdk_test.go +++ b/codersdk/toolsdk/toolsdk_test.go @@ -615,14 +615,17 @@ func TestTools(t *testing.T) { tb, err := toolsdk.NewDeps(client) require.NoError(t, err) + tmpdir := os.TempDir() + filePath := filepath.Join(tmpdir, "write") + _, err = testTool(t, toolsdk.WorkspaceWriteFile, tb, toolsdk.WorkspaceWriteFileArgs{ Workspace: workspace.Name, - Path: "/test/some/path", + Path: filePath, Content: []byte("content"), }) require.NoError(t, err) - b, err := afero.ReadFile(fs, "/test/some/path") + b, err := afero.ReadFile(fs, filePath) require.NoError(t, err) require.Equal(t, []byte("content"), b) })