opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: avoid concurrent usage of t.FailNow (#1683)

Browse Source 
* chore: golangci: add linter rule to report usage of t.FailNow inside goroutines
* chore: avoid t.FailNow in goroutines to appease the race detector
This commit is contained in:
Cian Johnston
2022-05-24 08:58:39 +01:00
committed by GitHub
parent 9b70a9b2eb
commit c2f74f3cc2
27 changed files with 120 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
peer/conn_test.go
+6 -6
View File
@@ -174,10 +174,10 @@ func TestConn(t *testing.T) {
defer srv.Close()
go func() {
sch, err := server.Accept(context.Background())
require.NoError(t, err)
assert.NoError(t, err)
nc2 := sch.NetConn()
nc1, err := net.Dial("tcp", srv.Addr().String())
require.NoError(t, err)
assert.NoError(t, err)
go func() {
_, _ = io.Copy(nc1, nc2)
}()
@@ -248,12 +248,12 @@ func TestConn(t *testing.T) {
go func() {
defer wg.Done()
_, err := client.Ping()
require.NoError(t, err)
assert.NoError(t, err)
}()
go func() {
defer wg.Done()
_, err := server.Ping()
require.NoError(t, err)
assert.NoError(t, err)
}()
wg.Wait()
})
@@ -276,9 +276,9 @@ func TestConn(t *testing.T) {
exchange(t, client, server)
go func() {
channel, err := client.CreateChannel(context.Background(), "test", nil)
require.NoError(t, err)
assert.NoError(t, err)
_, err = channel.Write([]byte{1, 2})
require.NoError(t, err)
assert.NoError(t, err)
}()
channel, err := server.Accept(context.Background())
require.NoError(t, err)