From c2f6cce93863e0b6eccc2ea4130d4ac68ac33fa1 Mon Sep 17 00:00:00 2001 From: Presley Date: Tue, 26 Apr 2022 02:19:47 +0000 Subject: [PATCH] Remove displayError, use displaySuccess --- site/src/components/GlobalSnackbar/utils.ts | 4 ---- site/src/xServices/users/usersXService.ts | 12 ++++-------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/site/src/components/GlobalSnackbar/utils.ts b/site/src/components/GlobalSnackbar/utils.ts index 90e69e238f..84fda4afa3 100644 --- a/site/src/components/GlobalSnackbar/utils.ts +++ b/site/src/components/GlobalSnackbar/utils.ts @@ -60,7 +60,3 @@ export const displayMsg = (msg: string, additionalMsg?: string): void => { export const displaySuccess = (msg: string, additionalMsg?: string): void => { dispatchNotificationEvent(MsgType.Success, msg, additionalMsg ? [additionalMsg] : undefined) } - -export const displayError = (msg: string, additionalMsg?: string): void => { - dispatchNotificationEvent(MsgType.Error, msg, additionalMsg ? [additionalMsg] : undefined) -} diff --git a/site/src/xServices/users/usersXService.ts b/site/src/xServices/users/usersXService.ts index 0be3f59689..e17619617c 100644 --- a/site/src/xServices/users/usersXService.ts +++ b/site/src/xServices/users/usersXService.ts @@ -2,10 +2,9 @@ import { assign, createMachine } from "xstate" import * as API from "../../api" import * as Types from "../../api/types" import * as TypesGen from "../../api/typesGenerated" -import { displayError } from "../../components/GlobalSnackbar/utils" +import { displaySuccess } from "../../components/GlobalSnackbar/utils" -const Language = { - createUserError: "Unable to create user", +export const Language = { createUserSuccess: "Successfully created user", } @@ -74,7 +73,7 @@ export const usersMachine = createMachine( }, onError: { target: "idle", - actions: ["assignCreateUserError", "displayCreateUserError"], + actions: ["assignCreateUserError"], }, }, tags: "loading", @@ -110,11 +109,8 @@ export const usersMachine = createMachine( ...context, createUserError: undefined, })), - displayCreateUserError: (_, event) => { - displayError(Language.createUserError) - }, displayCreateUserSuccess: () => { - displayError(Language.createUserSuccess) + displaySuccess(Language.createUserSuccess) }, }, },