From c2c2b6f16f2192c9d42bce669d5f2b05b30a9474 Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Tue, 10 Feb 2026 19:16:44 +0000 Subject: [PATCH] chore: remove call to taskname.Generate in dbgen (#22040) I was trying to figure out why `goleak` was complaining about a dangling http2 connection goroutine in tests. Turns out that `taskname.Generate` will call out to Anthropic if an API key is set, and we're calling it in `dbgen`. Modified to use testutil method instead. --- coderd/database/dbgen/dbgen.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/coderd/database/dbgen/dbgen.go b/coderd/database/dbgen/dbgen.go index deb1005138..ff646d0d76 100644 --- a/coderd/database/dbgen/dbgen.go +++ b/coderd/database/dbgen/dbgen.go @@ -19,7 +19,6 @@ import ( "github.com/stretchr/testify/require" "golang.org/x/xerrors" - "cdr.dev/slog/v3" "github.com/coder/coder/v2/coderd/apikey" "github.com/coder/coder/v2/coderd/database" "github.com/coder/coder/v2/coderd/database/db2sdk" @@ -30,7 +29,6 @@ import ( "github.com/coder/coder/v2/coderd/rbac" "github.com/coder/coder/v2/coderd/rbac/policy" "github.com/coder/coder/v2/coderd/rbac/rolestore" - "github.com/coder/coder/v2/coderd/taskname" "github.com/coder/coder/v2/codersdk" "github.com/coder/coder/v2/cryptorand" "github.com/coder/coder/v2/provisionerd/proto" @@ -1664,13 +1662,12 @@ func Task(t testing.TB, db database.Store, orig database.TaskTable) database.Tas parameters = json.RawMessage([]byte("{}")) } - taskName := taskname.Generate(genCtx, slog.Make(), orig.Prompt) task, err := db.InsertTask(genCtx, database.InsertTaskParams{ ID: takeFirst(orig.ID, uuid.New()), OrganizationID: orig.OrganizationID, OwnerID: orig.OwnerID, - Name: takeFirst(orig.Name, taskName.Name), - DisplayName: takeFirst(orig.DisplayName, taskName.DisplayName), + Name: takeFirst(orig.Name, testutil.GetRandomNameHyphenated(t)), + DisplayName: takeFirst(orig.DisplayName, testutil.GetRandomNameHyphenated(t)), WorkspaceID: orig.WorkspaceID, TemplateVersionID: orig.TemplateVersionID, TemplateParameters: parameters,