From c189fc52c1332106c14d61e4c7933c0a76645da0 Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Fri, 20 May 2022 12:42:01 -0500 Subject: [PATCH] fix: using a trailing slash on login url (#1622) --- cli/login.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cli/login.go b/cli/login.go index f931952959..25c0b4514d 100644 --- a/cli/login.go +++ b/cli/login.go @@ -8,6 +8,7 @@ import ( "os" "os/exec" "os/user" + "path" "runtime" "strings" @@ -171,7 +172,9 @@ func login() *cobra.Command { sessionToken, _ := cmd.Flags().GetString(varToken) if sessionToken == "" { authURL := *serverURL - authURL.Path = serverURL.Path + "/cli-auth" + // Don't use filepath.Join, we don't want to use the os separator + // for a url. + authURL.Path = path.Join(serverURL.Path, "/cli-auth") if err := openURL(cmd, authURL.String()); err != nil { _, _ = fmt.Fprintf(cmd.OutOrStdout(), "Open the following in your browser:\n\n\t%s\n\n", authURL.String()) } else {