opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: coder_parameter fallbacks to default (#7240)

Browse Source
This commit is contained in:
Marcin Tojek
2023-04-24 09:51:34 +02:00
committed by GitHub
parent ab077d1f15
commit c000f2ec28
3 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/api/api.ts
+7 -3
View File
@@ -1057,15 +1057,19 @@ const getMissingParameters = (
const requiredParameters: TypesGen.TemplateVersionParameter[] = []
templateParameters.forEach((p) => {
// Legacy parameters should be required. So we can migrate them.
const isLegacy = p.legacy_variable_name === undefined
// Legacy parameters should not be required. Backend can just migrate them.
const isLegacy = p.legacy_variable_name !== undefined
// It is mutable and required. Mutable values can be changed after so we
// don't need to ask them if they are not required.
const isMutableAndRequired = p.mutable && p.required
// Is immutable, so we can check if it is its first time on the build
const isImmutable = !p.mutable
if (isLegacy || isMutableAndRequired || isImmutable) {
if (isLegacy) {
return
}
if (isMutableAndRequired || isImmutable) {
requiredParameters.push(p)
return
}