From bb690547166423857d92ce35fd344fe52072214d Mon Sep 17 00:00:00 2001 From: Ethan <39577870+ethanndickson@users.noreply.github.com> Date: Wed, 29 Jan 2025 01:08:39 +1100 Subject: [PATCH] fix(cli): remove loading indicator when pinging with verbose logs (#16305) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was causing some verbose log lines to be prepended with the spinner message, e.g. ``` ◱ Collecting diagnostics...2025-01-28 10:26:27.502 ``` which doesnt look very good. Presumably anyone running it with verbose will know it takes a moment to collect diagnostics first. --- cli/ping.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/ping.go b/cli/ping.go index a54687cf2c..0e219d5762 100644 --- a/cli/ping.go +++ b/cli/ping.go @@ -120,7 +120,9 @@ func (r *RootCmd) ping() *serpent.Command { spin := spinner.New(spinner.CharSets[5], 100*time.Millisecond) spin.Writer = inv.Stderr spin.Suffix = pretty.Sprint(cliui.DefaultStyles.Keyword, " Collecting diagnostics...") - spin.Start() + if !r.verbose { + spin.Start() + } opts := &workspacesdk.DialAgentOptions{}