perf(cli): optimize CPU consumption of help pages (#9607)

This change reduces the CPU consumption of --help by ~50%.

Also, this change removes ANSI escape codes from our golden files. I
don't think those were worth the inability to parallelize golden file tests and
global state fragility.
This commit is contained in:
Ammar Bandukwala
2023-09-14 19:48:29 -05:00
committed by GitHub
parent 7311ffbd9d
commit b63dfe7b75
93 changed files with 854 additions and 828 deletions
+1 -1
View File
@@ -234,7 +234,7 @@ func (s *Session) extractArchive() error {
// Always check for context cancellation before reading the next header.
// This is mainly important for unit tests, since a canceled context means
// the underlying directory is going to be deleted. There still exists
// the small race condition that the context is cancelled after this, and
// the small race condition that the context is canceled after this, and
// before the disk write.
if ctx.Err() != nil {
return xerrors.Errorf("context canceled: %w", ctx.Err())