perf(cli): optimize CPU consumption of help pages (#9607)

This change reduces the CPU consumption of --help by ~50%.

Also, this change removes ANSI escape codes from our golden files. I
don't think those were worth the inability to parallelize golden file tests and
global state fragility.
This commit is contained in:
Ammar Bandukwala
2023-09-14 19:48:29 -05:00
committed by GitHub
parent 7311ffbd9d
commit b63dfe7b75
93 changed files with 854 additions and 828 deletions
+14
View File
@@ -1564,6 +1564,20 @@ func TestServer_Shutdown(t *testing.T) {
require.NoError(t, err)
}
func BenchmarkServerHelp(b *testing.B) {
// server --help is a good proxy for measuring the
// constant overhead of each command.
b.ReportAllocs()
for i := 0; i < b.N; i++ {
inv, _ := clitest.New(b, "server", "--help")
inv.Stdout = io.Discard
inv.Stderr = io.Discard
err := inv.Run()
require.NoError(b, err)
}
}
func generateTLSCertificate(t testing.TB, commonName ...string) (certPath, keyPath string) {
dir := t.TempDir()