From b46d0d693f7cbca4a89b78aed7c4f7b2ea0730b7 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Thu, 9 Feb 2023 16:59:54 +0200 Subject: [PATCH] fix: Extend migration fixture test with down and fix 000045 (#6130) --- coderd/database/migrations/000045_workspacebuildname.down.sql | 2 +- coderd/database/migrations/migrate_test.go | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/coderd/database/migrations/000045_workspacebuildname.down.sql b/coderd/database/migrations/000045_workspacebuildname.down.sql index ebf4ef5ef4..58a6f6dd91 100644 --- a/coderd/database/migrations/000045_workspacebuildname.down.sql +++ b/coderd/database/migrations/000045_workspacebuildname.down.sql @@ -1,2 +1,2 @@ ALTER TABLE workspace_builds - ADD COLUMN name character varying(64) NOT NULL; + ADD COLUMN name character varying(64) NOT NULL DEFAULT ''; diff --git a/coderd/database/migrations/migrate_test.go b/coderd/database/migrations/migrate_test.go index a6193592c7..b85781124c 100644 --- a/coderd/database/migrations/migrate_test.go +++ b/coderd/database/migrations/migrate_test.go @@ -331,6 +331,10 @@ func TestMigrateUpWithFixtures(t *testing.T) { s.Add(table, count) } } + + // Test that migration down is successful after up. + err = migrations.Down(db) + require.NoError(t, err, "final migration down should be successful") }) } }