mirror of
https://github.com/coder/coder.git
synced 2026-09-24 15:04:27 +08:00
feat: persist agent-pushed workspace context snapshots in coderd (#26145)
Replaces the v2.10 `PushContextState` stub with a real coderd write path. Phase 1 of the chat-side persistence story; nothing reads these rows yet. Follows [#25983](https://github.com/coder/coder/pull/25983) and unblocks [CODAGT-569](https://linear.app/codercom/issue/CODAGT-569/enable-agent-api-v210-pushcontextstate-bump-currentminor-wire-coderd). ## What ships ### Schema (`000517_workspace_agent_context.{up,down}.sql`) Two new tables plus `api_key_scope` enum extensions: - `workspace_agent_context_snapshots` (PK `workspace_agent_id` to `workspace_agents(id) ON DELETE CASCADE`): one row per agent, overwritten per push. Holds `version`, `schema_version`, `aggregate_hash`, `snapshot_error`, `received_at`. - `workspace_agent_context_resources` (PK `(workspace_agent_id, source)`): per-resource state. `body_kind` and `status` are `TEXT` + `CHECK` so adding new wire kinds (the RFC's reserved PLUGIN/HOOK/SUBAGENT/COMMAND) is a one-line CHECK update plus a Go switch case. ### SQLC queries (`coderd/database/queries/workspaceagentcontext.sql`) - `UpsertWorkspaceAgentContextSnapshot` - `UpsertWorkspaceAgentContextResource` - `DeleteStaleWorkspaceAgentContextResources` (delete-where-source-not-in) - `GetLatestWorkspaceAgentContextSnapshot` - `ListWorkspaceAgentContextResources` ### Handler (`coderd/agentapi/context.go`) `ContextAPI` is a new sub-API. `PushContextState`: 1. Rejects `schema_version > 1` with a non-`Unimplemented` error so a forward-incompatible agent fails loudly during rollout instead of slipping into the permanent fallback path the `Unimplemented` translation reserves for old coderd deployments. 2. Validates resources: no empty/duplicate sources, every variant maps to a known body kind, every status maps to a known enum value, the `Body` oneof is set (even when status is non-OK, mirroring the wire guarantee so coderd can attribute failures to a known kind). 3. Inside `Database.InTx`, reads the existing snapshot. If the push is not `initial` and `version` is not strictly greater, returns `accepted = false` and leaves stored state untouched. Otherwise upserts the snapshot row, upserts each resource, then runs the stale-source prune so the snapshot and resource rows always agree. 4. Returns `accepted = true` on success. Resource bodies are stored as `protojson(body oneof variant)` in `body JSONB` with `body_kind` as the discriminator. Adding a new field to an existing variant is zero work since `protojson` tolerates new fields; adding a new variant is a CHECK + switch case. ### RBAC + dbauthz - New `ResourceWorkspaceAgentContext` (Create/Read/Update/Delete). - New `SubjectTypeAgentContext` plus `subjectAgentContext` system role and `dbauthz.AsAgentContext` helper. The push handler elevates to this subject; the agent's own role does not get direct write access to the table. - New `workspace_agent_context:*` API key scopes registered in the enum migration; internal-only (not added to `externalLowLevel`). ### Audit These rows are agent-pushed state, not user-authored. They are intentionally not added to `AuditActionMap` and not enumerated in `enterprise/audit/table.go`, matching `boundary_logs`, `workspace_agent_memory_resource_monitor`, etc. `enterprise/audit` tests pass unchanged. ## Tests - `coderd/agentapi/context_test.go`: 12 subtests covering accepts/rejects (schema version, empty/duplicate source, unknown status, missing body), version semantics (stale dropped, same-version replay dropped, `initial=true` overwrites lower version), variant coverage, non-OK status persistence, and the empty-active-set prune case. - `coderd/database/dbauthz/dbauthz_test.go`: 5 `MethodTestSuite` cases covering the new queries. - `coderd/rbac/roles_test.go`: `WorkspaceAgentContext` permission row asserting no human role currently has access. - `coderd/database/migrations/testdata/fixtures/000517_workspace_agent_context.up.sql`: one snapshot + one resource per known body kind plus a non-OK status, so the migration test suite never lands with these tables empty. ## Out of scope (later phases) - Chat hydration (`chats.context_aggregate_hash`, `last_injected_context`). - Dirty-bit fan-out and `PUT /chats/{id}/context`. - Agent-side `POST /api/v0/context/resync` barrier and the `coder exp chat context` CLI. - `codersdk` chat-context wire types and the dashboard Sources drawer. - Removal of the chatd per-turn pull fallback. ## Compat property This is a pure write path. If anything here returns errors the agent's `RunPush` loop backs off, no chat behavior changes, and the workspace keeps behaving exactly like it did before v2.10. <details> <summary>Implementation plan and decision log</summary> Key design calls: 1. **Concurrency**: Accept iff `req.Initial || req.Version > existing.Version`. The strict RFC reading ("version comparison is authoritative") locks restarted agents out because their per-process counter resets to 1; honoring `initial=true` reflects the real reboot reality while still rejecting steady-state replays/out-of-order pushes. 2. **Body encoding**: `protojson` over the oneof variant body proto, stored in JSONB with `body_kind` discriminator. Structured at the API/Go layer, schema-tolerant at the storage layer, and Phase 2 readers round-trip back via `protojson.Unmarshal`. 3. **Schema version rejection**: returns a normal error, not `Unimplemented`. The agent's `RunPush` loop only short-circuits on `Unimplemented`; that escape hatch is reserved for old coderd deployments. A forward-incompatible agent should retry-and-back-off, not flip the connection into permanent fallback. 4. **Validation strictness**: empty sources, duplicate sources, `STATUS_UNSPECIFIED`, and missing `Body` oneof variants are rejected before any write so a misbehaving agent cannot poison the snapshot table. Phase 2 readers can trust every row maps to a known proto variant. </details> _This PR was authored by Coder Agents on Kyle Carberry's behalf._
This commit is contained in:
@@ -58,6 +58,7 @@ type API struct {
|
||||
*ConnLogAPI
|
||||
*SubAgentAPI
|
||||
*BoundaryLogsAPI
|
||||
*ContextAPI
|
||||
*tailnet.DRPCService
|
||||
|
||||
cachedWorkspaceFields *CachedWorkspaceFields
|
||||
@@ -246,6 +247,14 @@ func New(opts Options, workspace database.Workspace, agent database.WorkspaceAge
|
||||
BoundaryUsageTracker: opts.BoundaryUsageTracker,
|
||||
}
|
||||
|
||||
api.ContextAPI = &ContextAPI{
|
||||
AgentID: agent.ID,
|
||||
Workspace: api.cachedWorkspaceFields,
|
||||
Log: opts.Log,
|
||||
Clock: opts.Clock,
|
||||
Database: opts.Database,
|
||||
}
|
||||
|
||||
// Start background cache refresh loop to handle workspace changes
|
||||
// like prebuild claims where owner_id and other fields may be modified in the DB.
|
||||
go api.startCacheRefreshLoop(opts.AuthenticatedCtx)
|
||||
|
||||
+374
-16
@@ -2,29 +2,387 @@ package agentapi
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"errors"
|
||||
"math"
|
||||
"sort"
|
||||
|
||||
"storj.io/drpc/drpcerr"
|
||||
"github.com/google/uuid"
|
||||
"golang.org/x/xerrors"
|
||||
"google.golang.org/protobuf/encoding/protojson"
|
||||
"google.golang.org/protobuf/proto"
|
||||
|
||||
"cdr.dev/slog/v3"
|
||||
agentproto "github.com/coder/coder/v2/agent/proto"
|
||||
"github.com/coder/coder/v2/coderd/database"
|
||||
"github.com/coder/coder/v2/coderd/database/dbtime"
|
||||
"github.com/coder/quartz"
|
||||
)
|
||||
|
||||
// PushContextState is the server-side stub for the v2.10
|
||||
// PushContextState RPC. Coderd does not yet persist context
|
||||
// snapshots; the chatd integration that consumes pushes lives
|
||||
// in a follow-up change.
|
||||
// Server-side caps on a single PushContextState request. The agent
|
||||
// enforces its own caps (64KiB per resource payload, 2MiB aggregate,
|
||||
// 500 resources; see agent/agentcontext/resolve.go), but coderd
|
||||
// cannot trust a workspace process, so pushes are re-validated here
|
||||
// with headroom above the agent caps:
|
||||
//
|
||||
// Returning Unimplemented signals the agent to stop pushing for
|
||||
// the remainder of the connection. The agent.Manager.RunPush
|
||||
// loop translates this into a clean shutdown rather than a
|
||||
// retry storm.
|
||||
func (*API) PushContextState(_ context.Context, _ *agentproto.PushContextStateRequest) (*agentproto.PushContextStateResponse, error) {
|
||||
return nil, drpcerr.WithCode(errPushContextStateUnimplemented, drpcerr.Unimplemented)
|
||||
// - maxContextResourcesPerPush allows excluded stub entries past
|
||||
// the agent's 500-resource cap.
|
||||
// - maxContextResourceBodyBytes covers protojson and base64
|
||||
// expansion of a 64KiB payload.
|
||||
// - maxContextAggregateBodyBytes matches the 4MiB DRPC message
|
||||
// cap so the invariant survives transport changes.
|
||||
// - The string and hash caps bound the remaining row columns;
|
||||
// source doubles as a btree primary key column, which PostgreSQL
|
||||
// limits to roughly 2704 bytes per index entry.
|
||||
const (
|
||||
maxContextResourcesPerPush = 1000
|
||||
maxContextResourceBodyBytes = 256 * 1024
|
||||
maxContextAggregateBodyBytes = 4 * 1024 * 1024
|
||||
maxContextSourceBytes = 1024
|
||||
maxContextErrorBytes = 4096
|
||||
maxContextHashBytes = 64
|
||||
)
|
||||
|
||||
// ContextAPI implements the v2.10 PushContextState RPC. It persists
|
||||
// the latest pushed snapshot per workspace agent across two tables
|
||||
// (workspace_agent_context_snapshots and
|
||||
// workspace_agent_context_resources) so later phases can hydrate
|
||||
// chats and surface drift to the dashboard.
|
||||
//
|
||||
// The handler is a pure write path: nothing else in coderd reads
|
||||
// these rows yet. If a bug here returns errors the agent's RunPush
|
||||
// loop backs off and the workspace keeps behaving exactly like it
|
||||
// did before v2.10.
|
||||
type ContextAPI struct {
|
||||
AgentID uuid.UUID
|
||||
// Workspace caches workspace fields for the duration of the agent
|
||||
// connection so dbauthz can authorize against the workspace RBAC
|
||||
// object without re-fetching the workspace on every push.
|
||||
Workspace *CachedWorkspaceFields
|
||||
Log slog.Logger
|
||||
Clock quartz.Clock
|
||||
Database database.Store
|
||||
}
|
||||
|
||||
// errPushContextStateUnimplemented is the static error returned
|
||||
// by PushContextState before the chatd integration lands.
|
||||
var errPushContextStateUnimplemented = stringError("agentapi: PushContextState is not implemented yet")
|
||||
// PushContextState persists a snapshot pushed by the workspace
|
||||
// agent. The transaction upserts the snapshot row, upserts each
|
||||
// resource, then deletes any resources whose source is not in the
|
||||
// incoming set so the stored snapshot and resource table always
|
||||
// agree. It runs at repeatable read isolation (with retries) so two
|
||||
// concurrent pushes cannot interleave their writes; the loser of the
|
||||
// conflict re-runs the version gate against the winner's committed
|
||||
// state.
|
||||
//
|
||||
// Returns accepted = false (without writing) when the push is a
|
||||
// replay or out-of-order resend: the agent's per-process version
|
||||
// counter is monotonic, and only an initial = true push from a
|
||||
// freshly-booted agent resets that baseline. Replays and stale
|
||||
// retransmits leave the stored state untouched.
|
||||
//
|
||||
// Authorization happens in dbauthz: every query in the transaction
|
||||
// authorizes the actor (the agent's token subject) against the
|
||||
// workspace that owns the agent.
|
||||
func (a *ContextAPI) PushContextState(ctx context.Context, req *agentproto.PushContextStateRequest) (*agentproto.PushContextStateResponse, error) {
|
||||
if req == nil {
|
||||
return nil, xerrors.New("agentapi: PushContextState request is nil")
|
||||
}
|
||||
if err := validateContextPushRequest(req); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
type stringError string
|
||||
rows, err := validateAndConvertContextResources(req.Resources)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
func (e stringError) Error() string { return string(e) }
|
||||
// Attach the cached workspace RBAC object so dbauthz can take its
|
||||
// fast path. On failure (or when unset, e.g. prebuilds) dbauthz
|
||||
// falls back to fetching the workspace by agent ID.
|
||||
if a.Workspace != nil {
|
||||
injected, err := a.Workspace.ContextInject(ctx)
|
||||
if err != nil {
|
||||
a.Log.Debug(ctx, "failed to inject cached workspace RBAC object", slog.Error(err))
|
||||
} else {
|
||||
ctx = injected
|
||||
}
|
||||
}
|
||||
|
||||
clock := a.Clock
|
||||
if clock == nil {
|
||||
clock = quartz.NewReal()
|
||||
}
|
||||
now := dbtime.Time(clock.Now())
|
||||
|
||||
activeSources := make([]string, 0, len(rows))
|
||||
for _, r := range rows {
|
||||
activeSources = append(activeSources, r.Source)
|
||||
}
|
||||
sort.Strings(activeSources)
|
||||
|
||||
var accepted bool
|
||||
err = database.ReadModifyUpdate(a.Database, func(tx database.Store) error {
|
||||
// The closure re-runs on serialization conflicts; reset any
|
||||
// state carried over from a rolled-back attempt.
|
||||
accepted = false
|
||||
|
||||
existing, err := tx.GetLatestWorkspaceAgentContextSnapshot(ctx, a.AgentID)
|
||||
switch {
|
||||
case errors.Is(err, sql.ErrNoRows):
|
||||
// No previous snapshot; first push always wins.
|
||||
case err != nil:
|
||||
return xerrors.Errorf("get latest snapshot: %w", err)
|
||||
default:
|
||||
// Accept either a fresh agent process (initial) or
|
||||
// a strictly newer version. Out-of-order or replayed
|
||||
// pushes leave the stored state untouched.
|
||||
//
|
||||
//nolint:gosec // existing.Version is a uint64 round-tripped via BIGINT; non-negative by construction.
|
||||
if !req.Initial && req.Version <= uint64(existing.Version) {
|
||||
return nil
|
||||
}
|
||||
}
|
||||
|
||||
_, err = tx.UpsertWorkspaceAgentContextSnapshot(ctx, database.UpsertWorkspaceAgentContextSnapshotParams{
|
||||
WorkspaceAgentID: a.AgentID,
|
||||
//nolint:gosec // Bounded by validateContextPushRequest.
|
||||
Version: int64(req.Version),
|
||||
AggregateHash: append([]byte(nil), req.AggregateHash...),
|
||||
SnapshotError: req.SnapshotError,
|
||||
ReceivedAt: now,
|
||||
})
|
||||
if err != nil {
|
||||
return xerrors.Errorf("upsert snapshot: %w", err)
|
||||
}
|
||||
|
||||
for _, r := range rows {
|
||||
r.WorkspaceAgentID = a.AgentID
|
||||
r.Now = now
|
||||
_, err = tx.UpsertWorkspaceAgentContextResource(ctx, r)
|
||||
if err != nil {
|
||||
return xerrors.Errorf("upsert resource %q: %w", r.Source, err)
|
||||
}
|
||||
}
|
||||
|
||||
err = tx.DeleteStaleWorkspaceAgentContextResources(ctx, database.DeleteStaleWorkspaceAgentContextResourcesParams{
|
||||
WorkspaceAgentID: a.AgentID,
|
||||
ActiveSources: activeSources,
|
||||
})
|
||||
if err != nil {
|
||||
return xerrors.Errorf("delete stale resources: %w", err)
|
||||
}
|
||||
|
||||
accepted = true
|
||||
return nil
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
if !accepted {
|
||||
a.Log.Debug(ctx, "PushContextState dropped: replay or out-of-order",
|
||||
slog.F("agent_id", a.AgentID),
|
||||
slog.F("version", req.Version),
|
||||
slog.F("initial", req.Initial),
|
||||
)
|
||||
return &agentproto.PushContextStateResponse{Accepted: false}, nil
|
||||
}
|
||||
|
||||
a.Log.Debug(ctx, "PushContextState accepted",
|
||||
slog.F("agent_id", a.AgentID),
|
||||
slog.F("version", req.Version),
|
||||
slog.F("initial", req.Initial),
|
||||
slog.F("resources", len(rows)),
|
||||
)
|
||||
return &agentproto.PushContextStateResponse{Accepted: true}, nil
|
||||
}
|
||||
|
||||
// validateContextPushRequest enforces the request-level caps: counts
|
||||
// and sizes a compromised workspace could otherwise inflate to DoS
|
||||
// coderd or bloat the database.
|
||||
func validateContextPushRequest(req *agentproto.PushContextStateRequest) error {
|
||||
if req.Version > math.MaxInt64 {
|
||||
return xerrors.Errorf("agentapi: PushContextState version %d exceeds int64 range", req.Version)
|
||||
}
|
||||
if len(req.AggregateHash) > maxContextHashBytes {
|
||||
return xerrors.Errorf("agentapi: PushContextState aggregate hash is %d bytes, exceeds %d byte cap", len(req.AggregateHash), maxContextHashBytes)
|
||||
}
|
||||
if len(req.SnapshotError) > maxContextErrorBytes {
|
||||
return xerrors.Errorf("agentapi: PushContextState snapshot error is %d bytes, exceeds %d byte cap", len(req.SnapshotError), maxContextErrorBytes)
|
||||
}
|
||||
if len(req.Resources) > maxContextResourcesPerPush {
|
||||
return xerrors.Errorf("agentapi: PushContextState has %d resources, exceeds %d resource cap", len(req.Resources), maxContextResourcesPerPush)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// validateAndConvertContextResources translates wire resources into
|
||||
// upsert parameters while rejecting structurally invalid input:
|
||||
//
|
||||
// - empty, oversized, or duplicate sources (the PK depends on
|
||||
// uniqueness and indexes the source column),
|
||||
// - unknown body variants (kept extensible by emitting the proto's
|
||||
// reserved kinds via dedicated body messages),
|
||||
// - unknown status enum values,
|
||||
// - per-resource and aggregate body sizes past the server caps.
|
||||
//
|
||||
// Validation is deliberately strict here so a misbehaving agent
|
||||
// cannot poison the snapshot table. Phase 2 readers can then trust
|
||||
// that every row maps to a known proto variant.
|
||||
//
|
||||
// WorkspaceAgentID and Now are left unset; the caller fills them at
|
||||
// upsert time.
|
||||
func validateAndConvertContextResources(resources []*agentproto.ContextResource) ([]database.UpsertWorkspaceAgentContextResourceParams, error) {
|
||||
rows := make([]database.UpsertWorkspaceAgentContextResourceParams, 0, len(resources))
|
||||
seen := make(map[string]struct{}, len(resources))
|
||||
aggregateBodyBytes := 0
|
||||
for i, r := range resources {
|
||||
if r == nil {
|
||||
return nil, xerrors.Errorf("agentapi: PushContextState resource at index %d is nil", i)
|
||||
}
|
||||
if r.Source == "" {
|
||||
return nil, xerrors.Errorf("agentapi: PushContextState resource at index %d has empty source", i)
|
||||
}
|
||||
if len(r.Source) > maxContextSourceBytes {
|
||||
return nil, xerrors.Errorf("agentapi: PushContextState resource at index %d has %d byte source, exceeds %d byte cap", i, len(r.Source), maxContextSourceBytes)
|
||||
}
|
||||
if _, ok := seen[r.Source]; ok {
|
||||
return nil, xerrors.Errorf("agentapi: PushContextState duplicate source %q", r.Source)
|
||||
}
|
||||
seen[r.Source] = struct{}{}
|
||||
|
||||
if len(r.GetSourcePath()) > maxContextSourceBytes {
|
||||
return nil, xerrors.Errorf("resource %q: source path is %d bytes, exceeds %d byte cap", r.Source, len(r.GetSourcePath()), maxContextSourceBytes)
|
||||
}
|
||||
if len(r.Error) > maxContextErrorBytes {
|
||||
return nil, xerrors.Errorf("resource %q: error is %d bytes, exceeds %d byte cap", r.Source, len(r.Error), maxContextErrorBytes)
|
||||
}
|
||||
if len(r.ContentHash) > maxContextHashBytes {
|
||||
return nil, xerrors.Errorf("resource %q: content hash is %d bytes, exceeds %d byte cap", r.Source, len(r.ContentHash), maxContextHashBytes)
|
||||
}
|
||||
if r.SizeBytes > math.MaxInt64 {
|
||||
return nil, xerrors.Errorf("resource %q: size %d exceeds int64 range", r.Source, r.SizeBytes)
|
||||
}
|
||||
|
||||
kind, body, err := marshalContextResourceBody(r)
|
||||
if err != nil {
|
||||
return nil, xerrors.Errorf("resource %q: %w", r.Source, err)
|
||||
}
|
||||
if len(body) > maxContextResourceBodyBytes {
|
||||
return nil, xerrors.Errorf("resource %q: body is %d bytes, exceeds %d byte cap", r.Source, len(body), maxContextResourceBodyBytes)
|
||||
}
|
||||
aggregateBodyBytes += len(body)
|
||||
if aggregateBodyBytes > maxContextAggregateBodyBytes {
|
||||
return nil, xerrors.Errorf("agentapi: PushContextState aggregate body size exceeds %d byte cap", maxContextAggregateBodyBytes)
|
||||
}
|
||||
status, err := contextResourceStatus(r.Status)
|
||||
if err != nil {
|
||||
return nil, xerrors.Errorf("resource %q: %w", r.Source, err)
|
||||
}
|
||||
|
||||
//nolint:exhaustruct // WorkspaceAgentID and Now are filled by the caller at upsert time.
|
||||
rows = append(rows, database.UpsertWorkspaceAgentContextResourceParams{
|
||||
Source: r.Source,
|
||||
SourcePath: r.GetSourcePath(),
|
||||
BodyKind: kind,
|
||||
Body: body,
|
||||
ContentHash: append([]byte(nil), r.ContentHash...),
|
||||
//nolint:gosec // Bounded above.
|
||||
SizeBytes: int64(r.SizeBytes),
|
||||
Status: status,
|
||||
Error: r.Error,
|
||||
})
|
||||
}
|
||||
return rows, nil
|
||||
}
|
||||
|
||||
// marshalContextResourceBody picks the body variant set on the wire
|
||||
// resource and returns the (body_kind, body_jsonb) pair stored in
|
||||
// the resource row. The body is protojson encoded so the schema can
|
||||
// be evolved by adding fields to the proto without coderd changes,
|
||||
// and a future reader can round-trip back to the proto type by
|
||||
// switching on body_kind.
|
||||
//
|
||||
// Body is always populated, even on non-OK statuses: the wire
|
||||
// guarantees the oneof variant is set so coderd can still attribute
|
||||
// the failure to a known kind. For variants with no content fields
|
||||
// (mcp_config), an empty JSON object is stored.
|
||||
func marshalContextResourceBody(r *agentproto.ContextResource) (kind database.WorkspaceAgentContextBodyKind, body []byte, err error) {
|
||||
switch b := r.Body.(type) {
|
||||
case *agentproto.ContextResource_InstructionFile:
|
||||
payload := b.InstructionFile
|
||||
if payload == nil {
|
||||
payload = &agentproto.InstructionFileBody{}
|
||||
}
|
||||
body, err = marshalBody(payload)
|
||||
return database.WorkspaceAgentContextBodyKindInstructionFile, body, err
|
||||
case *agentproto.ContextResource_Skill:
|
||||
payload := b.Skill
|
||||
if payload == nil {
|
||||
payload = &agentproto.SkillMetaBody{}
|
||||
}
|
||||
body, err = marshalBody(payload)
|
||||
return database.WorkspaceAgentContextBodyKindSkill, body, err
|
||||
case *agentproto.ContextResource_McpConfig:
|
||||
payload := b.McpConfig
|
||||
if payload == nil {
|
||||
payload = &agentproto.MCPConfigBody{}
|
||||
}
|
||||
body, err = marshalBody(payload)
|
||||
return database.WorkspaceAgentContextBodyKindMcpConfig, body, err
|
||||
case *agentproto.ContextResource_McpServer:
|
||||
payload := b.McpServer
|
||||
if payload == nil {
|
||||
payload = &agentproto.MCPServerBody{}
|
||||
}
|
||||
body, err = marshalBody(payload)
|
||||
return database.WorkspaceAgentContextBodyKindMcpServer, body, err
|
||||
case nil:
|
||||
return "", nil, xerrors.Errorf("missing body variant; status %s requires a typed body", r.Status)
|
||||
default:
|
||||
return "", nil, xerrors.Errorf("unsupported body variant %T", r.Body)
|
||||
}
|
||||
}
|
||||
|
||||
// contextBodyMarshalOptions produces deterministic-ish JSON for the
|
||||
// body so the stored value compares equal across pushes that yield
|
||||
// equivalent protos. Strict canonicalization (RFC 8785) is not
|
||||
// required here; the enum column plus the protojson round trip give
|
||||
// us a stable enough store.
|
||||
var contextBodyMarshalOptions = protojson.MarshalOptions{
|
||||
UseProtoNames: true,
|
||||
EmitUnpopulated: false,
|
||||
}
|
||||
|
||||
// marshalBody is a small wrapper around protojson.Marshal that
|
||||
// keeps the body encoding in one place; future phases that read
|
||||
// these rows mirror the call with protojson.Unmarshal into the
|
||||
// matching proto.Message.
|
||||
func marshalBody(msg proto.Message) ([]byte, error) {
|
||||
out, err := contextBodyMarshalOptions.Marshal(msg)
|
||||
if err != nil {
|
||||
return nil, xerrors.Errorf("marshal body: %w", err)
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// contextResourceStatus translates the wire status enum to the
|
||||
// database enum. STATUS_UNSPECIFIED is rejected: every well-formed
|
||||
// snapshot row needs an explicit status so cache invalidation, dirty
|
||||
// fan-out, and the Sources drawer can reason about partial pushes
|
||||
// deterministically.
|
||||
func contextResourceStatus(s agentproto.ContextResource_Status) (database.WorkspaceAgentContextResourceStatus, error) {
|
||||
switch s {
|
||||
case agentproto.ContextResource_OK:
|
||||
return database.WorkspaceAgentContextResourceStatusOk, nil
|
||||
case agentproto.ContextResource_OVERSIZE:
|
||||
return database.WorkspaceAgentContextResourceStatusOversize, nil
|
||||
case agentproto.ContextResource_UNREADABLE:
|
||||
return database.WorkspaceAgentContextResourceStatusUnreadable, nil
|
||||
case agentproto.ContextResource_INVALID:
|
||||
return database.WorkspaceAgentContextResourceStatusInvalid, nil
|
||||
case agentproto.ContextResource_EXCLUDED:
|
||||
return database.WorkspaceAgentContextResourceStatusExcluded, nil
|
||||
default:
|
||||
return "", xerrors.Errorf("unknown status %d", s)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,600 @@
|
||||
package agentapi_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"encoding/json"
|
||||
"math"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/lib/pq"
|
||||
"github.com/stretchr/testify/require"
|
||||
"go.uber.org/mock/gomock"
|
||||
|
||||
"cdr.dev/slog/v3"
|
||||
"cdr.dev/slog/v3/sloggers/slogtest"
|
||||
agentproto "github.com/coder/coder/v2/agent/proto"
|
||||
"github.com/coder/coder/v2/coderd/agentapi"
|
||||
"github.com/coder/coder/v2/coderd/database"
|
||||
"github.com/coder/coder/v2/coderd/database/dbmock"
|
||||
"github.com/coder/coder/v2/coderd/database/dbtime"
|
||||
"github.com/coder/quartz"
|
||||
)
|
||||
|
||||
func TestPushContextState(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
now := dbtime.Time(time.Date(2026, 6, 1, 12, 0, 0, 0, time.UTC))
|
||||
agentID := uuid.New()
|
||||
clock := quartz.NewMock(t)
|
||||
clock.Set(now)
|
||||
|
||||
makeAPI := func(t *testing.T) (*agentapi.ContextAPI, *dbmock.MockStore) {
|
||||
t.Helper()
|
||||
ctrl := gomock.NewController(t)
|
||||
dbm := dbmock.NewMockStore(ctrl)
|
||||
return &agentapi.ContextAPI{
|
||||
AgentID: agentID,
|
||||
Log: slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug),
|
||||
Clock: clock,
|
||||
Database: dbm,
|
||||
}, dbm
|
||||
}
|
||||
|
||||
// expectInTx wires the dbmock so InTx invokes the closure on the
|
||||
// same mock; tests then set per-method expectations on the same
|
||||
// dbm. The push transaction must run at repeatable read isolation
|
||||
// so concurrent pushes cannot clobber each other.
|
||||
expectInTx := func(dbm *dbmock.MockStore) {
|
||||
dbm.EXPECT().InTx(gomock.Any(), gomock.Any()).Times(1).DoAndReturn(
|
||||
func(f func(database.Store) error, opts *database.TxOptions) error {
|
||||
require.NotNil(t, opts)
|
||||
require.Equal(t, sql.LevelRepeatableRead, opts.Isolation)
|
||||
return f(dbm)
|
||||
},
|
||||
)
|
||||
}
|
||||
|
||||
t.Run("AcceptsInitialPush", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, errNoRows())
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextResource{}, nil).Times(2)
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), database.DeleteStaleWorkspaceAgentContextResourcesParams{
|
||||
WorkspaceAgentID: agentID,
|
||||
ActiveSources: []string{"/home/coder/.mcp.json", "/home/coder/AGENTS.md"},
|
||||
}).Return(nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
AggregateHash: []byte{0x01, 0x02, 0x03},
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/home/coder/AGENTS.md", "hello"),
|
||||
mcpConfigResource("/home/coder/.mcp.json"),
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("RejectsEmptyAndDuplicateSources", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
t.Run("Empty", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("", "x"),
|
||||
},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "empty source")
|
||||
})
|
||||
|
||||
t.Run("Duplicate", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a", "x"),
|
||||
instructionResource("/a", "y"),
|
||||
},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "duplicate source")
|
||||
})
|
||||
})
|
||||
|
||||
t.Run("RejectsUnknownStatus", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, _ := makeAPI(t)
|
||||
// STATUS_UNSPECIFIED is the zero value and must be rejected so
|
||||
// every persisted row has a meaningful status.
|
||||
resource := instructionResource("/a", "x")
|
||||
resource.Status = agentproto.ContextResource_STATUS_UNSPECIFIED
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{resource},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
})
|
||||
|
||||
t.Run("RejectsMissingBody", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
{
|
||||
Source: "/a",
|
||||
ContentHash: []byte{0x01},
|
||||
Status: agentproto.ContextResource_OK,
|
||||
// Body deliberately unset.
|
||||
},
|
||||
},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "missing body")
|
||||
})
|
||||
|
||||
t.Run("StaleVersionDropped", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
// Existing version 5 stored; incoming version 3 with initial=false
|
||||
// is a replay/out-of-order push and must be silently dropped
|
||||
// (accepted=false) without writing.
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{Version: 5}, nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 3,
|
||||
Initial: false,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a", "stale"),
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.False(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("SameVersionReplayDropped", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{Version: 5}, nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 5,
|
||||
Initial: false,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.False(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("InitialOverwritesLowerVersion", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
// Agent rebooted: in-memory counter back to 1 but the stored
|
||||
// version from the previous process boot is 5. initial=true is
|
||||
// authoritative and the push is accepted.
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{Version: 5}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextResource{}, nil)
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), gomock.Any()).
|
||||
Return(nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a", "fresh"),
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("PrunesStaleResources", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{Version: 1}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextResource{}, nil)
|
||||
// Even with one active resource the prune call still runs so
|
||||
// any resource not in the active set is removed in the same
|
||||
// transaction.
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), database.DeleteStaleWorkspaceAgentContextResourcesParams{
|
||||
WorkspaceAgentID: agentID,
|
||||
ActiveSources: []string{"/a"},
|
||||
}).Return(nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 2,
|
||||
Initial: false,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a", "still here"),
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("EmptyResourceListAcceptedAndPrunesAll", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, errNoRows())
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
// Active sources is an explicitly empty slice (not nil) so the
|
||||
// generated SQL deletes every row for this agent rather than
|
||||
// no-oping on a NULL array.
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), database.DeleteStaleWorkspaceAgentContextResourcesParams{
|
||||
WorkspaceAgentID: agentID,
|
||||
ActiveSources: []string{},
|
||||
}).Return(nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("PersistsAllKnownBodyVariants", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, errNoRows())
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
|
||||
gotKinds := map[database.WorkspaceAgentContextBodyKind][]byte{}
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
Times(4).
|
||||
DoAndReturn(func(_ context.Context, arg database.UpsertWorkspaceAgentContextResourceParams) (database.WorkspaceAgentContextResource, error) {
|
||||
gotKinds[arg.BodyKind] = arg.Body
|
||||
return database.WorkspaceAgentContextResource{}, nil
|
||||
})
|
||||
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), gomock.Any()).Return(nil)
|
||||
|
||||
mcpServer := mcpServerResource("/srv/mcp/echo", "echo", "echo server")
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a/AGENTS.md", "hi"),
|
||||
skillResource("/a/.agents/skills/example/SKILL.md", "example", "an example"),
|
||||
mcpConfigResource("/a/.mcp.json"),
|
||||
mcpServer,
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
|
||||
require.Contains(t, gotKinds, database.WorkspaceAgentContextBodyKindInstructionFile)
|
||||
require.Contains(t, gotKinds, database.WorkspaceAgentContextBodyKindSkill)
|
||||
require.Contains(t, gotKinds, database.WorkspaceAgentContextBodyKindMcpConfig)
|
||||
require.Contains(t, gotKinds, database.WorkspaceAgentContextBodyKindMcpServer)
|
||||
|
||||
// Confirm each body deserializes as JSON; the actual proto
|
||||
// roundtrip is exercised by the resolver tests on the agent
|
||||
// side. We just sanity-check the encoding here.
|
||||
for kind, body := range gotKinds {
|
||||
var raw map[string]any
|
||||
err := json.Unmarshal(body, &raw)
|
||||
require.NoErrorf(t, err, "kind %q body not valid JSON: %s", kind, string(body))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("NonOKStatusStillPersisted", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
expectInTx(dbm)
|
||||
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, errNoRows())
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
|
||||
var got database.UpsertWorkspaceAgentContextResourceParams
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
DoAndReturn(func(_ context.Context, arg database.UpsertWorkspaceAgentContextResourceParams) (database.WorkspaceAgentContextResource, error) {
|
||||
got = arg
|
||||
return database.WorkspaceAgentContextResource{}, nil
|
||||
})
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), gomock.Any()).Return(nil)
|
||||
|
||||
oversized := instructionResource("/a/AGENTS.md", "")
|
||||
oversized.Status = agentproto.ContextResource_OVERSIZE
|
||||
oversized.SizeBytes = 65 * 1024
|
||||
oversized.Error = "file exceeds 64KiB per-resource cap"
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{oversized},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.True(t, resp.GetAccepted())
|
||||
require.Equal(t, database.WorkspaceAgentContextBodyKindInstructionFile, got.BodyKind)
|
||||
require.Equal(t, database.WorkspaceAgentContextResourceStatusOversize, got.Status)
|
||||
require.Equal(t, int64(65*1024), got.SizeBytes)
|
||||
require.Equal(t, "file exceeds 64KiB per-resource cap", got.Error)
|
||||
})
|
||||
|
||||
t.Run("SerializationConflictRetries", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
api, dbm := makeAPI(t)
|
||||
|
||||
// First attempt: the closure runs fully but the commit fails
|
||||
// with a serialization error because a concurrent push won the
|
||||
// race. Second attempt: the re-read gate sees the winner's
|
||||
// committed version and drops this push. The response must
|
||||
// report accepted=false even though the first attempt reached
|
||||
// the accepting branch before rolling back.
|
||||
gomock.InOrder(
|
||||
dbm.EXPECT().InTx(gomock.Any(), gomock.Any()).DoAndReturn(
|
||||
func(f func(database.Store) error, opts *database.TxOptions) error {
|
||||
require.Equal(t, sql.LevelRepeatableRead, opts.Isolation)
|
||||
err := f(dbm)
|
||||
require.NoError(t, err)
|
||||
return &pq.Error{Code: "40001"}
|
||||
},
|
||||
),
|
||||
dbm.EXPECT().InTx(gomock.Any(), gomock.Any()).DoAndReturn(
|
||||
func(f func(database.Store) error, _ *database.TxOptions) error {
|
||||
return f(dbm)
|
||||
},
|
||||
),
|
||||
)
|
||||
gomock.InOrder(
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, errNoRows()),
|
||||
dbm.EXPECT().GetLatestWorkspaceAgentContextSnapshot(gomock.Any(), agentID).
|
||||
Return(database.WorkspaceAgentContextSnapshot{Version: 7}, nil),
|
||||
)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextSnapshot(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextSnapshot{}, nil)
|
||||
dbm.EXPECT().UpsertWorkspaceAgentContextResource(gomock.Any(), gomock.Any()).
|
||||
Return(database.WorkspaceAgentContextResource{}, nil)
|
||||
dbm.EXPECT().DeleteStaleWorkspaceAgentContextResources(gomock.Any(), gomock.Any()).Return(nil)
|
||||
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 6,
|
||||
Initial: false,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/a", "racy"),
|
||||
},
|
||||
})
|
||||
require.NoError(t, err)
|
||||
require.False(t, resp.GetAccepted())
|
||||
})
|
||||
|
||||
t.Run("ServerSideLimits", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
// All limit violations fail validation before the transaction
|
||||
// starts, so no database expectations are needed.
|
||||
t.Run("TooManyResources", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resources := make([]*agentproto.ContextResource, 0, 1001)
|
||||
for i := 0; i < 1001; i++ {
|
||||
resources = append(resources, instructionResource("/r/"+string(rune('a'+i%26))+"/"+uuid.NewString(), "x"))
|
||||
}
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: resources,
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "resource cap")
|
||||
})
|
||||
|
||||
t.Run("VersionOverflowsInt64", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: uint64(math.MaxInt64) + 1,
|
||||
Initial: true,
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "int64 range")
|
||||
})
|
||||
|
||||
t.Run("SourceTooLong", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/"+strings.Repeat("a", 1024), "x"),
|
||||
},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "byte cap")
|
||||
})
|
||||
|
||||
t.Run("BodyTooLarge", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
// 256KiB of content base64-expands past the 256KiB body cap.
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{
|
||||
instructionResource("/big", strings.Repeat("x", 256*1024)),
|
||||
},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "byte cap")
|
||||
})
|
||||
|
||||
t.Run("AggregateTooLarge", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
// 25 resources just under the per-resource cap together
|
||||
// exceed the 4MiB aggregate cap.
|
||||
content := strings.Repeat("x", 140*1024)
|
||||
resources := make([]*agentproto.ContextResource, 0, 25)
|
||||
for i := 0; i < 25; i++ {
|
||||
resources = append(resources, instructionResource("/agg/"+uuid.NewString(), content))
|
||||
}
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: resources,
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "aggregate body size")
|
||||
})
|
||||
|
||||
t.Run("ContentHashTooLong", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resource := instructionResource("/a", "x")
|
||||
resource.ContentHash = make([]byte, 65)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
Resources: []*agentproto.ContextResource{resource},
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "byte cap")
|
||||
})
|
||||
|
||||
t.Run("SnapshotErrorTooLong", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
api, _ := makeAPI(t)
|
||||
resp, err := api.PushContextState(context.Background(), &agentproto.PushContextStateRequest{
|
||||
Version: 1,
|
||||
Initial: true,
|
||||
SnapshotError: strings.Repeat("e", 4097),
|
||||
})
|
||||
require.Error(t, err)
|
||||
require.Nil(t, resp)
|
||||
require.Contains(t, err.Error(), "byte cap")
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
// errNoRows returns the database "no rows" sentinel for the mocks;
|
||||
// the handler uses errors.Is(err, sql.ErrNoRows) to recognize first
|
||||
// pushes vs. updates.
|
||||
func errNoRows() error {
|
||||
return sql.ErrNoRows
|
||||
}
|
||||
|
||||
func instructionResource(source, content string) *agentproto.ContextResource {
|
||||
return &agentproto.ContextResource{
|
||||
Source: source,
|
||||
ContentHash: []byte{0xaa, 0xbb, 0xcc},
|
||||
Status: agentproto.ContextResource_OK,
|
||||
SizeBytes: uint64(len(content)),
|
||||
Body: &agentproto.ContextResource_InstructionFile{
|
||||
InstructionFile: &agentproto.InstructionFileBody{
|
||||
Content: []byte(content),
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func skillResource(source, name, description string) *agentproto.ContextResource {
|
||||
return &agentproto.ContextResource{
|
||||
Source: source,
|
||||
ContentHash: []byte{0x01, 0x02, 0x03},
|
||||
Status: agentproto.ContextResource_OK,
|
||||
Body: &agentproto.ContextResource_Skill{
|
||||
Skill: &agentproto.SkillMetaBody{
|
||||
Meta: []byte("---\nname: " + name + "\n---\nbody"),
|
||||
Name: name,
|
||||
Description: description,
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func mcpConfigResource(source string) *agentproto.ContextResource {
|
||||
return &agentproto.ContextResource{
|
||||
Source: source,
|
||||
ContentHash: []byte{0xde, 0xad, 0xbe, 0xef},
|
||||
Status: agentproto.ContextResource_OK,
|
||||
Body: &agentproto.ContextResource_McpConfig{
|
||||
McpConfig: &agentproto.MCPConfigBody{},
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
func mcpServerResource(source, serverName, description string) *agentproto.ContextResource {
|
||||
return &agentproto.ContextResource{
|
||||
Source: source,
|
||||
ContentHash: []byte{0x10, 0x20, 0x30},
|
||||
Status: agentproto.ContextResource_OK,
|
||||
Body: &agentproto.ContextResource_McpServer{
|
||||
McpServer: &agentproto.MCPServerBody{
|
||||
ServerName: serverName,
|
||||
Description: description,
|
||||
},
|
||||
},
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user